Hadoop Common
  1. Hadoop Common
  2. HADOOP-7594

Support HTTP REST in HttpServer

        Details

        • Type: New Feature New Feature
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 0.20.205.0, 0.23.0, 0.24.0
        • Component/s: None
        • Labels:
          None
        • Hadoop Flags:
          Reviewed

          Description

          Provide an API in HttpServer for supporting HTTP REST.

          This is a part of HDFS-2284.

          1. Text File
            c7594_20110830.patch
            9 kB
            Tsz Wo Nicholas Sze
          2. Text File
            c7594_20110830b.patch
            9 kB
            Tsz Wo Nicholas Sze
          3. Text File
            c7594_20110831_0.20s.patch
            9 kB
            Tsz Wo Nicholas Sze
          4. Text File
            c7594_20110831.patch
            10 kB
            Tsz Wo Nicholas Sze

            Issue Links

            is part of

            Sub-task - The sub-task of the issue HDFS-2284 Write Http access to HDFS

            • Major - Major loss of function.
            • Closed
            relates to

            Improvement - An improvement or enhancement to an existing feature or task. HADOOP-7600 Generalize HttpServer addServlet API

            • Major - Major loss of function.
            • Open

              Activity

              Descending order - Click to sort in ascending order
              Hide
              Permalink
              Matt Foley added a comment -

              Closed upon release of 0.20.205.0

              Show
              Matt Foley added a comment - Closed upon release of 0.20.205.0
              Hide
              Permalink
              Tsz Wo Nicholas Sze added a comment -

              Committed this to 0.20s.

              Show
              Tsz Wo Nicholas Sze added a comment - Committed this to 0.20s.
              Hide
              Permalink
              Tsz Wo Nicholas Sze added a comment -

              c7594_20110831_0.20s.patch: for 0.20s.

              Show
              Tsz Wo Nicholas Sze added a comment - c7594_20110831_0.20s.patch: for 0.20s.
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Mapreduce-trunk #803 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/803/)
              HADOOP-7594. Support HTTP REST in HttpServer.

              szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1163858
              Files :

              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/resource
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/resource/JerseyResource.java
              • /hadoop/common/trunk/hadoop-project/pom.xml
              Show
              Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #803 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/803/ ) HADOOP-7594 . Support HTTP REST in HttpServer. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1163858 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/resource /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/resource/JerseyResource.java /hadoop/common/trunk/hadoop-project/pom.xml
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Hdfs-trunk #779 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/779/)
              HADOOP-7594. Support HTTP REST in HttpServer.

              szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1163858
              Files :

              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/resource
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/resource/JerseyResource.java
              • /hadoop/common/trunk/hadoop-project/pom.xml
              Show
              Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #779 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/779/ ) HADOOP-7594 . Support HTTP REST in HttpServer. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1163858 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/resource /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/resource/JerseyResource.java /hadoop/common/trunk/hadoop-project/pom.xml
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Mapreduce-trunk-Commit #827 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/827/)
              HADOOP-7594. Support HTTP REST in HttpServer.

              szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1163858
              Files :

              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/resource
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/resource/JerseyResource.java
              • /hadoop/common/trunk/hadoop-project/pom.xml
              Show
              Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #827 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/827/ ) HADOOP-7594 . Support HTTP REST in HttpServer. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1163858 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/resource /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/resource/JerseyResource.java /hadoop/common/trunk/hadoop-project/pom.xml
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Hdfs-trunk-Commit #894 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/894/)
              HADOOP-7594. Support HTTP REST in HttpServer.

              szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1163858
              Files :

              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/resource
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/resource/JerseyResource.java
              • /hadoop/common/trunk/hadoop-project/pom.xml
              Show
              Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #894 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/894/ ) HADOOP-7594 . Support HTTP REST in HttpServer. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1163858 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/resource /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/resource/JerseyResource.java /hadoop/common/trunk/hadoop-project/pom.xml
              Hide
              Permalink
              Hudson added a comment -

              Integrated in Hadoop-Common-trunk-Commit #817 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/817/)
              HADOOP-7594. Support HTTP REST in HttpServer.

              szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1163858
              Files :

              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/resource
              • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/resource/JerseyResource.java
              • /hadoop/common/trunk/hadoop-project/pom.xml
              Show
              Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #817 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/817/ ) HADOOP-7594 . Support HTTP REST in HttpServer. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1163858 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/resource /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/resource/JerseyResource.java /hadoop/common/trunk/hadoop-project/pom.xml
              Hide
              Permalink
              Tsz Wo Nicholas Sze added a comment -

              > ... new method violates the HttpServer abstraction which is to hide the actual server implementations (note, there is no jetty stuff leaked out of HttpServer). ...

              I don't agree that. Firstly, the new method requires packageName and pathSpec as parameters. They are strings but not Jetty specific. Secondly, there are existing public methods requiring Jetty class as a parameter, e.g. the ctxt parameter in public void addContext(Context ctxt, boolean isFiltered). So the abstraction is not as clear as suggested.

              Anyway, it would be great if you would like to improve it.

              Show
              Tsz Wo Nicholas Sze added a comment - > ... new method violates the HttpServer abstraction which is to hide the actual server implementations (note, there is no jetty stuff leaked out of HttpServer). ... I don't agree that. Firstly, the new method requires packageName and pathSpec as parameters. They are strings but not Jetty specific. Secondly, there are existing public methods requiring Jetty class as a parameter, e.g. the ctxt parameter in public void addContext(Context ctxt, boolean isFiltered) . So the abstraction is not as clear as suggested. Anyway, it would be great if you would like to improve it.
              Hide
              Permalink
              Tsz Wo Nicholas Sze added a comment -

              > ... new method violates the HttpServer abstraction which is to hide the actual server implementations (note, there is no jetty stuff leaked out of HttpServer). ...

              I don't agree that. Firstly, the new method requires packageName and pathSpec as parameters. They are strings but not Jetty specific. Secondly, there are existing public methods requiring Jetty class as a parameter, e.g. the ctxt parameter in public void addContext(Context ctxt, boolean isFiltered). So the abstraction is not as clear as suggested.

              Anyway, it would be great if you would like to improve it.

              Show
              Tsz Wo Nicholas Sze added a comment - > ... new method violates the HttpServer abstraction which is to hide the actual server implementations (note, there is no jetty stuff leaked out of HttpServer). ... I don't agree that. Firstly, the new method requires packageName and pathSpec as parameters. They are strings but not Jetty specific. Secondly, there are existing public methods requiring Jetty class as a parameter, e.g. the ctxt parameter in public void addContext(Context ctxt, boolean isFiltered) . So the abstraction is not as clear as suggested. Anyway, it would be great if you would like to improve it.
              Hide
              Permalink
              Luke Lu added a comment -

              It's unfortunate that hadoop-common becomes a kitchen sink. o.a.h.fs.s3, o.a.h.fs.kfs, o.a.h.fs.ftp and now o.a.h.fs.http should really be in their own modules (it's easy now thanks to the mavenization effort).

              Jersey dependencies in HttpServer (and hadoop-common) is not necessary and the new method violates the HttpServer abstraction which is to hide the actual server implementations (note, there is no jetty stuff leaked out of HttpServer). We just need a more generalized form of addServlet so init parameters can be set.

              Opening a JIRA to address this.

              Show
              Luke Lu added a comment - It's unfortunate that hadoop-common becomes a kitchen sink. o.a.h.fs.s3, o.a.h.fs.kfs, o.a.h.fs.ftp and now o.a.h.fs.http should really be in their own modules (it's easy now thanks to the mavenization effort). Jersey dependencies in HttpServer (and hadoop-common) is not necessary and the new method violates the HttpServer abstraction which is to hide the actual server implementations (note, there is no jetty stuff leaked out of HttpServer). We just need a more generalized form of addServlet so init parameters can be set. Opening a JIRA to address this.
              Hide
              Permalink
              Tsz Wo Nicholas Sze added a comment -

              I have committed this.

              Show
              Tsz Wo Nicholas Sze added a comment - I have committed this.
              Hide
              Permalink
              Tsz Wo Nicholas Sze added a comment -

              > -1 patch. The patch command could not apply the patch.

              It was due to HADOOP-7598. The patch is fine.

              Show
              Tsz Wo Nicholas Sze added a comment - > -1 patch. The patch command could not apply the patch. It was due to HADOOP-7598 . The patch is fine.
              Hide
              Permalink
              Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12492532/c7594_20110831.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 6 new or modified tests.

              -1 patch. The patch command could not apply the patch.

              Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/114//console

              This message is automatically generated.

              Show
              Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12492532/c7594_20110831.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/114//console This message is automatically generated.
              Hide
              Permalink
              Alejandro Abdelnur added a comment -

              from POM side looks good.

              Show
              Alejandro Abdelnur added a comment - from POM side looks good.
              Hide
              Permalink
              Tsz Wo Nicholas Sze added a comment -

              Thanks Suresh and Alejandro for the reviews.

              c7594_20110831.patch: added javadoc and fixed pom.xml.

              Show
              Tsz Wo Nicholas Sze added a comment - Thanks Suresh and Alejandro for the reviews. c7594_20110831.patch: added javadoc and fixed pom.xml.
              Hide
              Permalink
              Alejandro Abdelnur added a comment -

              The Jersey artifacts with version should be added to the hadoop-project/pom.xml in the dependency management section.

              In the hadoop-common-project/hadoop-common/pom.xml they should be without version tag.

              By doing this, all dependencies versions are tracked/managed from one location for the whole project.

              Show
              Alejandro Abdelnur added a comment - The Jersey artifacts with version should be added to the hadoop-project/pom.xml in the dependency management section. In the hadoop-common-project/hadoop-common/pom.xml they should be without version tag. By doing this, all dependencies versions are tracked/managed from one location for the whole project.
              Hide
              Permalink
              Suresh Srinivas added a comment -

              Minor comments:

              1. Add javadoc to JerseyResource.
              2. More comments to addResourcePackage related to the arguments will be nice.

              +1 for the patch.

              Show
              Suresh Srinivas added a comment - Minor comments: Add javadoc to JerseyResource. More comments to addResourcePackage related to the arguments will be nice. +1 for the patch.
              Hide
              Permalink
              Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12492405/c7594_20110830b.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 6 new or modified tests.

              +1 javadoc. The javadoc tool did not generate any warning messages.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              -1 core tests. The patch failed these unit tests:

              org.apache.hadoop.ipc.TestAvroRpc
              org.apache.hadoop.fs.TestPath
              org.apache.hadoop.conf.TestConfiguration
              org.apache.hadoop.io.serializer.avro.TestAvroSerialization
              org.apache.hadoop.io.TestEnumSetWritable
              org.apache.hadoop.io.TestText

              +1 contrib tests. The patch passed contrib unit tests.

              Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/107//testReport/
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/107//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-auth.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/107//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/107//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-annotations.html
              Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/107//console

              This message is automatically generated.

              Show
              Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12492405/c7594_20110830b.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.ipc.TestAvroRpc org.apache.hadoop.fs.TestPath org.apache.hadoop.conf.TestConfiguration org.apache.hadoop.io.serializer.avro.TestAvroSerialization org.apache.hadoop.io.TestEnumSetWritable org.apache.hadoop.io.TestText +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/107//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/107//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-auth.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/107//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/107//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-annotations.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/107//console This message is automatically generated.
              Hide
              Permalink
              Tsz Wo Nicholas Sze added a comment -

              c7594_20110830b.patch: updated with trunk.

              Show
              Tsz Wo Nicholas Sze added a comment - c7594_20110830b.patch: updated with trunk.
              Hide
              Permalink
              Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12492226/c7594_20110830.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 6 new or modified tests.

              -1 patch. The patch command could not apply the patch.

              Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/106//console

              This message is automatically generated.

              Show
              Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12492226/c7594_20110830.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/106//console This message is automatically generated.
              Hide
              Permalink
              Tsz Wo Nicholas Sze added a comment -

              The findbugs warnings were from hadoop-auth. The failed tests were not related to the patch. They were Avro related or failed with NoSuchMethodError/NoSuchClassError.

              Show
              Tsz Wo Nicholas Sze added a comment - The findbugs warnings were from hadoop-auth. The failed tests were not related to the patch. They were Avro related or failed with NoSuchMethodError/NoSuchClassError.
              Hide
              Permalink
              Hadoop QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12492226/c7594_20110830.patch
              against trunk revision .

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 6 new or modified tests.

              +1 javadoc. The javadoc tool did not generate any warning messages.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              -1 core tests. The patch failed these unit tests:

              org.apache.hadoop.ipc.TestAvroRpc
              org.apache.hadoop.fs.TestPath
              org.apache.hadoop.conf.TestConfiguration
              org.apache.hadoop.io.serializer.avro.TestAvroSerialization
              org.apache.hadoop.io.TestEnumSetWritable
              org.apache.hadoop.io.TestText

              +1 contrib tests. The patch passed contrib unit tests.

              Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/100//testReport/
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/100//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-auth.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/100//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
              Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/100//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-annotations.html
              Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/100//console

              This message is automatically generated.

              Show
              Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12492226/c7594_20110830.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.ipc.TestAvroRpc org.apache.hadoop.fs.TestPath org.apache.hadoop.conf.TestConfiguration org.apache.hadoop.io.serializer.avro.TestAvroSerialization org.apache.hadoop.io.TestEnumSetWritable org.apache.hadoop.io.TestText +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/100//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/100//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-auth.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/100//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/100//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-annotations.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/100//console This message is automatically generated.
              Hide
              Permalink
              Tsz Wo Nicholas Sze added a comment -

              c7594_20110830.patch: added HttpServer.addJerseyResourcePackage(..).

              Show
              Tsz Wo Nicholas Sze added a comment - c7594_20110830.patch: added HttpServer.addJerseyResourcePackage(..).

                People

                • Assignee:
                  Tsz Wo Nicholas Sze
                  Reporter:
                  Tsz Wo Nicholas Sze
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development