Hadoop Common
  1. Hadoop Common
  2. HADOOP-7568

SequenceFile should not print into stdout

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0, 0.23.0, 0.24.0
    • Component/s: io
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The following line in SequenceFile.Reader.initialize() should be removed:

      System.out.println("Setting end to " + end);
      
      1. HADOOP-7568.023.patch
        0.3 kB
        Plamen Jeliazkov
      2. HADOOP-7568.patch
        0.4 kB
        Plamen Jeliazkov
      3. HADOOP-7568.patch
        0.6 kB
        Plamen Jeliazkov
      4. HADOOP-7568.r2.patch
        0.3 kB
        Plamen Jeliazkov

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #792 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/792/)
        HADOOP-7568. SequenceFile should not print into stdout. Contributed by Plamen Jeliazkov.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169925
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #792 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/792/ ) HADOOP-7568 . SequenceFile should not print into stdout. Contributed by Plamen Jeliazkov. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169925 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #816 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/816/)
        HADOOP-7568. SequenceFile should not print into stdout. Contributed by Plamen Jeliazkov.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169925
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #816 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/816/ ) HADOOP-7568 . SequenceFile should not print into stdout. Contributed by Plamen Jeliazkov. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169925 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-22-branch #73 (See https://builds.apache.org/job/Hadoop-Common-22-branch/73/)
        HADOOP-7568. SequenceFile should not print into stdout. Contributed by Plamen Jeliazkov.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169930
        Files :

        • /hadoop/common/branches/branch-0.22/common/CHANGES.txt
        • /hadoop/common/branches/branch-0.22/common/src/java/org/apache/hadoop/io/SequenceFile.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-22-branch #73 (See https://builds.apache.org/job/Hadoop-Common-22-branch/73/ ) HADOOP-7568 . SequenceFile should not print into stdout. Contributed by Plamen Jeliazkov. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169930 Files : /hadoop/common/branches/branch-0.22/common/CHANGES.txt /hadoop/common/branches/branch-0.22/common/src/java/org/apache/hadoop/io/SequenceFile.java
        Hide
        Harsh J added a comment -

        Plamen,

        P.s. Just to let you in on little secrets of us here's what most of us do:

        $ git checkout <branch/tag>
        $ vim <file> # Or eclipse, etc. Editing++
        $ ant/maven/tests etc.
        $ git diff --no-prefix > PATCH.file

        Or if on svn:

        $ svn diff > PATCH.file # From project's root directory.

        This is also covered in the HowToContribute document, and should help you avoid creating bad prefixed patches in future!

        Keep up the good work

        Show
        Harsh J added a comment - Plamen, P.s. Just to let you in on little secrets of us here's what most of us do: $ git checkout <branch/tag> $ vim <file> # Or eclipse, etc. Editing++ $ ant/maven/tests etc. $ git diff --no-prefix > PATCH.file Or if on svn: $ svn diff > PATCH.file # From project's root directory. This is also covered in the HowToContribute document, and should help you avoid creating bad prefixed patches in future! Keep up the good work
        Hide
        Konstantin Shvachko added a comment -

        I just committed this. Thank you Plamen.
        Please generate proper patches next time.

        Show
        Konstantin Shvachko added a comment - I just committed this. Thank you Plamen. Please generate proper patches next time.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #886 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/886/)
        HADOOP-7568. SequenceFile should not print into stdout. Contributed by Plamen Jeliazkov.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169925
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #886 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/886/ ) HADOOP-7568 . SequenceFile should not print into stdout. Contributed by Plamen Jeliazkov. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169925 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #951 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/951/)
        HADOOP-7568. SequenceFile should not print into stdout. Contributed by Plamen Jeliazkov.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169925
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #951 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/951/ ) HADOOP-7568 . SequenceFile should not print into stdout. Contributed by Plamen Jeliazkov. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169925 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #874 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/874/)
        HADOOP-7568. SequenceFile should not print into stdout. Contributed by Plamen Jeliazkov.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169925
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #874 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/874/ ) HADOOP-7568 . SequenceFile should not print into stdout. Contributed by Plamen Jeliazkov. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1169925 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12494093/HADOOP-7568.023.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/164//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494093/HADOOP-7568.023.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/164//console This message is automatically generated.
        Hide
        Plamen Jeliazkov added a comment -

        Patch for 0.23 SequenceFile.java

        Show
        Plamen Jeliazkov added a comment - Patch for 0.23 SequenceFile.java
        Hide
        Harsh J added a comment -

        Thank you Plamen! I will remove it from HADOOP-1381, and sorry for all confusions (this one had come in after its patch, which led me to my first response way up above - in retrospect, I made a mistake doing that fork request).

        Show
        Harsh J added a comment - Thank you Plamen! I will remove it from HADOOP-1381 , and sorry for all confusions (this one had come in after its patch, which led me to my first response way up above - in retrospect, I made a mistake doing that fork request).
        Hide
        Plamen Jeliazkov added a comment -

        Thanks Harsh. Yeah I was wondering that was going on there. I will provide a patch for 0.23; no need to up it, you can leave it here and I will attach a patch for 0.23 asap.

        Show
        Plamen Jeliazkov added a comment - Thanks Harsh. Yeah I was wondering that was going on there. I will provide a patch for 0.23; no need to up it, you can leave it here and I will attach a patch for 0.23 asap.
        Hide
        Harsh J added a comment -

        Hey Plamen,

        Your previous patch was fine, given that it is for 0.22 and the Hadoop QA bot isn't that intelligent (yet) to run patches off the right branch. So, fret not.

        +1 to patch HADOOP-7568.patch 12/Sep/11 17:19 for branch 0.22

        As a secondary request (sorry), can you also provide a patch for trunk/0.23 (should be the same). Am gonna fix my last nits (post review by Todd) on HADOOP-1381 and I'm gonna remove away this change which was added as part of it. I think it makes sense if it goes via this JIRA. Let me know if you'd like me to up that one liner instead!

        Thanks!

        Show
        Harsh J added a comment - Hey Plamen, Your previous patch was fine, given that it is for 0.22 and the Hadoop QA bot isn't that intelligent (yet) to run patches off the right branch. So, fret not. +1 to patch HADOOP-7568 .patch 12/Sep/11 17:19 for branch 0.22 As a secondary request (sorry), can you also provide a patch for trunk/0.23 (should be the same). Am gonna fix my last nits (post review by Todd) on HADOOP-1381 and I'm gonna remove away this change which was added as part of it. I think it makes sense if it goes via this JIRA. Let me know if you'd like me to up that one liner instead! Thanks!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12494084/HADOOP-7568.r2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/163//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494084/HADOOP-7568.r2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/163//console This message is automatically generated.
        Hide
        Plamen Jeliazkov added a comment -

        Last one, I promise.

        Show
        Plamen Jeliazkov added a comment - Last one, I promise.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12494068/HADOOP-7568.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/162//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494068/HADOOP-7568.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/162//console This message is automatically generated.
        Hide
        Plamen Jeliazkov added a comment -

        Patch fixed.

        Show
        Plamen Jeliazkov added a comment - Patch fixed.
        Hide
        Konstantin Shvachko added a comment -

        Should be removed, not logged. And don't need to remove package statement.

        Show
        Konstantin Shvachko added a comment - Should be removed, not logged. And don't need to remove package statement.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12493826/HADOOP-7568.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/152//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12493826/HADOOP-7568.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/152//console This message is automatically generated.
        Hide
        Plamen Jeliazkov added a comment -

        Patch fix.

        Show
        Plamen Jeliazkov added a comment - Patch fix.
        Hide
        Harsh J added a comment -

        Hello Konstantin,

        I'd added this patch as part of HADOOP-1381 which I'll be updating for inclusion now.

        Looks like this JIRA tends to 0.22.x branch, in which case it is fine to go in as another patch?

        Show
        Harsh J added a comment - Hello Konstantin, I'd added this patch as part of HADOOP-1381 which I'll be updating for inclusion now. Looks like this JIRA tends to 0.22.x branch, in which case it is fine to go in as another patch?
        Hide
        Konstantin Shvachko added a comment -

        Probably was used as debug printout in HADOOP-6856.

        Show
        Konstantin Shvachko added a comment - Probably was used as debug printout in HADOOP-6856 .

          People

          • Assignee:
            Plamen Jeliazkov
            Reporter:
            Konstantin Shvachko
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development