Hadoop Common
  1. Hadoop Common
  2. HADOOP-7555

Add a eclipse-generated files to .gitignore

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The .gitignore file in the hadoop-mapreduce directory specifically excludes .classpath, .settings, and .project files/dirs. We should move these excludes to the top level .gitignore so that Common and HDFS have these files excluded as well.

      1. hadoop-7555.0.patch
        0.4 kB
        Aaron T. Myers

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #753 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/753/)
        HADOOP-7555. Add a eclipse-generated files to .gitignore. (atm)

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1159350
        Files :

        • /hadoop/common/trunk/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce/.gitignore
        • /hadoop/common/trunk/.gitignore
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #753 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/753/ ) HADOOP-7555 . Add a eclipse-generated files to .gitignore. (atm) atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1159350 Files : /hadoop/common/trunk/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce/.gitignore /hadoop/common/trunk/.gitignore
        Hide
        Aaron T. Myers added a comment -

        Thanks a lot for the review, Todd. I've just committed this.

        Show
        Aaron T. Myers added a comment - Thanks a lot for the review, Todd. I've just committed this.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12490827/hadoop-7555.0.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/49//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/49//artifact/trunk/target/newPatchFindbugsWarningshadoop-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/49//artifact/trunk/target/newPatchFindbugsWarningshadoop-annotations.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/49//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12490827/hadoop-7555.0.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/49//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/49//artifact/trunk/target/newPatchFindbugsWarningshadoop-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/49//artifact/trunk/target/newPatchFindbugsWarningshadoop-annotations.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/49//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        +1

        Show
        Todd Lipcon added a comment - +1
        Hide
        Aaron T. Myers added a comment -

        Patch which addresses the issue.

        Show
        Aaron T. Myers added a comment - Patch which addresses the issue.

          People

          • Assignee:
            Aaron T. Myers
            Reporter:
            Aaron T. Myers
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development