Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-7552

FileUtil#fullyDelete doesn't throw IOE but lists it in the throws clause

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      FileUtil#fullyDelete doesn't throw IOException so it shouldn't have IOException in its throws clause. Having it listed makes it easy to think you'll get an IOException eg trying to delete a non-existant file or on an IO error accessing the local file, but you don't.

        Attachments

        1. hadoop-7552-1.patch
          24 kB
          Eli Collins
        2. hadoop-7552-2.patch
          31 kB
          Eli Collins
        3. hadoop-7552-3.patch
          28 kB
          Eli Collins
        4. hadoop-7552-3.patch
          31 kB
          Eli Collins
        5. hadoop-7552-3.patch
          31 kB
          Eli Collins

          Activity

            People

            • Assignee:
              eli Eli Collins
              Reporter:
              eli Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: