Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: build
    • Labels:
      None
    • Environment:

      Windows

    • Hadoop Flags:
      Reviewed

      Description

      Maven does not run in window for the following reasons:

      • Enforcer plugin restricts build to Unix
      • Ant run snippets to create TAR are not cygwin friendly
      1. HADOOP-7528v1.patch
        6 kB
        Alejandro Abdelnur

        Issue Links

          Activity

          Alejandro Abdelnur created issue -
          Hide
          Alejandro Abdelnur added a comment -

          Patch removes Unix restriction and makes TAR scripts cygwin friendly. In addition handles JDK tools.jar in the same way it is done for Linux (Mac JDK is the green dog).

          Show
          Alejandro Abdelnur added a comment - Patch removes Unix restriction and makes TAR scripts cygwin friendly. In addition handles JDK tools.jar in the same way it is done for Linux (Mac JDK is the green dog).
          Alejandro Abdelnur made changes -
          Field Original Value New Value
          Attachment HADOOP-7528v1.patch [ 12489756 ]
          Hide
          Alejandro Abdelnur added a comment -

          Tested that build works on Windows7, Centos 5.5 & OSX 10.6.8

          Show
          Alejandro Abdelnur added a comment - Tested that build works on Windows7, Centos 5.5 & OSX 10.6.8
          Alejandro Abdelnur made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Uma Maheswara Rao G added a comment -

          Hi Alejandro,

          Looks this patch contains the changes from multiple folders (hadoop-project, hadoop-assemblies, hadoop-annotations..etc).
          Befor i used to apply the patch by just right click on the root folder and apply patch from SVN options. But now it does not work for me with this patch.
          I need to apply patch manually. Any commands you have for applying the patch directly across the projects in windows?

          --Thanks

          Show
          Uma Maheswara Rao G added a comment - Hi Alejandro, Looks this patch contains the changes from multiple folders (hadoop-project, hadoop-assemblies, hadoop-annotations..etc). Befor i used to apply the patch by just right click on the root folder and apply patch from SVN options. But now it does not work for me with this patch. I need to apply patch manually. Any commands you have for applying the patch directly across the projects in windows? --Thanks
          Hide
          Uma Maheswara Rao G added a comment -

          I applied the patch,
          I could build successfully

          [INFO] ------------------------------------------------------------------------
          [INFO] Reactor Summary:
          [INFO]
          [INFO] Apache Hadoop Project POM ......................... SUCCESS [1.111s]
          [INFO] Apache Hadoop Assemblies .......................... SUCCESS [1.126s]
          [INFO] Apache Hadoop Annotations ......................... SUCCESS [1.345s]
          [INFO] Apache Hadoop Common .............................. SUCCESS [39.528s]
          [INFO] Apache Hadoop Main ................................ SUCCESS [0.141s]
          [INFO] ------------------------------------------------------------------------
          [INFO] BUILD SUCCESS
          [INFO] ------------------------------------------------------------------------
          [INFO] Total time: 43.595s
          [INFO] Finished at: Tue Aug 09 14:24:29 IST 2011
          [INFO] Final Memory: 16M/53M

          Thanks Alejandro!

          can you give me command to apply patch for cross projects(cross projects... hadoop-project, hadoop-assemblies, hadoop-annotations..etc).
          Because this patch contains the changes from hadoop-project, hadoop-assemblies, hadoop-annotations..etc.

          Other than this, changes are looks good.

          Show
          Uma Maheswara Rao G added a comment - I applied the patch, I could build successfully [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Apache Hadoop Project POM ......................... SUCCESS [1.111s] [INFO] Apache Hadoop Assemblies .......................... SUCCESS [1.126s] [INFO] Apache Hadoop Annotations ......................... SUCCESS [1.345s] [INFO] Apache Hadoop Common .............................. SUCCESS [39.528s] [INFO] Apache Hadoop Main ................................ SUCCESS [0.141s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 43.595s [INFO] Finished at: Tue Aug 09 14:24:29 IST 2011 [INFO] Final Memory: 16M/53M Thanks Alejandro! can you give me command to apply patch for cross projects(cross projects... hadoop-project, hadoop-assemblies, hadoop-annotations..etc). Because this patch contains the changes from hadoop-project, hadoop-assemblies, hadoop-annotations..etc. Other than this, changes are looks good.
          Uma Maheswara Rao G made changes -
          Link This issue is related to HADOOP-6671 [ HADOOP-6671 ]
          Hide
          Alejandro Abdelnur added a comment -

          Uma, from trunk dir run

          trunk > patch -p0 < HADOOP-7528v1.patch
          

          Thxs

          Show
          Alejandro Abdelnur added a comment - Uma, from trunk dir run trunk > patch -p0 < HADOOP-7528v1.patch Thxs
          Hide
          Uma Maheswara Rao G added a comment -

          Thanks Alejandro, it works for me

          Patch looks good.
          +1 from my side.

          Show
          Uma Maheswara Rao G added a comment - Thanks Alejandro, it works for me Patch looks good. +1 from my side.
          Hide
          Tom White added a comment -

          +1

          Tests pass and test-patch gives the following (no new tests since this is a build change):

          -1 overall.  
          
              +1 @author.  The patch does not contain any @author tags.
          
              -1 tests included.  The patch doesn't appear to include any new or modified tests.
                                  Please justify why no new tests are needed for this patch.
                                  Also please list what manual steps were performed to verify this patch.
          
              +1 javadoc.  The javadoc tool did not generate any warning messages.
          
              +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
          
              +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.
          
              +1 release audit.  The applied patch does not increase the total number of release audit warnings.
          
              +1 system test framework.  The patch passed system test framework compile.
          
          Show
          Tom White added a comment - +1 Tests pass and test-patch gives the following (no new tests since this is a build change): -1 overall. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 system test framework. The patch passed system test framework compile.
          Hide
          Tom White added a comment -

          I've just committed this. Thanks Alejandro!

          Show
          Tom White added a comment - I've just committed this. Thanks Alejandro!
          Tom White made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #713 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/713/)
          HADOOP-7528. Maven build fails in Windows. Contributed by Alejandro Abdelnur.

          tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1155448
          Files :

          • /hadoop/common/trunk/hadoop-assemblies/pom.xml
          • /hadoop/common/trunk/pom.xml
          • /hadoop/common/trunk/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common/pom.xml
          • /hadoop/common/trunk/hadoop-project/pom.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #713 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/713/ ) HADOOP-7528 . Maven build fails in Windows. Contributed by Alejandro Abdelnur. tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1155448 Files : /hadoop/common/trunk/hadoop-assemblies/pom.xml /hadoop/common/trunk/pom.xml /hadoop/common/trunk/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common/pom.xml /hadoop/common/trunk/hadoop-project/pom.xml
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          9m 54s 1 Alejandro Abdelnur 08/Aug/11 23:12
          Patch Available Patch Available Resolved Resolved
          19h 51m 1 Tom White 09/Aug/11 19:03
          Resolved Resolved Closed Closed
          97d 6h 46m 1 Arun C Murthy 15/Nov/11 00:50

            People

            • Assignee:
              Alejandro Abdelnur
              Reporter:
              Alejandro Abdelnur
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development