Hadoop Common
  1. Hadoop Common
  2. HADOOP-7526

Add TestPath tests for URI conversion and reserved characters

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TestPath needs tests that cover URI conversion (eg places where Paths and URIs differ) and handling of URI reserved characters in paths.

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #733 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/733/)
        HADOOP-7526. Add TestPath tests for URI conversion and reserved characters. Contributed by Eli Collins

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156857
        Files :

        • /hadoop/common/trunk/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common/src/test/java/org/apache/hadoop/fs/TestPath.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #733 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/733/ ) HADOOP-7526 . Add TestPath tests for URI conversion and reserved characters. Contributed by Eli Collins eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156857 Files : /hadoop/common/trunk/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common/src/test/java/org/apache/hadoop/fs/TestPath.java
        Hide
        Eli Collins added a comment -

        Thanks atm! I've committed this.

        Show
        Eli Collins added a comment - Thanks atm! I've committed this.
        Hide
        Aaron T. Myers added a comment -

        +1, patch looks good to me.

        Show
        Aaron T. Myers added a comment - +1, patch looks good to me.
        Hide
        Eli Collins added a comment -

        test-patch results..

        +1 overall.  
        
            +1 @author.  The patch does not contain any @author tags.
        
            +1 tests included.  The patch appears to include 3 new or modified tests.
        
            +1 javadoc.  The javadoc tool did not generate any warning messages.
        
            +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
        
            +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.
        
            +1 release audit.  The applied patch does not increase the total number of release audit warnings.
        
            +1 system test framework.  The patch passed system test framework compile.
        
        Show
        Eli Collins added a comment - test-patch results.. +1 overall. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 system test framework. The patch passed system test framework compile.
        Hide
        Eli Collins added a comment -

        Patch attached.

        Show
        Eli Collins added a comment - Patch attached.

          People

          • Assignee:
            Eli Collins
            Reporter:
            Eli Collins
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development