Hadoop Common
  1. Hadoop Common
  2. HADOOP-7412 Mavenization Umbrella
  3. HADOOP-7496

break Maven TAR & bintar profiles into just LAYOUT & TAR proper

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently the tar & bintar profile create the layout and create tarball.

      For development it would be convenient to break them into layout and tar, thus not having to pay the overhead of TARing up.

      1. HADOOP-7496v1.patch
        14 kB
        Alejandro Abdelnur
      2. HADOOP-7496v2.patch
        52 kB
        Alejandro Abdelnur

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #761 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/761/)
          HADOOP-7496. Break Maven TAR & bintar profiles into just LAYOUT & TAR proper. Contributed by Alejandro Abdelnur.

          tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160344
          Files :

          • /hadoop/common/trunk/hadoop-project-dist/README.txt
          • /hadoop/common/trunk/hadoop-assemblies/src/main/resources/assemblies/hadoop-tar.xml
          • /hadoop/common/trunk/pom.xml
          • /hadoop/common/trunk/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs/pom.xml
          • /hadoop/common/trunk/hadoop-project-dist/pom.xml
          • /hadoop/common/trunk/hadoop-common/pom.xml
          • /hadoop/common/trunk/BUILDING.txt
          • /hadoop/common/trunk/hadoop-assemblies/src/main/resources/assemblies/hadoop-dist.xml
          • /hadoop/common/trunk/hadoop-project-distro
          • /hadoop/common/trunk/hadoop-project-dist
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #761 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/761/ ) HADOOP-7496 . Break Maven TAR & bintar profiles into just LAYOUT & TAR proper. Contributed by Alejandro Abdelnur. tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160344 Files : /hadoop/common/trunk/hadoop-project-dist/README.txt /hadoop/common/trunk/hadoop-assemblies/src/main/resources/assemblies/hadoop-tar.xml /hadoop/common/trunk/pom.xml /hadoop/common/trunk/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs/pom.xml /hadoop/common/trunk/hadoop-project-dist/pom.xml /hadoop/common/trunk/hadoop-common/pom.xml /hadoop/common/trunk/BUILDING.txt /hadoop/common/trunk/hadoop-assemblies/src/main/resources/assemblies/hadoop-dist.xml /hadoop/common/trunk/hadoop-project-distro /hadoop/common/trunk/hadoop-project-dist
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #763 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/763/)
          HADOOP-7496. Break Maven TAR & bintar profiles into just LAYOUT & TAR proper. Contributed by Alejandro Abdelnur.

          tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160344
          Files :

          • /hadoop/common/trunk/hadoop-project-dist/README.txt
          • /hadoop/common/trunk/hadoop-assemblies/src/main/resources/assemblies/hadoop-tar.xml
          • /hadoop/common/trunk/pom.xml
          • /hadoop/common/trunk/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs/pom.xml
          • /hadoop/common/trunk/hadoop-project-dist/pom.xml
          • /hadoop/common/trunk/hadoop-common/pom.xml
          • /hadoop/common/trunk/BUILDING.txt
          • /hadoop/common/trunk/hadoop-assemblies/src/main/resources/assemblies/hadoop-dist.xml
          • /hadoop/common/trunk/hadoop-project-distro
          • /hadoop/common/trunk/hadoop-project-dist
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #763 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/763/ ) HADOOP-7496 . Break Maven TAR & bintar profiles into just LAYOUT & TAR proper. Contributed by Alejandro Abdelnur. tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160344 Files : /hadoop/common/trunk/hadoop-project-dist/README.txt /hadoop/common/trunk/hadoop-assemblies/src/main/resources/assemblies/hadoop-tar.xml /hadoop/common/trunk/pom.xml /hadoop/common/trunk/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs/pom.xml /hadoop/common/trunk/hadoop-project-dist/pom.xml /hadoop/common/trunk/hadoop-common/pom.xml /hadoop/common/trunk/BUILDING.txt /hadoop/common/trunk/hadoop-assemblies/src/main/resources/assemblies/hadoop-dist.xml /hadoop/common/trunk/hadoop-project-distro /hadoop/common/trunk/hadoop-project-dist
          Hide
          Tom White added a comment -

          I've just committed this. Thanks, Alejandro!

          Show
          Tom White added a comment - I've just committed this. Thanks, Alejandro!
          Hide
          Eric Yang added a comment -

          +1 looks good.

          Show
          Eric Yang added a comment - +1 looks good.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12490955/HADOOP-7496v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/56//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12490955/HADOOP-7496v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/56//console This message is automatically generated.
          Hide
          Alejandro Abdelnur added a comment -

          that was 'v2'

          Show
          Alejandro Abdelnur added a comment - that was 'v2'
          Hide
          Alejandro Abdelnur added a comment -

          renaming distro to dist

          Show
          Alejandro Abdelnur added a comment - renaming distro to dist
          Hide
          Alejandro Abdelnur added a comment -

          Regarding 'why not have tar profiles activates distro profile?'

          I was trying to do that, but a profile cannot activate another profile. That is why I've went the -D way (the -D enables a conditional TARing). I assume that for RPM/DEB we could do the same.

          Sure we can use dist as the profile name, I'll update the patch with the rename.

          Show
          Alejandro Abdelnur added a comment - Regarding 'why not have tar profiles activates distro profile?' I was trying to do that, but a profile cannot activate another profile. That is why I've went the -D way (the -D enables a conditional TARing). I assume that for RPM/DEB we could do the same. Sure we can use dist as the profile name, I'll update the patch with the rename.
          Hide
          Eric Yang added a comment -

          Why not have tar profile activates distro profile? It would be nice to keep maven package -P [tar|deb|rpm] consistent across project rather than using -D flag to toggle types.

          In addition, it would be nice to use dist instead of distro to be consistent with most open source projects.

          Show
          Eric Yang added a comment - Why not have tar profile activates distro profile? It would be nice to keep maven package -P [tar|deb|rpm] consistent across project rather than using -D flag to toggle types. In addition, it would be nice to use dist instead of distro to be consistent with most open source projects.
          Hide
          Alejandro Abdelnur added a comment -

          Current patch works on top of HDFS-2096 version 'AJ' and HADOOP-7498v1

          Show
          Alejandro Abdelnur added a comment - Current patch works on top of HDFS-2096 version 'AJ' and HADOOP-7498 v1
          Hide
          Alejandro Abdelnur added a comment -

          It work both for common & hdfs

          Show
          Alejandro Abdelnur added a comment - It work both for common & hdfs
          Hide
          Alejandro Abdelnur added a comment -

          breaks tar profile into to steps:

          -Pdistro : creates the layout in target/$

          {PROJECT}

          -$

          {VERSION}

          /

          -Dtar : creates a tar with it.

          Example:

          $ mvn package -Pdistro # creates layout

          $ mvn package -Pdistro -Dtar # creates in addition the TAR

          Show
          Alejandro Abdelnur added a comment - breaks tar profile into to steps: -Pdistro : creates the layout in target/$ {PROJECT} -$ {VERSION} / -Dtar : creates a tar with it. Example: $ mvn package -Pdistro # creates layout $ mvn package -Pdistro -Dtar # creates in addition the TAR

            People

            • Assignee:
              Alejandro Abdelnur
              Reporter:
              Alejandro Abdelnur
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development