Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-7487

DF should throw a more reasonable exception when mount cannot be determined

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.23.0, 2.0.3-alpha, 3.0.0-alpha1
    • 2.1.0-beta
    • fs
    • Reviewed

    Description

      Currently, when using the DF class to determine the mount corresponding to a given directory, it will throw the generic exception "Expecting a line not the end of stream" if it can't determine the mount (for example if the directory doesn't exist).

      This error message should be improved in several ways:

      1. If the dir to check doesn't exist, we can see that before even execing df, and throw a better exception (or behave better by chopping path components until it exists)
      2. Rather than parsing the lines out of df's stdout, collect the whole output, and then parse. So, if df returns a non-zero exit code, we can avoid trying to parse the empty result
      3. If there's a success exit code, and we still can't parse it (eg incompatible OS), we should include the unparseable line in the exception message.

      Attachments

        1. hadoop-7487-1.patch
          9 kB
          Andrew Wang
        2. hadoop-7487-2.patch
          9 kB
          Andrew Wang
        3. hadoop-7487-3.patch
          9 kB
          Andrew Wang

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            andrew.wang Andrew Wang
            tlipcon Todd Lipcon
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment