Hadoop Common
  1. Hadoop Common
  2. HADOOP-7474

Refactor ClientCache out of WritableRpcEngine.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This jira captures the changes in common corresponding to MAPREDUCE-2707.
      Moving ClientCache out into its own class makes sense because it can be used by other RpcEngine implementations as well.

      1. HADOOP-7474.1.patch
        7 kB
        Jitendra Nath Pandey
      2. HADOOP-7474.4.patch
        8 kB
        Jitendra Nath Pandey

        Issue Links

          Activity

          Hide
          Jitendra Nath Pandey added a comment -

          Committed.

          Show
          Jitendra Nath Pandey added a comment - Committed.
          Hide
          Jitendra Nath Pandey added a comment -

          The patch has been tested manually on a secure cluster. Also it only does refactoring, with no change to logic. Therefore, I believe no additional unit tests are required.

          Show
          Jitendra Nath Pandey added a comment - The patch has been tested manually on a secure cluster. Also it only does refactoring, with no change to logic. Therefore, I believe no additional unit tests are required.
          Hide
          Jitendra Nath Pandey added a comment -

          This patch adds InterfaceAudience and InterfaceStability annotations as suggested by Suresh.
          Rational for the patch:
          We want to remove TunnelProtocol from ProtoOverHadoopRpcEngine. Therefore this rpc engine needs to call getConnectionId. Also we want to add a ClientCache to this engine just as in WritableRpcEngine. Since ClientCache has nothing specific to an rpc engine, it makes sense to move that into a separate class which any rpc engine implementation can use.

          Show
          Jitendra Nath Pandey added a comment - This patch adds InterfaceAudience and InterfaceStability annotations as suggested by Suresh. Rational for the patch: We want to remove TunnelProtocol from ProtoOverHadoopRpcEngine. Therefore this rpc engine needs to call getConnectionId. Also we want to add a ClientCache to this engine just as in WritableRpcEngine. Since ClientCache has nothing specific to an rpc engine, it makes sense to move that into a separate class which any rpc engine implementation can use.
          Hide
          Suresh Srinivas added a comment -

          BTW add InterfaceAudience.LimitedPrivate and InterfaceStability.Evolving, instead of what I suggest in my previous comment 1)

          Show
          Suresh Srinivas added a comment - BTW add InterfaceAudience.LimitedPrivate and InterfaceStability.Evolving, instead of what I suggest in my previous comment 1)
          Hide
          Suresh Srinivas added a comment -

          Comments:

          1. Please add annotations to Client.ConnectionId and ClientCache - InterfaceAudience.Private.
          2. Please add description about the change you are making (see my previous comment) so that people looking at this jira can understand the change.

          +1 for the patch.

          Show
          Suresh Srinivas added a comment - Comments: Please add annotations to Client.ConnectionId and ClientCache - InterfaceAudience.Private. Please add description about the change you are making (see my previous comment) so that people looking at this jira can understand the change. +1 for the patch.
          Hide
          Suresh Srinivas added a comment -

          Can you please add some description about the change you are making.

          Show
          Suresh Srinivas added a comment - Can you please add some description about the change you are making.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12486943/HADOOP-7474.1.patch
          against trunk revision 1151594.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/774//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/774//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/774//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12486943/HADOOP-7474.1.patch against trunk revision 1151594. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/774//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/774//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/774//console This message is automatically generated.

            People

            • Assignee:
              Jitendra Nath Pandey
              Reporter:
              Jitendra Nath Pandey
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development