Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: fs, ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There are several fields in the log that the space characters are missed.
      For instance:
      src/java/org/apache/hadoop/ipc/Client.java(248): LOG.debug("The ping interval is" + this.pingInterval + "ms.");
      src/java/org/apache/hadoop/fs/LocalDirAllocator.java(235): LOG.warn( localDirs[i] + "is not writable¥n", de);

        Activity

        XieXianshan created issue -
        XieXianshan made changes -
        Field Original Value New Value
        Attachment HADOOP-7465.patch [ 12486794 ]
        Uma Maheswara Rao G made changes -
        Parent HADOOP-7466 [ 12502178 ]
        Issue Type Improvement [ 4 ] Sub-task [ 7 ]
        Arun C Murthy made changes -
        Priority Major [ 3 ] Trivial [ 5 ]
        Hide
        Aaron T. Myers added a comment -

        Marking as patch available so Hudson runs the pre-commit tests.

        Show
        Aaron T. Myers added a comment - Marking as patch available so Hudson runs the pre-commit tests.
        Aaron T. Myers made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12486794/HADOOP-7465.patch
        against trunk revision 1147317.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/741//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/741//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/741//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12486794/HADOOP-7465.patch against trunk revision 1147317. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/741//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/741//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/741//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        +1

        Since this is trivial (two spaces in warning/debug) I'll commit this pre hudson.

        Show
        Eli Collins added a comment - +1 Since this is trivial (two spaces in warning/debug) I'll commit this pre hudson.
        Eli Collins made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Eli Collins added a comment -

        Thanks Xie Xianshan!

        Show
        Eli Collins added a comment - Thanks Xie Xianshan!
        Eli Collins made changes -
        Fix Version/s 0.23.0 [ 12315569 ]
        Affects Version/s 0.23.0 [ 12315569 ]
        Component/s fs [ 12310689 ]
        Component/s ipc [ 12310688 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #692 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/692/)
        HADOOP-7465. A several tiny improvements for the LOG format. Contributed by Xie Xianshan

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147952
        Files :

        • /hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/LocalDirAllocator.java
        • /hadoop/common/trunk/common/CHANGES.txt
        • /hadoop/common/trunk/common/src/java/org/apache/hadoop/ipc/Client.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #692 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/692/ ) HADOOP-7465 . A several tiny improvements for the LOG format. Contributed by Xie Xianshan eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147952 Files : /hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/LocalDirAllocator.java /hadoop/common/trunk/common/CHANGES.txt /hadoop/common/trunk/common/src/java/org/apache/hadoop/ipc/Client.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #751 (See https://builds.apache.org/job/Hadoop-Common-trunk/751/)
        HADOOP-7465. A several tiny improvements for the LOG format. Contributed by Xie Xianshan

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147952
        Files :

        • /hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/LocalDirAllocator.java
        • /hadoop/common/trunk/common/CHANGES.txt
        • /hadoop/common/trunk/common/src/java/org/apache/hadoop/ipc/Client.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #751 (See https://builds.apache.org/job/Hadoop-Common-trunk/751/ ) HADOOP-7465 . A several tiny improvements for the LOG format. Contributed by Xie Xianshan eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147952 Files : /hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/LocalDirAllocator.java /hadoop/common/trunk/common/CHANGES.txt /hadoop/common/trunk/common/src/java/org/apache/hadoop/ipc/Client.java
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        9h 49m 1 Aaron T. Myers 18/Jul/11 16:08
        Patch Available Patch Available Resolved Resolved
        15m 51s 1 Eli Collins 18/Jul/11 16:24
        Resolved Resolved Closed Closed
        119d 8h 26m 1 Arun C Murthy 15/Nov/11 00:50

          People

          • Assignee:
            XieXianshan
            Reporter:
            XieXianshan
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development