Hadoop Common
  1. Hadoop Common
  2. HADOOP-7463

Adding a configuration parameter to SecurityInfo interface.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HADOOP-6929 allowed to make implementations/providers of SecurityInfo to be configurable via service class loaders. For adding Security to TunnelProtocols, configuration is needed to figure out which particular interface getKerberosInfo is called for. Just the class name is not enough since its always TunnerProtocol for all the interfaces. I propose adding a config to getKerberosInfo, so that its easy for TunnerProtocols to get the information they need.

      1. HADOOP-7463.patch
        8 kB
        Mahadev konar
      2. HADOOP-7463.patch
        5 kB
        Mahadev konar
      3. HADOOP-7463.patch
        5 kB
        Mahadev konar

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #757 (See https://builds.apache.org/job/Hadoop-Common-trunk/757/)
        HADOOP-7463. Adding a configuration parameter to SecurityInfo interface. (mahadev)

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150565
        Files :

        • /hadoop/common/trunk/common/src/java/org/apache/hadoop/security/AnnotatedSecurityInfo.java
        • /hadoop/common/trunk/common/CHANGES.txt
        • /hadoop/common/trunk/common/src/java/org/apache/hadoop/security/SecurityUtil.java
        • /hadoop/common/trunk/common/src/java/org/apache/hadoop/security/authorize/ServiceAuthorizationManager.java
        • /hadoop/common/trunk/common/src/java/org/apache/hadoop/security/SecurityInfo.java
        • /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/ipc/TestSaslRPC.java
        • /hadoop/common/trunk/common/src/java/org/apache/hadoop/ipc/Client.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #757 (See https://builds.apache.org/job/Hadoop-Common-trunk/757/ ) HADOOP-7463 . Adding a configuration parameter to SecurityInfo interface. (mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150565 Files : /hadoop/common/trunk/common/src/java/org/apache/hadoop/security/AnnotatedSecurityInfo.java /hadoop/common/trunk/common/CHANGES.txt /hadoop/common/trunk/common/src/java/org/apache/hadoop/security/SecurityUtil.java /hadoop/common/trunk/common/src/java/org/apache/hadoop/security/authorize/ServiceAuthorizationManager.java /hadoop/common/trunk/common/src/java/org/apache/hadoop/security/SecurityInfo.java /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/ipc/TestSaslRPC.java /hadoop/common/trunk/common/src/java/org/apache/hadoop/ipc/Client.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #697 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/697/)
        HADOOP-7463. Adding a configuration parameter to SecurityInfo interface. (mahadev)

        mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150565
        Files :

        • /hadoop/common/trunk/common/src/java/org/apache/hadoop/security/AnnotatedSecurityInfo.java
        • /hadoop/common/trunk/common/CHANGES.txt
        • /hadoop/common/trunk/common/src/java/org/apache/hadoop/security/SecurityUtil.java
        • /hadoop/common/trunk/common/src/java/org/apache/hadoop/security/authorize/ServiceAuthorizationManager.java
        • /hadoop/common/trunk/common/src/java/org/apache/hadoop/security/SecurityInfo.java
        • /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/ipc/TestSaslRPC.java
        • /hadoop/common/trunk/common/src/java/org/apache/hadoop/ipc/Client.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #697 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/697/ ) HADOOP-7463 . Adding a configuration parameter to SecurityInfo interface. (mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150565 Files : /hadoop/common/trunk/common/src/java/org/apache/hadoop/security/AnnotatedSecurityInfo.java /hadoop/common/trunk/common/CHANGES.txt /hadoop/common/trunk/common/src/java/org/apache/hadoop/security/SecurityUtil.java /hadoop/common/trunk/common/src/java/org/apache/hadoop/security/authorize/ServiceAuthorizationManager.java /hadoop/common/trunk/common/src/java/org/apache/hadoop/security/SecurityInfo.java /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/ipc/TestSaslRPC.java /hadoop/common/trunk/common/src/java/org/apache/hadoop/ipc/Client.java
        Hide
        Mahadev konar added a comment -

        I just pushed this.

        Show
        Mahadev konar added a comment - I just pushed this.
        Hide
        Jitendra Nath Pandey added a comment -

        +1

        Show
        Jitendra Nath Pandey added a comment - +1
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12487672/HADOOP-7463.patch
        against trunk revision 1149760.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/762//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/762//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/762//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12487672/HADOOP-7463.patch against trunk revision 1149760. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/762//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/762//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/762//console This message is automatically generated.
        Hide
        Mahadev konar added a comment -

        Updated patch.

        Show
        Mahadev konar added a comment - Updated patch.
        Hide
        Jitendra Nath Pandey added a comment -

        +1 for the patch.

        Show
        Jitendra Nath Pandey added a comment - +1 for the patch.
        Hide
        Mahadev konar added a comment -

        Minor update. Added LimitedPrivate(HDFS/MapReduce)

        Show
        Mahadev konar added a comment - Minor update. Added LimitedPrivate(HDFS/MapReduce)
        Hide
        Mahadev konar added a comment -

        Added a config parameter to getKerberosInfo()

        Show
        Mahadev konar added a comment - Added a config parameter to getKerberosInfo()

          People

          • Assignee:
            Mahadev konar
            Reporter:
            Mahadev konar
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development