Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-7402

TestConfiguration doesn't clean up after itself

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      testGetFile and testGetLocalPath both create directories a, b, and c in the working directory from where the tests are run. They should clean up after themselves.

      1. hadoop-7402.0.patch
        3 kB
        Aaron T. Myers
      2. hadoop-7402.1.patch
        2 kB
        Aaron T. Myers

        Activity

        Hide
        atm Aaron T. Myers added a comment -

        Patch which fixes the issue. I manually verified that the created directories are cleaned up after a run of this test.

        Show
        atm Aaron T. Myers added a comment - Patch which fixes the issue. I manually verified that the created directories are cleaned up after a run of this test.
        Hide
        tlipcon Todd Lipcon added a comment -

        Rather than doing that, why not fix the test so that it chdirs into the build directory first? Or sets the conf to point to the build dir?

        Show
        tlipcon Todd Lipcon added a comment - Rather than doing that, why not fix the test so that it chdirs into the build directory first? Or sets the conf to point to the build dir?
        Hide
        tucu00 Alejandro Abdelnur added a comment -

        Those test dirs should be written in the build directory, not to pollute the source tree.

        Using the Java Sys prop 'test.build.data' as the base for those dirs would do.

        Thxs.

        Show
        tucu00 Alejandro Abdelnur added a comment - Those test dirs should be written in the build directory, not to pollute the source tree. Using the Java Sys prop 'test.build.data' as the base for those dirs would do. Thxs.
        Hide
        atm Aaron T. Myers added a comment -

        Patch which uses "test.build.data" as a prefix for the directories.

        Show
        atm Aaron T. Myers added a comment - Patch which uses "test.build.data" as a prefix for the directories.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12482974/hadoop-7402.1.patch
        against trunk revision 1136249.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/648//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/648//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/648//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12482974/hadoop-7402.1.patch against trunk revision 1136249. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/648//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/648//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/648//console This message is automatically generated.
        Hide
        eli Eli Collins added a comment -

        +1

        Show
        eli Eli Collins added a comment - +1
        Hide
        eli Eli Collins added a comment -

        I've committed this. Thanks atm!

        Show
        eli Eli Collins added a comment - I've committed this. Thanks atm!
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #661 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/661/)

        Show
        hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #661 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/661/ )
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Common-trunk-maven #43 (See https://builds.apache.org/job/Hadoop-Common-trunk-maven/43/)

        Show
        hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-maven #43 (See https://builds.apache.org/job/Hadoop-Common-trunk-maven/43/ )
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Common-trunk #732 (See https://builds.apache.org/job/Hadoop-Common-trunk/732/)

        Show
        hudson Hudson added a comment - Integrated in Hadoop-Common-trunk #732 (See https://builds.apache.org/job/Hadoop-Common-trunk/732/ )

          People

          • Assignee:
            atm Aaron T. Myers
            Reporter:
            atm Aaron T. Myers
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development