Hadoop Common
  1. Hadoop Common
  2. HADOOP-7390

VersionInfo not generated properly in git after unsplit

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The version information generated during the build of common when running from git has revision and branch Unknown. I believe this started after the unsplit:

      @HadoopVersionAnnotation(version="0.22.0-SNAPSHOT", revision="Unknown", branch="Unknown",
      user="tgraves", date="Tue Jun 14 13:39:10 UTC 2011", url="file:///home/tgraves/git/hadoop-common/common",
      srcChecksum="0f78ea668971fe51e7ebf4f97f84eed2")

      The ./src/saveVersion.sh script which generates the package-info.java file with the version info looks for the presence of .git directory and that is now a level up instead of in the common directory.

      1. hadoop-7390.txt
        0.4 kB
        Todd Lipcon

        Activity

        Konstantin Shvachko made changes -
        Fix Version/s 0.22.0 [ 12314296 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #779 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/779/)
        HADOOP-7390. Move changes under 0.22 branch.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160424
        Files :

        • /hadoop/common/trunk/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #779 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/779/ ) HADOOP-7390 . Move changes under 0.22 branch. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160424 Files : /hadoop/common/trunk/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #763 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/763/)
        HADOOP-7390. Move changes under 0.22 branch.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160424
        Files :

        • /hadoop/common/trunk/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #763 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/763/ ) HADOOP-7390 . Move changes under 0.22 branch. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160424 Files : /hadoop/common/trunk/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-22-branch #70 (See https://builds.apache.org/job/Hadoop-Common-22-branch/70/)
        HADOOP-7390. VersionInfo not generated properly in git after unsplit. Contributed by Todd Lipcon.
        (todd

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160420
        Files :

        • /hadoop/common/branches/branch-0.22/common/src/saveVersion.sh
        • /hadoop/common/branches/branch-0.22/common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-22-branch #70 (See https://builds.apache.org/job/Hadoop-Common-22-branch/70/ ) HADOOP-7390 . VersionInfo not generated properly in git after unsplit. Contributed by Todd Lipcon. (todd shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160420 Files : /hadoop/common/branches/branch-0.22/common/src/saveVersion.sh /hadoop/common/branches/branch-0.22/common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #766 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/766/)
        HADOOP-7390. Move changes under 0.22 branch.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160424
        Files :

        • /hadoop/common/trunk/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #766 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/766/ ) HADOOP-7390 . Move changes under 0.22 branch. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160424 Files : /hadoop/common/trunk/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #844 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/844/)
        HADOOP-7390. Move changes under 0.22 branch.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160424
        Files :

        • /hadoop/common/trunk/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #844 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/844/ ) HADOOP-7390 . Move changes under 0.22 branch. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1160424 Files : /hadoop/common/trunk/hadoop-common/CHANGES.txt
        Hide
        Konstantin Shvachko added a comment -

        Just committed this to 0.22 branch. Thank you Todd.

        Show
        Konstantin Shvachko added a comment - Just committed this to 0.22 branch. Thank you Todd.
        Joep Rottinghuis made changes -
        Affects Version/s 0.22.0 [ 12314296 ]
        Hide
        Joep Rottinghuis added a comment -

        This is a problem in 0.22 as well. Need to apply same patch.

        Show
        Joep Rottinghuis added a comment - This is a problem in 0.22 as well. Need to apply same patch.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-maven #43 (See https://builds.apache.org/job/Hadoop-Common-trunk-maven/43/)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-maven #43 (See https://builds.apache.org/job/Hadoop-Common-trunk-maven/43/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #656 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/656/)
        HADOOP-7390. VersionInfo not generated properly in git after unsplit. (todd via atm)

        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1136220
        Files :

        • /hadoop/common/trunk/common/src/saveVersion.sh
        • /hadoop/common/trunk/common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #656 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/656/ ) HADOOP-7390 . VersionInfo not generated properly in git after unsplit. (todd via atm) atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1136220 Files : /hadoop/common/trunk/common/src/saveVersion.sh /hadoop/common/trunk/common/CHANGES.txt
        Aaron T. Myers made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Aaron T. Myers added a comment -

        +1 - worked like a charm.

        I've just committed this. Thanks a lot, Todd.

        Show
        Aaron T. Myers added a comment - +1 - worked like a charm. I've just committed this. Thanks a lot, Todd.
        Hide
        Thomas Graves added a comment -

        +1 downloaded and tested patch and it works now. Thanks!

        Show
        Thomas Graves added a comment - +1 downloaded and tested patch and it works now. Thanks!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12482556/hadoop-7390.txt
        against trunk revision 1135636.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/631//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/631//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/631//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12482556/hadoop-7390.txt against trunk revision 1135636. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/631//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/631//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/631//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12482556/hadoop-7390.txt
        against trunk revision 1135633.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/628//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12482556/hadoop-7390.txt against trunk revision 1135633. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/628//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12482556/hadoop-7390.txt
        against trunk revision 1135333.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/626//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12482556/hadoop-7390.txt against trunk revision 1135333. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/626//console This message is automatically generated.
        Todd Lipcon made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Todd Lipcon made changes -
        Attachment hadoop-7390.txt [ 12482556 ]
        Todd Lipcon made changes -
        Field Original Value New Value
        Assignee Todd Lipcon [ tlipcon ]
        Thomas Graves created issue -

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Thomas Graves
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development