Hadoop Common
  1. Hadoop Common
  2. HADOOP-7385

Remove StringUtils.stringifyException(ie) in logger functions

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Apache logger api has an overloaded function which can take the message and exception. I am proposing to clean the logging code with this api.
      ie.:
      Change the code from LOG.warn(msg, StringUtils.stringifyException(exception)); to LOG.warn(msg, exception);

      1. HADOOP-7385-1.patch
        12 kB
        Bharath Mundlapudi

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #668 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/668/)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #668 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/668/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #732 (See https://builds.apache.org/job/Hadoop-Common-trunk/732/)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #732 (See https://builds.apache.org/job/Hadoop-Common-trunk/732/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-maven #43 (See https://builds.apache.org/job/Hadoop-Common-trunk-maven/43/)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-maven #43 (See https://builds.apache.org/job/Hadoop-Common-trunk-maven/43/ )
        Hide
        Tanping Wang added a comment -

        Just committed the patch. Thanks to Bharath Mundlapudi!

        Show
        Tanping Wang added a comment - Just committed the patch. Thanks to Bharath Mundlapudi!
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12482614/HADOOP-7385-1.patch
        against trunk revision 1137724.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/668//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/668//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/668//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12482614/HADOOP-7385-1.patch against trunk revision 1137724. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/668//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/668//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/668//console This message is automatically generated.
        Hide
        Tanping Wang added a comment -

        +1 on the patch.

        Show
        Tanping Wang added a comment - +1 on the patch.
        Hide
        Bharath Mundlapudi added a comment -

        Attaching the patch.

        Show
        Bharath Mundlapudi added a comment - Attaching the patch.

          People

          • Assignee:
            Bharath Mundlapudi
            Reporter:
            Bharath Mundlapudi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development