Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Activity

      Hide
      Hudson added a comment -

      Integrated in Hadoop-Common-trunk #717 (See https://builds.apache.org/job/Hadoop-Common-trunk/717/)
      HADOOP-7375. Add resolvePath method to FileContext. Contributed by Sanjay Radia

      eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134854
      Files :

      • /hadoop/common/trunk/CHANGES.txt
      • /hadoop/common/trunk/src/test/core/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java
      • /hadoop/common/trunk/src/java/org/apache/hadoop/fs/FileContext.java
      Show
      Hudson added a comment - Integrated in Hadoop-Common-trunk #717 (See https://builds.apache.org/job/Hadoop-Common-trunk/717/ ) HADOOP-7375 . Add resolvePath method to FileContext. Contributed by Sanjay Radia eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134854 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/test/core/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java /hadoop/common/trunk/src/java/org/apache/hadoop/fs/FileContext.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Common-trunk-maven #13 (See https://builds.apache.org/job/Hadoop-Common-trunk-maven/13/)
      HADOOP-7375. Add resolvePath method to FileContext. Contributed by Sanjay Radia

      eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134854
      Files :

      • /hadoop/common/trunk/CHANGES.txt
      • /hadoop/common/trunk/src/test/core/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java
      • /hadoop/common/trunk/src/java/org/apache/hadoop/fs/FileContext.java
      Show
      Hudson added a comment - Integrated in Hadoop-Common-trunk-maven #13 (See https://builds.apache.org/job/Hadoop-Common-trunk-maven/13/ ) HADOOP-7375 . Add resolvePath method to FileContext. Contributed by Sanjay Radia eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134854 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/test/core/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java /hadoop/common/trunk/src/java/org/apache/hadoop/fs/FileContext.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Common-trunk-Commit #647 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/647/)
      HADOOP-7375. Add resolvePath method to FileContext. Contributed by Sanjay Radia

      eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134854
      Files :

      • /hadoop/common/trunk/CHANGES.txt
      • /hadoop/common/trunk/src/test/core/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java
      • /hadoop/common/trunk/src/java/org/apache/hadoop/fs/FileContext.java
      Show
      Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #647 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/647/ ) HADOOP-7375 . Add resolvePath method to FileContext. Contributed by Sanjay Radia eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134854 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/test/core/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java /hadoop/common/trunk/src/java/org/apache/hadoop/fs/FileContext.java
      Hide
      Eli Collins added a comment -

      I've committed this. Thanks Sanjay.

      Show
      Eli Collins added a comment - I've committed this. Thanks Sanjay.
      Hide
      Eli Collins added a comment -

      Ah, never mind, I thought it was previously calling FC#getFileStatus.

      +1 feel free to address the nits directly in the commit since it's just indentation.

      Show
      Eli Collins added a comment - Ah, never mind, I thought it was previously calling FC#getFileStatus. +1 feel free to address the nits directly in the commit since it's just indentation.
      Hide
      Sanjay Radia added a comment -

      >AFS#getFileStatus is now called instead of FileContext#getFileStatus, which means
      >fixRelativePart is no longer used to make the path absolute in FileContext relative to the
      >working dir before passing the path to AFS right?

      No sure if your question is with regards to all the methods in FileContext or the single method I changed.
      I have changed the FileContext#resolve to call AFS#resolvePath(p) which currently calls
      AFS#getFileStatus(p)

      Show
      Sanjay Radia added a comment - >AFS#getFileStatus is now called instead of FileContext#getFileStatus, which means >fixRelativePart is no longer used to make the path absolute in FileContext relative to the >working dir before passing the path to AFS right? No sure if your question is with regards to all the methods in FileContext or the single method I changed. I have changed the FileContext#resolve to call AFS#resolvePath(p) which currently calls AFS#getFileStatus(p)
      Hide
      Suresh Srinivas added a comment -

      +1 with Eli's comments addressed.

      Show
      Suresh Srinivas added a comment - +1 with Eli's comments addressed.
      Hide
      Hadoop QA added a comment -

      +1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12482023/resolvePath1.patch
      against trunk revision 1133125.

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed core unit tests.

      +1 system test framework. The patch passed system test framework compile.

      Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/608//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/608//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
      Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/608//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12482023/resolvePath1.patch against trunk revision 1133125. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/608//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/608//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/608//console This message is automatically generated.
      Hide
      Eli Collins added a comment -

      AFS#getFileStatus is now called instead of FileContext#getFileStatus, which means fixRelativePart is no longer used to make the path absolute in FileContext relative to the working dir before passing the path to AFS right?

      Nit: lines 568 and 2231 need indenting. Otherwise looks great.

      Show
      Eli Collins added a comment - AFS#getFileStatus is now called instead of FileContext#getFileStatus, which means fixRelativePart is no longer used to make the path absolute in FileContext relative to the working dir before passing the path to AFS right? Nit: lines 568 and 2231 need indenting. Otherwise looks great.

        People

        • Assignee:
          Sanjay Radia
          Reporter:
          Sanjay Radia
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development