Hadoop Common
  1. Hadoop Common
  2. HADOOP-7358

Improve log levels when exceptions caught in RPC handler

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0, 0.23.7
    • Component/s: ipc
    • Labels:
      None

      Description

      When a server implementation throws an exception handling an RPC, the Handler thread catches it and logs it before responding with the exception over the IPC channel. This is currently done at INFO level.

      I'd like to propose that, if the exception is an unchecked exception, it should be logged at WARN level instead. This can help alert operators when they might be hitting some kind of bug.

      1. hadoop-7358.txt
        1 kB
        Todd Lipcon
      2. HADOOP-7358.trunk.patch
        1 kB
        Uma Maheswara Rao G

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #548 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/548/)
        svn merge -c 1205697 Merging from trunk to branch-0.23 to fix HADOOP-7358. (Revision 1454530)

        Result = SUCCESS
        kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1454530
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #548 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/548/ ) svn merge -c 1205697 Merging from trunk to branch-0.23 to fix HADOOP-7358 . (Revision 1454530) Result = SUCCESS kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1454530 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        Hide
        Kihwal Lee added a comment -

        Merged to branch-0.23.

        Show
        Kihwal Lee added a comment - Merged to branch-0.23.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #664 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/664/)
        HADOOP-7358. Merge r1205697 from trunk to 0.23 (Revision 1298207)

        Result = SUCCESS
        suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298207
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #664 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/664/ ) HADOOP-7358 . Merge r1205697 from trunk to 0.23 (Revision 1298207) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298207 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        Hide
        Tsz Wo Nicholas Sze added a comment -

        > I just committed this to trunk and 0.22 branch. ...

        Trunk and 0.22 but not 0.23?

        Show
        Tsz Wo Nicholas Sze added a comment - > I just committed this to trunk and 0.22 branch. ... Trunk and 0.22 but not 0.23?
        Hide
        Eli Collins added a comment -

        Marking for 23.

        Show
        Eli Collins added a comment - Marking for 23.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #907 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/907/)
        HADOOP-7358. Improve log levels when exceptions caught in RPC handler. Contributed by Todd Lipcon.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1205697
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #907 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/907/ ) HADOOP-7358 . Improve log levels when exceptions caught in RPC handler. Contributed by Todd Lipcon. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1205697 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #873 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/873/)
        HADOOP-7358. Improve log levels when exceptions caught in RPC handler. Contributed by Todd Lipcon.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1205697
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #873 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/873/ ) HADOOP-7358 . Improve log levels when exceptions caught in RPC handler. Contributed by Todd Lipcon. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1205697 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-22-branch #99 (See https://builds.apache.org/job/Hadoop-Common-22-branch/99/)
        HADOOP-7358. Improve log levels when exceptions caught in RPC handler. Contributed by Todd Lipcon.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1205699
        Files :

        • /hadoop/common/branches/branch-0.22/common/CHANGES.txt
        • /hadoop/common/branches/branch-0.22/common/src/java/org/apache/hadoop/ipc/Server.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-22-branch #99 (See https://builds.apache.org/job/Hadoop-Common-22-branch/99/ ) HADOOP-7358 . Improve log levels when exceptions caught in RPC handler. Contributed by Todd Lipcon. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1205699 Files : /hadoop/common/branches/branch-0.22/common/CHANGES.txt /hadoop/common/branches/branch-0.22/common/src/java/org/apache/hadoop/ipc/Server.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1393 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1393/)
        HADOOP-7358. Improve log levels when exceptions caught in RPC handler. Contributed by Todd Lipcon.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1205697
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1393 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1393/ ) HADOOP-7358 . Improve log levels when exceptions caught in RPC handler. Contributed by Todd Lipcon. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1205697 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1320 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1320/)
        HADOOP-7358. Improve log levels when exceptions caught in RPC handler. Contributed by Todd Lipcon.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1205697
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1320 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1320/ ) HADOOP-7358 . Improve log levels when exceptions caught in RPC handler. Contributed by Todd Lipcon. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1205697 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1343 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1343/)
        HADOOP-7358. Improve log levels when exceptions caught in RPC handler. Contributed by Todd Lipcon.

        shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1205697
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1343 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1343/ ) HADOOP-7358 . Improve log levels when exceptions caught in RPC handler. Contributed by Todd Lipcon. shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1205697 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        Hide
        Konstantin Shvachko added a comment -

        I just committed this to trunk and 0.22 branch. Thank you Todd and Uma.

        Show
        Konstantin Shvachko added a comment - I just committed this to trunk and 0.22 branch. Thank you Todd and Uma.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12495404/HADOOP-7358.trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings).

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/215//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/215//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/215//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12495404/HADOOP-7358.trunk.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings). +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/215//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/215//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/215//console This message is automatically generated.
        Hide
        Uma Maheswara Rao G added a comment -

        Hi Konstantin,

        Onbehalf of todd,I have just put the patch for trunk.

        Can you please take a look!

        Thanks
        Uma

        Show
        Uma Maheswara Rao G added a comment - Hi Konstantin, Onbehalf of todd,I have just put the patch for trunk. Can you please take a look! Thanks Uma
        Hide
        Konstantin Shvachko added a comment -

        Todd, could you provide a patch for trunk as well.

        Show
        Konstantin Shvachko added a comment - Todd, could you provide a patch for trunk as well.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12481410/hadoop-7358.txt
        against trunk revision 1137065.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/654//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/654//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/654//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481410/hadoop-7358.txt against trunk revision 1137065. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/654//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/654//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/654//console This message is automatically generated.
        Hide
        Harsh J added a comment -

        (Marking as PA since Todd may have forgotten to – For Hudson)

        Show
        Harsh J added a comment - (Marking as PA since Todd may have forgotten to – For Hudson)
        Hide
        Eli Collins added a comment -

        +1 pending hudson

        Show
        Eli Collins added a comment - +1 pending hudson
        Hide
        Todd Lipcon added a comment -

        Simple patch attached. No test case since it's just a log level change.

        Show
        Todd Lipcon added a comment - Simple patch attached. No test case since it's just a log level change.

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development