Hadoop Common
  1. Hadoop Common
  2. HADOOP-7349

HADOOP-7121 accidentally disabled some tests

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: ipc, test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When I converted TestIPC to JUnit 4, I missed a couple of tests towards the bottom of the file when adding the @Test annotation.

      1. hadoop-7349.txt
        1.0 kB
        Todd Lipcon

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #708 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/708/)
        HADOOP-7349. HADOOP-7121 accidentally disabled some tests in TestIPC. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130758
        Files :

        • /hadoop/common/trunk/CHANGES.txt
        • /hadoop/common/trunk/src/test/core/org/apache/hadoop/ipc/TestIPC.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #708 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/708/ ) HADOOP-7349 . HADOOP-7121 accidentally disabled some tests in TestIPC. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130758 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/test/core/org/apache/hadoop/ipc/TestIPC.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-22-branch #61 (See https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/61/)
        HADOOP-7349. HADOOP-7121 accidentally disabled some tests in TestIPC. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130757
        Files :

        • /hadoop/common/branches/branch-0.22/src/test/core/org/apache/hadoop/ipc/TestIPC.java
        • /hadoop/common/branches/branch-0.22/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-22-branch #61 (See https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/61/ ) HADOOP-7349 . HADOOP-7121 accidentally disabled some tests in TestIPC. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130757 Files : /hadoop/common/branches/branch-0.22/src/test/core/org/apache/hadoop/ipc/TestIPC.java /hadoop/common/branches/branch-0.22/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #635 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/635/)
        HADOOP-7349. HADOOP-7121 accidentally disabled some tests in TestIPC. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130758
        Files :

        • /hadoop/common/trunk/CHANGES.txt
        • /hadoop/common/trunk/src/test/core/org/apache/hadoop/ipc/TestIPC.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #635 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/635/ ) HADOOP-7349 . HADOOP-7121 accidentally disabled some tests in TestIPC. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130758 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/test/core/org/apache/hadoop/ipc/TestIPC.java
        Hide
        Todd Lipcon added a comment -

        Committed to 22 and trunk, thanks Eli

        Show
        Todd Lipcon added a comment - Committed to 22 and trunk, thanks Eli
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12481169/hadoop-7349.txt
        against trunk revision 1129989.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/556//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/556//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/556//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481169/hadoop-7349.txt against trunk revision 1129989. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/556//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/556//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/556//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        +1

        Show
        Eli Collins added a comment - +1

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development