Hadoop Common
  1. Hadoop Common
  2. HADOOP-7338

LocalDirAllocator improvements for MR-2178

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      These are some changes that come from the following yahoo-merge commit, necessary for MAPREDUCE-2178 to build.

      commit 446e41f2424ddc866770cda677450c18feeb597f
      Author: Chris Douglas <cdouglas@apache.org>
      Date: Sun Oct 3 02:00:15 2010 -0700

      Apply y201 to trunk

      git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/branches/yahoo-merge@1079151 13f79535-47bb-0310-9956-ffa450edef68

      1. hadoop-7338.patch
        9 kB
        Benoy Antony
      2. hadoop-7338.txt
        9 kB
        Todd Lipcon
      3. hadoop-7338-022.patch
        8 kB
        Benoy Antony

        Issue Links

          Activity

          Hide
          Todd Lipcon added a comment -

          Attaching patch from yahoo-merge. This probably needs a couple unit tests.

          Show
          Todd Lipcon added a comment - Attaching patch from yahoo-merge. This probably needs a couple unit tests.
          Hide
          Nigel Daley added a comment -

          From Hadoop Dev Mtg 7/1/11: Owen will try to get more context on this from the Y! branch merge.

          Show
          Nigel Daley added a comment - From Hadoop Dev Mtg 7/1/11: Owen will try to get more context on this from the Y! branch merge.
          Hide
          Benoy Antony added a comment -

          This patch basically uses the original patch, but made changes so that it compiles with the current code.

          Show
          Benoy Antony added a comment - This patch basically uses the original patch, but made changes so that it compiles with the current code.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12526237/hadoop-7338.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/974//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12526237/hadoop-7338.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/974//console This message is automatically generated.
          Hide
          Benoy Antony added a comment -

          new patch is attached.
          The unused function which returns all paths are removed.
          Also added a unit test to test the case when checkwrite is set to false.

          Show
          Benoy Antony added a comment - new patch is attached. The unused function which returns all paths are removed. Also added a unit test to test the case when checkwrite is set to false.
          Hide
          Konstantin Shvachko added a comment -

          +1
          I just committed this to branch 0.22.1. Thank you Benoy.

          Show
          Konstantin Shvachko added a comment - +1 I just committed this to branch 0.22.1. Thank you Benoy.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-22-branch #106 (See https://builds.apache.org/job/Hadoop-Common-22-branch/106/)
          HADOOP-7338. LocalDirAllocator improvements for MR-2178. Contributed by Benoy Antony. (Revision 1346212)

          Result = SUCCESS
          shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1346212
          Files :

          • /hadoop/common/branches/branch-0.22/common/CHANGES.txt
          • /hadoop/common/branches/branch-0.22/common/src/java/org/apache/hadoop/fs/LocalDirAllocator.java
          • /hadoop/common/branches/branch-0.22/common/src/test/core/org/apache/hadoop/fs/TestLocalDirAllocator.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-22-branch #106 (See https://builds.apache.org/job/Hadoop-Common-22-branch/106/ ) HADOOP-7338 . LocalDirAllocator improvements for MR-2178. Contributed by Benoy Antony. (Revision 1346212) Result = SUCCESS shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1346212 Files : /hadoop/common/branches/branch-0.22/common/CHANGES.txt /hadoop/common/branches/branch-0.22/common/src/java/org/apache/hadoop/fs/LocalDirAllocator.java /hadoop/common/branches/branch-0.22/common/src/test/core/org/apache/hadoop/fs/TestLocalDirAllocator.java

            People

            • Assignee:
              Benoy Antony
              Reporter:
              Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development