Hadoop Common
  1. Hadoop Common
  2. HADOOP-7329

incomplete help message is displayed for df -h option

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The help message for the command "hdfs dfs -help df" is displayed like this:
      "-df [<path> ...]: Shows the capacity, free and used space of the filesystem.
      If the filesystem has multiple partitions, and no path to a
      particular partition is specified, then the status of the root
      partitions will be shown."
      and the information about df -h option is missed,despite the fact that df -h option is implemented.

      Therefore,the expected message should be displayed like this:
      "-df [-h] [<path> ...]: Shows the capacity, free and used space of the filesystem.
      If the filesystem has multiple partitions, and no path to a
      particular partition is specified, then the status of the root
      partitions will be shown.
      -h Formats the sizes of files in a human-readable fashion
      rather than a number of bytes."

      1. HADOOP-7329
        1 kB
        XieXianshan

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #668 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/668/)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #668 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/668/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #732 (See https://builds.apache.org/job/Hadoop-Common-trunk/732/)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #732 (See https://builds.apache.org/job/Hadoop-Common-trunk/732/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-maven #43 (See https://builds.apache.org/job/Hadoop-Common-trunk-maven/43/)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-maven #43 (See https://builds.apache.org/job/Hadoop-Common-trunk-maven/43/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #700 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/700/)
        HADOOP-7329. Improve help message for "df" to include "-h" flag. Contributed by Xie Xianshan.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127576
        Files :

        • /hadoop/common/trunk/CHANGES.txt
        • /hadoop/common/trunk/src/java/org/apache/hadoop/fs/shell/FsUsage.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #700 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/700/ ) HADOOP-7329 . Improve help message for "df" to include "-h" flag. Contributed by Xie Xianshan. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127576 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/java/org/apache/hadoop/fs/shell/FsUsage.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #618 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/618/)
        HADOOP-7329. Improve help message for "df" to include "-h" flag. Contributed by Xie Xianshan.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127576
        Files :

        • /hadoop/common/trunk/CHANGES.txt
        • /hadoop/common/trunk/src/java/org/apache/hadoop/fs/shell/FsUsage.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #618 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/618/ ) HADOOP-7329 . Improve help message for "df" to include "-h" flag. Contributed by Xie Xianshan. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127576 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/java/org/apache/hadoop/fs/shell/FsUsage.java
        Hide
        Todd Lipcon added a comment -

        Committed to trunk. Thanks XieXianshan.

        Show
        Todd Lipcon added a comment - Committed to trunk. Thanks XieXianshan.
        Hide
        Todd Lipcon added a comment -

        +1. I don't think we need tests for this - we don't currently have any tests on help output.

        I manually verified the output of "hadoop fs -help" with the patch and it looks great. Thanks.

        Show
        Todd Lipcon added a comment - +1. I don't think we need tests for this - we don't currently have any tests on help output. I manually verified the output of "hadoop fs -help" with the patch and it looks great. Thanks.
        Hide
        Harsh J added a comment -

        Patch LGTM

        Show
        Harsh J added a comment - Patch LGTM
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12480372/HADOOP-7329
        against trunk revision 1127215.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/522//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/522//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/522//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12480372/HADOOP-7329 against trunk revision 1127215. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/522//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/522//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/522//console This message is automatically generated.
        Hide
        XieXianshan added a comment -

        Fix the help message for df -h option.

        Show
        XieXianshan added a comment - Fix the help message for df -h option.
        Hide
        XieXianshan added a comment -

        fix the help message for df -h option.

        Show
        XieXianshan added a comment - fix the help message for df -h option.

          People

          • Assignee:
            XieXianshan
            Reporter:
            XieXianshan
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development