Hadoop Common
  1. Hadoop Common
  2. HADOOP-7314

Add support for throwing UnknownHostException when a host doesn't resolve

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.205.0, 0.23.0
    • Fix Version/s: 0.20.205.0, 0.23.0
    • Component/s: None
    • Labels:
      None

      Description

      As part of MAPREDUCE-2489, we need support for having the resolve methods (for DNS mapping) throw UnknownHostExceptions. (Currently, they hide the exception). Since the existing 'resolve' method is ultimately used by several other locations/components, I propose we add a new 'resolveValidHosts' method.

      1. HADOOP-7314-v3.patch
        10 kB
        Jeffrey Naisbitt
      2. HADOOP-7314-v2.patch
        10 kB
        Jeffrey Naisbitt
      3. HADOOP-7314-0.20s.patch
        10 kB
        Jeffrey Naisbitt
      4. HADOOP-7314.patch
        10 kB
        Jeffrey Naisbitt

        Issue Links

          Activity

          Jeffrey Naisbitt created issue -
          Jeffrey Naisbitt made changes -
          Field Original Value New Value
          Attachment HADOOP-7314.patch [ 12479905 ]
          Jeffrey Naisbitt made changes -
          Link This issue blocks MAPREDUCE-2489 [ MAPREDUCE-2489 ]
          Jeffrey Naisbitt made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/775/
          -----------------------------------------------------------

          Review request for hadoop-common and hadoop-mapreduce.

          Summary
          -------

          As part of MAPREDUCE-2489, we need support for having the resolve methods (for DNS mapping) throw UnknownHostExceptions. (Currently, they hide the exception). Since the existing 'resolve' method is ultimately used by several other locations/components, I propose we add a new 'resolveValidHosts' method.

          This addresses bug HADOOP-7314.
          https://issues.apache.org/jira/browse/HADOOP-7314

          Diffs


          trunk/src/java/org/apache/hadoop/net/DNSToSwitchMapping.java 1125067
          trunk/src/java/org/apache/hadoop/net/ScriptBasedMapping.java 1125067
          trunk/src/test/core/org/apache/hadoop/net/StaticMapping.java 1125067
          trunk/src/test/core/org/apache/hadoop/net/TestScriptBasedMapping.java 1125067
          trunk/src/java/org/apache/hadoop/net/CachedDNSToSwitchMapping.java 1125067

          Diff: https://reviews.apache.org/r/775/diff

          Testing
          -------

          Thanks,

          Jeffrey

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/775/ ----------------------------------------------------------- Review request for hadoop-common and hadoop-mapreduce. Summary ------- As part of MAPREDUCE-2489 , we need support for having the resolve methods (for DNS mapping) throw UnknownHostExceptions. (Currently, they hide the exception). Since the existing 'resolve' method is ultimately used by several other locations/components, I propose we add a new 'resolveValidHosts' method. This addresses bug HADOOP-7314 . https://issues.apache.org/jira/browse/HADOOP-7314 Diffs trunk/src/java/org/apache/hadoop/net/DNSToSwitchMapping.java 1125067 trunk/src/java/org/apache/hadoop/net/ScriptBasedMapping.java 1125067 trunk/src/test/core/org/apache/hadoop/net/StaticMapping.java 1125067 trunk/src/test/core/org/apache/hadoop/net/TestScriptBasedMapping.java 1125067 trunk/src/java/org/apache/hadoop/net/CachedDNSToSwitchMapping.java 1125067 Diff: https://reviews.apache.org/r/775/diff Testing ------- Thanks, Jeffrey
          Hide
          Robert Joseph Evans added a comment -

          new UrlValidator(UrlValidator.ALLOW_ALL_SCHEMES); is called every time verifyHostnames is called. It would probably be better to have a private member for this, and if it is reentrant have a static private instance.

          Show
          Robert Joseph Evans added a comment - new UrlValidator(UrlValidator.ALLOW_ALL_SCHEMES); is called every time verifyHostnames is called. It would probably be better to have a private member for this, and if it is reentrant have a static private instance.
          Hide
          Jeffrey Naisbitt added a comment -

          Thanks for the review, Robert! I think you meant this comment to go with the MAPREDUCE-2489 patch though, and I will address it there.

          Show
          Jeffrey Naisbitt added a comment - Thanks for the review, Robert! I think you meant this comment to go with the MAPREDUCE-2489 patch though, and I will address it there.
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/775/#review775
          -----------------------------------------------------------

          Ship it!

          +1 Looks good.

          • Tom

          On 2011-05-23 15:49:39, Jeffrey Naisbitt wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/775/

          -----------------------------------------------------------

          (Updated 2011-05-23 15:49:39)

          Review request for hadoop-common and hadoop-mapreduce.

          Summary

          -------

          As part of MAPREDUCE-2489, we need support for having the resolve methods (for DNS mapping) throw UnknownHostExceptions. (Currently, they hide the exception). Since the existing 'resolve' method is ultimately used by several other locations/components, I propose we add a new 'resolveValidHosts' method.

          This addresses bug HADOOP-7314.

          https://issues.apache.org/jira/browse/HADOOP-7314

          Diffs

          -----

          trunk/src/java/org/apache/hadoop/net/DNSToSwitchMapping.java 1125067

          trunk/src/java/org/apache/hadoop/net/ScriptBasedMapping.java 1125067

          trunk/src/test/core/org/apache/hadoop/net/StaticMapping.java 1125067

          trunk/src/test/core/org/apache/hadoop/net/TestScriptBasedMapping.java 1125067

          trunk/src/java/org/apache/hadoop/net/CachedDNSToSwitchMapping.java 1125067

          Diff: https://reviews.apache.org/r/775/diff

          Testing

          -------

          Thanks,

          Jeffrey

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/775/#review775 ----------------------------------------------------------- Ship it! +1 Looks good. Tom On 2011-05-23 15:49:39, Jeffrey Naisbitt wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/775/ ----------------------------------------------------------- (Updated 2011-05-23 15:49:39) Review request for hadoop-common and hadoop-mapreduce. Summary ------- As part of MAPREDUCE-2489 , we need support for having the resolve methods (for DNS mapping) throw UnknownHostExceptions. (Currently, they hide the exception). Since the existing 'resolve' method is ultimately used by several other locations/components, I propose we add a new 'resolveValidHosts' method. This addresses bug HADOOP-7314 . https://issues.apache.org/jira/browse/HADOOP-7314 Diffs ----- trunk/src/java/org/apache/hadoop/net/DNSToSwitchMapping.java 1125067 trunk/src/java/org/apache/hadoop/net/ScriptBasedMapping.java 1125067 trunk/src/test/core/org/apache/hadoop/net/StaticMapping.java 1125067 trunk/src/test/core/org/apache/hadoop/net/TestScriptBasedMapping.java 1125067 trunk/src/java/org/apache/hadoop/net/CachedDNSToSwitchMapping.java 1125067 Diff: https://reviews.apache.org/r/775/diff Testing ------- Thanks, Jeffrey
          Hide
          Jeffrey Naisbitt added a comment -

          I'm not sure why I don't see test-patch results, but here are the results from a manual run:

          [exec] +1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] +1 tests included. The patch appears to include 6 new or modified tests.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
          [exec]
          [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          [exec]
          [exec] +1 system test framework. The patch passed system test framework compile.

          Show
          Jeffrey Naisbitt added a comment - I'm not sure why I don't see test-patch results, but here are the results from a manual run: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile.
          Hide
          Jeffrey Naisbitt added a comment -

          Going to try using java.net.URI instead of UrlValidator to get rid of all the extra dependency stuff.

          Show
          Jeffrey Naisbitt added a comment - Going to try using java.net.URI instead of UrlValidator to get rid of all the extra dependency stuff.
          Jeffrey Naisbitt made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Jeffrey Naisbitt added a comment -

          Updated patch for trunk

          Show
          Jeffrey Naisbitt added a comment - Updated patch for trunk
          Jeffrey Naisbitt made changes -
          Attachment HADOOP-7314-v2.patch [ 12483621 ]
          Jeffrey Naisbitt made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12483621/HADOOP-7314-v2.patch
          against trunk revision 1137724.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/667//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/667//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/667//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483621/HADOOP-7314-v2.patch against trunk revision 1137724. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/667//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/667//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/667//console This message is automatically generated.
          Sherry Chen made changes -
          Affects Version/s 0.20.205.0 [ 12316390 ]
          Hide
          Jeffrey Naisbitt added a comment -

          This portion of the patch is actually for trunk only. The 0.20s patch for MAPREDUCE-2489 contains all the necessary changes for 0.20.205

          Show
          Jeffrey Naisbitt added a comment - This portion of the patch is actually for trunk only. The 0.20s patch for MAPREDUCE-2489 contains all the necessary changes for 0.20.205
          Jeffrey Naisbitt made changes -
          Affects Version/s 0.23.0 [ 12315569 ]
          Affects Version/s 0.20.205.0 [ 12316390 ]
          Hide
          Jitendra Nath Pandey added a comment -

          A few comments:
          1. CachedDNSToSwitchMapping.java#resolve : check for names.isEmpty() is done twice.
          2. CachedDNSToSwitchMapping.java#getCachedHosts: The comment "now everything is in the cache" can be removed now as it is a separate method or put it in javadoc if that's what this method expects. On the same note, the comment "resolve all or nothing" semantics can also be added to the javadoc. It seems to me the two comments are related.
          3. TestScriptBasedMapping.java: I think topology.script.file.name is deprecated now, instead use ScriptBasedMapping.SCRIPT_FILENAME_KEY which is already being used in the test.

          Otherwise the patch looks good.

          Show
          Jitendra Nath Pandey added a comment - A few comments: 1. CachedDNSToSwitchMapping.java#resolve : check for names.isEmpty() is done twice. 2. CachedDNSToSwitchMapping.java#getCachedHosts: The comment "now everything is in the cache" can be removed now as it is a separate method or put it in javadoc if that's what this method expects. On the same note, the comment "resolve all or nothing" semantics can also be added to the javadoc. It seems to me the two comments are related. 3. TestScriptBasedMapping.java: I think topology.script.file.name is deprecated now, instead use ScriptBasedMapping.SCRIPT_FILENAME_KEY which is already being used in the test. Otherwise the patch looks good.
          Hide
          Jeffrey Naisbitt added a comment -

          Thanks for the review! I'll post an updated patch soon.

          Also, for consistency I will move the corresponding portion of the 0.20.205 patch from MAPREDUCE-2489 to here.

          Show
          Jeffrey Naisbitt added a comment - Thanks for the review! I'll post an updated patch soon. Also, for consistency I will move the corresponding portion of the 0.20.205 patch from MAPREDUCE-2489 to here.
          Hide
          Jeffrey Naisbitt added a comment -

          Updated patch addressing Jitendra's comments. Also attaching 0.20.205 patch here too.

          Show
          Jeffrey Naisbitt added a comment - Updated patch addressing Jitendra's comments. Also attaching 0.20.205 patch here too.
          Jeffrey Naisbitt made changes -
          Attachment HADOOP-7314-0.20s.patch [ 12486477 ]
          Attachment HADOOP-7314-v3.patch [ 12486478 ]
          Jeffrey Naisbitt made changes -
          Affects Version/s 0.20.205.0 [ 12316390 ]
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12486478/HADOOP-7314-v3.patch
          against trunk revision 1146300.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/732//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/732//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/732//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12486478/HADOOP-7314-v3.patch against trunk revision 1146300. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/732//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/732//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/732//console This message is automatically generated.
          Hide
          Jitendra Nath Pandey added a comment -

          +1 for the patch.

          Show
          Jitendra Nath Pandey added a comment - +1 for the patch.
          Hide
          Jitendra Nath Pandey added a comment -

          I have committed this. Thanks to Jeffrey!

          Show
          Jitendra Nath Pandey added a comment - I have committed this. Thanks to Jeffrey!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #691 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/691/)
          HADOOP-7314. Add support for throwing UnknownHostException when a host doesn't resolve. Contributed by Jeffrey Naisbitt.

          jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147317
          Files :

          • /hadoop/common/trunk/common/src/java/org/apache/hadoop/net/CachedDNSToSwitchMapping.java
          • /hadoop/common/trunk/common/src/java/org/apache/hadoop/net/DNSToSwitchMapping.java
          • /hadoop/common/trunk/common/src/java/org/apache/hadoop/net/ScriptBasedMapping.java
          • /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/net/TestScriptBasedMapping.java
          • /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/net/StaticMapping.java
          • /hadoop/common/trunk/common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #691 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/691/ ) HADOOP-7314 . Add support for throwing UnknownHostException when a host doesn't resolve. Contributed by Jeffrey Naisbitt. jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147317 Files : /hadoop/common/trunk/common/src/java/org/apache/hadoop/net/CachedDNSToSwitchMapping.java /hadoop/common/trunk/common/src/java/org/apache/hadoop/net/DNSToSwitchMapping.java /hadoop/common/trunk/common/src/java/org/apache/hadoop/net/ScriptBasedMapping.java /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/net/TestScriptBasedMapping.java /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/net/StaticMapping.java /hadoop/common/trunk/common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #748 (See https://builds.apache.org/job/Hadoop-Common-trunk/748/)
          HADOOP-7314. Add support for throwing UnknownHostException when a host doesn't resolve. Contributed by Jeffrey Naisbitt.

          jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147317
          Files :

          • /hadoop/common/trunk/common/src/java/org/apache/hadoop/net/CachedDNSToSwitchMapping.java
          • /hadoop/common/trunk/common/src/java/org/apache/hadoop/net/DNSToSwitchMapping.java
          • /hadoop/common/trunk/common/src/java/org/apache/hadoop/net/ScriptBasedMapping.java
          • /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/net/TestScriptBasedMapping.java
          • /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/net/StaticMapping.java
          • /hadoop/common/trunk/common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #748 (See https://builds.apache.org/job/Hadoop-Common-trunk/748/ ) HADOOP-7314 . Add support for throwing UnknownHostException when a host doesn't resolve. Contributed by Jeffrey Naisbitt. jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147317 Files : /hadoop/common/trunk/common/src/java/org/apache/hadoop/net/CachedDNSToSwitchMapping.java /hadoop/common/trunk/common/src/java/org/apache/hadoop/net/DNSToSwitchMapping.java /hadoop/common/trunk/common/src/java/org/apache/hadoop/net/ScriptBasedMapping.java /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/net/TestScriptBasedMapping.java /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/net/StaticMapping.java /hadoop/common/trunk/common/CHANGES.txt
          Matt Foley made changes -
          Resolution Fixed [ 1 ]
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.23.0 [ 12315569 ]
          Hide
          Jeffrey Naisbitt added a comment -

          Reopening since this still needs to be committed to the 0.20.205 release.

          Show
          Jeffrey Naisbitt added a comment - Reopening since this still needs to be committed to the 0.20.205 release.
          Jeffrey Naisbitt made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Hide
          Matt Foley added a comment -

          Jeff, your above comment https://issues.apache.org/jira/browse/HADOOP-7314?focusedCommentId=13064781&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13064781 said:

          This portion of the patch is actually for trunk only. The 0.20s patch for MAPREDUCE-2489 contains all the necessary changes for 0.20.205

          I assumed that meant this patch for HADOOP-7314 did not need to be back-ported. Is MAPREDUCE-2489 not actually inclusive?

          Show
          Matt Foley added a comment - Jeff, your above comment https://issues.apache.org/jira/browse/HADOOP-7314?focusedCommentId=13064781&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13064781 said: This portion of the patch is actually for trunk only. The 0.20s patch for MAPREDUCE-2489 contains all the necessary changes for 0.20.205 I assumed that meant this patch for HADOOP-7314 did not need to be back-ported. Is MAPREDUCE-2489 not actually inclusive?
          Hide
          Jeffrey Naisbitt added a comment -

          After that comment, I was asked to separate the patch from MAPREDUCE-2489 so that the code reviewed here was all in one place. So, the HADOOP-7314-0.20s.patch file is in fact for the 0.20s branch.

          Sorry about the confusion. I tried to clear it up with these comments above (https://issues.apache.org/jira/browse/HADOOP-7314?focusedCommentId=13065421&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13065421 and https://issues.apache.org/jira/browse/HADOOP-7314?focusedCommentId=13065422&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13065422), but I'm guessing it got lost in the jumble of messages and updates.

          Thanks for looking at this!

          Show
          Jeffrey Naisbitt added a comment - After that comment, I was asked to separate the patch from MAPREDUCE-2489 so that the code reviewed here was all in one place. So, the HADOOP-7314 -0.20s.patch file is in fact for the 0.20s branch. Sorry about the confusion. I tried to clear it up with these comments above ( https://issues.apache.org/jira/browse/HADOOP-7314?focusedCommentId=13065421&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13065421 and https://issues.apache.org/jira/browse/HADOOP-7314?focusedCommentId=13065422&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13065422 ), but I'm guessing it got lost in the jumble of messages and updates. Thanks for looking at this!
          Hide
          Matt Foley added a comment -

          Got it. My apologies, you're right that I missed the later changes. And I see you uploaded Attachment HADOOP-7314-0.20s.patch [12486477] at the same time as the trunk patch.

          @Jeff, please attach the output of a local test-patch run for it under .20.205 branch.

          @Jitendra, can you please review the deltas? Thanks.

          Show
          Matt Foley added a comment - Got it. My apologies, you're right that I missed the later changes. And I see you uploaded Attachment HADOOP-7314 -0.20s.patch [12486477] at the same time as the trunk patch. @Jeff, please attach the output of a local test-patch run for it under .20.205 branch. @Jitendra, can you please review the deltas? Thanks.
          Hide
          Jeffrey Naisbitt added a comment -

          test-patch results for the 0.20s patch:
          [exec] +1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] +1 tests included. The patch appears to include 6 new or modified tests.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
          [exec]

          Show
          Jeffrey Naisbitt added a comment - test-patch results for the 0.20s patch: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec]
          Matt Foley made changes -
          Fix Version/s 0.20.205.0 [ 12316390 ]
          Hide
          Jitendra Nath Pandey added a comment -

          +1 for the 20 version of the patch (HADOOP-7314-0.20s.patch).

          Show
          Jitendra Nath Pandey added a comment - +1 for the 20 version of the patch ( HADOOP-7314 -0.20s.patch).
          Hide
          Matt Foley added a comment -

          Committed to branch-0.20-security. Thanks, Jeff! And thanks Jitendra for the code review.

          Show
          Matt Foley added a comment - Committed to branch-0.20-security. Thanks, Jeff! And thanks Jitendra for the code review.
          Matt Foley made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Matt Foley added a comment -

          Closed upon release of 0.20.205.0

          Show
          Matt Foley added a comment - Closed upon release of 0.20.205.0
          Matt Foley made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Link This issue blocks MAPREDUCE-2489 [ MAPREDUCE-2489 ]
          Gavin made changes -
          Link This issue is depended upon by MAPREDUCE-2489 [ MAPREDUCE-2489 ]

            People

            • Assignee:
              Jeffrey Naisbitt
              Reporter:
              Jeffrey Naisbitt
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development