Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Added missing library during creation of the eclipse project files.

      Description

      After a fresh checkout of hadoop-common I do 'ant compile eclipse'.
      I open eclipse, set ANT_HOME and build the project.
      At that point the following error appears:

      The type com.sun.javadoc.RootDoc cannot be resolved. It is indirectly referenced from required .class files ExcludePrivateAnnotationsJDiffDoclet.java /common/src/java/org/apache/hadoop/classification/tools line 1 Java Problem

      The solution is to add the "tools.jar" from the JDK to the buildpath/classpath.
      This should be fixed in the build.xml.

      1. HADOOP-7305-2011-05-19.patch
        0.4 kB
        Niels Basjes
      2. HADOOP-7305-2011-05-30.patch
        2 kB
        Niels Basjes
      3. HADOOP-7305-2011-06-09.patch
        2 kB
        Niels Basjes
      4. HADOOP-7305-2011-07-01.patch
        2 kB
        Niels Basjes

        Activity

        Hide
        Niels Basjes added a comment -

        Add tools.jar to the classpath for the eclipse target in ant.

        Show
        Niels Basjes added a comment - Add tools.jar to the classpath for the eclipse target in ant.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12479760/HADOOP-7305-2011-05-19.patch
        against trunk revision 1124456.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/476//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/476//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/476//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479760/HADOOP-7305-2011-05-19.patch against trunk revision 1124456. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/476//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/476//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/476//console This message is automatically generated.
        Hide
        Niels Basjes added a comment -

        Regarding the "
        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.
        "

        To test this: Do what I described in the issue and the mentioned error should not occur.

        Show
        Niels Basjes added a comment - Regarding the " -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. " To test this: Do what I described in the issue and the mentioned error should not occur.
        Hide
        Todd Lipcon added a comment -

        +1

        Show
        Todd Lipcon added a comment - +1
        Hide
        Todd Lipcon added a comment -

        Verified that "ant eclipse" generated a .classpath file with the correct tools.jar. Committed to 0.22 and trunk. Thanks, Niels!

        Show
        Todd Lipcon added a comment - Verified that "ant eclipse" generated a .classpath file with the correct tools.jar. Committed to 0.22 and trunk. Thanks, Niels!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #610 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/610/)
        HADOOP-7305. Eclipse project classpath should include tools.jar from JDK. Contributed by Niels Basjes.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1125051
        Files :

        • /hadoop/common/trunk/CHANGES.txt
        • /hadoop/common/trunk/build.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #610 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/610/ ) HADOOP-7305 . Eclipse project classpath should include tools.jar from JDK. Contributed by Niels Basjes. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1125051 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/build.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-22-branch #53 (See https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/53/)
        HADOOP-7305. Eclipse project classpath should include tools.jar from JDK. Contributed by Niels Basjes.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1125050
        Files :

        • /hadoop/common/branches/branch-0.22/CHANGES.txt
        • /hadoop/common/branches/branch-0.22/build.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-22-branch #53 (See https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/53/ ) HADOOP-7305 . Eclipse project classpath should include tools.jar from JDK. Contributed by Niels Basjes. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1125050 Files : /hadoop/common/branches/branch-0.22/CHANGES.txt /hadoop/common/branches/branch-0.22/build.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #694 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/694/)
        HADOOP-7305. Eclipse project classpath should include tools.jar from JDK. Contributed by Niels Basjes.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1125051
        Files :

        • /hadoop/common/trunk/CHANGES.txt
        • /hadoop/common/trunk/build.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #694 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/694/ ) HADOOP-7305 . Eclipse project classpath should include tools.jar from JDK. Contributed by Niels Basjes. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1125051 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/build.xml
        Hide
        Daryn Sharp added a comment -

        Explicitly including tools.jar breaks OS X because it uses a classes.jar instead of tools.jar.

        My understanding is that a JDK will implicitly load tools.jar/classes.jar, whereas a JRE will not. The patch is adding $JAVA_HOME/../lib/tools.jar to the classpath. The use of ".." leads me to believe the submitter set JAVA_HOME to a JRE, and is using this patch to "break out" and load a JDK library.

        If my understanding is correct, would someone please revert this patch? Otherwise, could the classpath modification use a conditional so as to not break OS X?

        Show
        Daryn Sharp added a comment - Explicitly including tools.jar breaks OS X because it uses a classes.jar instead of tools.jar. My understanding is that a JDK will implicitly load tools.jar/classes.jar, whereas a JRE will not. The patch is adding $JAVA_HOME/../lib/tools.jar to the classpath. The use of ".." leads me to believe the submitter set JAVA_HOME to a JRE, and is using this patch to "break out" and load a JDK library. If my understanding is correct, would someone please revert this patch? Otherwise, could the classpath modification use a conditional so as to not break OS X?
        Hide
        Eli Collins added a comment -

        Hey Niels - can you chime in wrt Daryn's request?

        Show
        Eli Collins added a comment - Hey Niels - can you chime in wrt Daryn's request?
        Hide
        Niels Basjes added a comment -

        This is an updated patch to fix the problems that were reported on OS X.
        I've tried to make this as "fail safe" as possible.
        However do not have access to OS X to try it out.

        This should be tested by others before comitting.

        Show
        Niels Basjes added a comment - This is an updated patch to fix the problems that were reported on OS X. I've tried to make this as "fail safe" as possible. However do not have access to OS X to try it out. This should be tested by others before comitting.
        Hide
        Niels Basjes added a comment -

        Apparently there are some issues with the first version in combination with OS X.

        Show
        Niels Basjes added a comment - Apparently there are some issues with the first version in combination with OS X.
        Hide
        Niels Basjes added a comment -

        This new patch should fix the reported issues. This needs to be teste by someone with OS X because I do not have access to such a system.

        Show
        Niels Basjes added a comment - This new patch should fix the reported issues. This needs to be teste by someone with OS X because I do not have access to such a system.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12481469/HADOOP-7305-2011-05-30.patch
        against trunk revision 1131330.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/577//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/577//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/577//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481469/HADOOP-7305-2011-05-30.patch against trunk revision 1131330. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/577//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/577//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/577//console This message is automatically generated.
        Hide
        Daryn Sharp added a comment -

        The patch doesn't work on OS X because the path is $

        {env.JAVA_HOME}

        /bundle/Classes/classes.jar (sorry if I mispoke earlier). Again though, classes.jar is already in the jdk's search path so it isn't strictly necessary.

        Another friend and I tested a fresh eclipse install on RHEL5 w/o tools.jar in the .classpath file. All we did is import the project and define ANT_HOME. It worked fine, so it calls into question the need for this patch. Are you sure you don't have a misconfiged environment? Are other people experiencing the problem?

        Show
        Daryn Sharp added a comment - The patch doesn't work on OS X because the path is $ {env.JAVA_HOME} /bundle/Classes/classes.jar (sorry if I mispoke earlier). Again though, classes.jar is already in the jdk's search path so it isn't strictly necessary. Another friend and I tested a fresh eclipse install on RHEL5 w/o tools.jar in the .classpath file. All we did is import the project and define ANT_HOME. It worked fine, so it calls into question the need for this patch. Are you sure you don't have a misconfiged environment? Are other people experiencing the problem?
        Hide
        Niels Basjes added a comment -

        I double checked and when I just import the project and do a refresh (F5) on the project then I get the error.
        I checked this on both

        1. my regular CentOS 5.6 with the SUN JDK 1.6.0_22 and manually downloaded Eclipse
        2. on a pristine Fedora 15 with the packaged OpenJDK and packaged Eclipse.

        Also note that I first checked in the mailing list to verify if anyone else has the same problem and Todd Lipcon immediately stepped forward. So yes, others experience the same issue.

        I've updated the patch to reflect the different path you mentioned.
        I hope it's right this time.

        Show
        Niels Basjes added a comment - I double checked and when I just import the project and do a refresh (F5) on the project then I get the error. I checked this on both my regular CentOS 5.6 with the SUN JDK 1.6.0_22 and manually downloaded Eclipse on a pristine Fedora 15 with the packaged OpenJDK and packaged Eclipse. Also note that I first checked in the mailing list to verify if anyone else has the same problem and Todd Lipcon immediately stepped forward. So yes, others experience the same issue. I've updated the patch to reflect the different path you mentioned. I hope it's right this time.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12481968/HADOOP-7305-2011-06-09.patch
        against trunk revision 1133125.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/602//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/602//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/602//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481968/HADOOP-7305-2011-06-09.patch against trunk revision 1133125. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/602//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/602//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/602//console This message is automatically generated.
        Hide
        Daryn Sharp added a comment -

        I apologize for the delay – I was unexpectedly unavailable over a week. I did test that if JAVA_HOME is set to the JDK dir for Linux that this patch isn't strictly necessary, but it certainly doesn't hurt as a convenience if JAVA_HOME is set to the JRE.

        +1 if the OS X section is changed to just the following:

        +    <!-- The tools.jar from the JDK is called classes.jar on OS X. -->
        +    <condition property="jdk.tools.jar" value="${java.home}/bundle/Classes/classes.jar">
        +      <available file="${java.home}/bundle/Classes/classes.jar"/>
        +    </condition>
        

        Via the web, I found this to be the preferred path and I have confirmed that it works.

        Show
        Daryn Sharp added a comment - I apologize for the delay – I was unexpectedly unavailable over a week. I did test that if JAVA_HOME is set to the JDK dir for Linux that this patch isn't strictly necessary, but it certainly doesn't hurt as a convenience if JAVA_HOME is set to the JRE. +1 if the OS X section is changed to just the following: + <!-- The tools.jar from the JDK is called classes.jar on OS X. --> + <condition property= "jdk.tools.jar" value= "${java.home}/bundle/Classes/classes.jar" > + <available file= "${java.home}/bundle/Classes/classes.jar" /> + </condition> Via the web, I found this to be the preferred path and I have confirmed that it works.
        Hide
        Niels Basjes added a comment -

        Adjusted the patch to match the input provided by Daryn Sharp

        Show
        Niels Basjes added a comment - Adjusted the patch to match the input provided by Daryn Sharp
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12484915/HADOOP-7305-2011-07-01.patch
        against trunk revision 1141638.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/690//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/690//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/690//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12484915/HADOOP-7305-2011-07-01.patch against trunk revision 1141638. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/690//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/690//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/690//console This message is automatically generated.
        Hide
        Daryn Sharp added a comment -

        +1 looks great, thanks!

        Show
        Daryn Sharp added a comment - +1 looks great, thanks!
        Hide
        Eli Collins added a comment -

        Why is env.JAVA_HOME used in some places and java.home in others?

        Show
        Eli Collins added a comment - Why is env.JAVA_HOME used in some places and java.home in others?
        Hide
        Niels Basjes added a comment -

        @Eli: env.JAVA_HOME is the actual environment variable JAVA_HOME. java.home is the java home according to ant... which can be different. So the implementation I chose is to first verify if the JDK_HOME is set (an uncommon yet possible explicit override) and use that if the required file can be found there. Then check the JAVA_HOME environment and last check the "built in" java.home. For the "non-standard" JDK (i.e. OS X) I initially did the same construct and changed that in the latest patch to conform to the feedback from Daryn.

        Show
        Niels Basjes added a comment - @Eli: env.JAVA_HOME is the actual environment variable JAVA_HOME. java.home is the java home according to ant... which can be different. So the implementation I chose is to first verify if the JDK_HOME is set (an uncommon yet possible explicit override) and use that if the required file can be found there. Then check the JAVA_HOME environment and last check the "built in" java.home. For the "non-standard" JDK (i.e. OS X) I initially did the same construct and changed that in the latest patch to conform to the feedback from Daryn.
        Hide
        Eli Collins added a comment -

        Why is env.JAVA_HOME assumed to be a jdk (uses lib/tools.jar), while java.home a jre (uses ../lib/tools.jar) on linux, shouldn't java.home be assumed to be a jdk as well?

        Show
        Eli Collins added a comment - Why is env.JAVA_HOME assumed to be a jdk (uses lib/tools.jar), while java.home a jre (uses ../lib/tools.jar) on linux, shouldn't java.home be assumed to be a jdk as well?
        Hide
        Niels Basjes added a comment -

        The sad truth is that java.home is set by ant to the jre instead of the value of the environment variable JAVA_HOME.
        Simple demonstration:

         
        [niels@hacker ~/src/javahome]$ echo $JAVA_HOME 
        /usr/java/default/
        [niels@hacker ~/src/javahome]$ ls -laF /usr/java/default
        lrwxrwxrwx. 1 root root 16 Jul 11  2010 /usr/java/default -> /usr/java/latest/
        [niels@hacker ~/src/javahome]$ ls -laF /usr/java/latest
        lrwxrwxrwx. 1 root root 21 Jul 11  2010 /usr/java/latest -> /usr/java/jdk1.6.0_21/
        
        [niels@hacker ~/src/javahome]$ cat build.xml 
        <?xml version="1.0"?>
        <project>
          <target name="javahome">
            <property environment="env"/>
            <echo>${env.JAVA_HOME}</echo>
            <echo>${java.home}</echo>
          </target>
        </project>
        
        [niels@hacker ~/src/javahome]$ ant javahome
        Buildfile: /home/niels/src/javahome/build.xml
        
        javahome:
             [echo] /usr/java/default/
             [echo] /usr/java/jdk1.6.0_21/jre
        
        BUILD SUCCESSFUL
        Total time: 1 second
        
        Show
        Niels Basjes added a comment - The sad truth is that java.home is set by ant to the jre instead of the value of the environment variable JAVA_HOME. Simple demonstration: [niels@hacker ~/src/javahome]$ echo $JAVA_HOME /usr/java/ default / [niels@hacker ~/src/javahome]$ ls -laF /usr/java/ default lrwxrwxrwx. 1 root root 16 Jul 11 2010 /usr/java/ default -> /usr/java/latest/ [niels@hacker ~/src/javahome]$ ls -laF /usr/java/latest lrwxrwxrwx. 1 root root 21 Jul 11 2010 /usr/java/latest -> /usr/java/jdk1.6.0_21/ [niels@hacker ~/src/javahome]$ cat build.xml <?xml version= "1.0" ?> <project> <target name= "javahome" > <property environment= "env" /> <echo>${env.JAVA_HOME}</echo> <echo>${java.home}</echo> </target> </project> [niels@hacker ~/src/javahome]$ ant javahome Buildfile: /home/niels/src/javahome/build.xml javahome: [echo] /usr/java/ default / [echo] /usr/java/jdk1.6.0_21/jre BUILD SUCCESSFUL Total time: 1 second
        Hide
        Eli Collins added a comment -

        Weird. Thanks for the explanations.

        +1 patch looks good to me now.

        Show
        Eli Collins added a comment - Weird. Thanks for the explanations. +1 patch looks good to me now.
        Hide
        Eli Collins added a comment -

        I've committed this. Thanks Niels!

        Show
        Eli Collins added a comment - I've committed this. Thanks Niels!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #690 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/690/)
        HADOOP-7305. Eclipse project files are incomplete. Contributed by Niels Basjes

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1146912
        Files :

        • /hadoop/common/trunk/common/CHANGES.txt
        • /hadoop/common/trunk/common/build.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #690 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/690/ ) HADOOP-7305 . Eclipse project files are incomplete. Contributed by Niels Basjes eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1146912 Files : /hadoop/common/trunk/common/CHANGES.txt /hadoop/common/trunk/common/build.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #747 (See https://builds.apache.org/job/Hadoop-Common-trunk/747/)
        HADOOP-7305. Eclipse project files are incomplete. Contributed by Niels Basjes

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1146912
        Files :

        • /hadoop/common/trunk/common/CHANGES.txt
        • /hadoop/common/trunk/common/build.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #747 (See https://builds.apache.org/job/Hadoop-Common-trunk/747/ ) HADOOP-7305 . Eclipse project files are incomplete. Contributed by Niels Basjes eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1146912 Files : /hadoop/common/trunk/common/CHANGES.txt /hadoop/common/trunk/common/build.xml

          People

          • Assignee:
            Niels Basjes
            Reporter:
            Niels Basjes
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development