Hadoop Common
  1. Hadoop Common
  2. HADOOP-7302

webinterface.private.actions should not be in common

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.22.0
    • Component/s: documentation
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Option webinterface.private.actions has been renamed to mapreduce.jobtracker.webinterface.trusted and should be specified in mapred-site.xml instead of core-site.xml

      Description

      The comment in -defaults says that webinterface.private.actions applies to both NN and JT. This is wrong. This option is only referenced via the JobTracker.

      I propose to delete it here, and file a second issue in MAPREDUCE for renaming the option (deprecating the existing name.)

        Issue Links

          Activity

          Hide
          Ari Rabkin added a comment -

          Note: no change to code, hence no tests.

          Show
          Ari Rabkin added a comment - Note: no change to code, hence no tests.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12479691/HADOOP-7302.patch
          against trunk revision 1124456.

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/475//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/475//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/475//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479691/HADOOP-7302.patch against trunk revision 1124456. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/475//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/475//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/475//console This message is automatically generated.
          Hide
          Todd Lipcon added a comment -

          Committed to 22 and trunk (I elected to commit to 22 since it is low risk cleanup)

          Show
          Todd Lipcon added a comment - Committed to 22 and trunk (I elected to commit to 22 since it is low risk cleanup)
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #613 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/613/)
          HADOOP-7302. webinterface.private.actions should be renamed and moved to the MapReduce project. Contributed by Ari Rabkin.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1125221
          Files :

          • /hadoop/common/trunk/CHANGES.txt
          • /hadoop/common/trunk/src/java/core-default.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #613 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/613/ ) HADOOP-7302 . webinterface.private.actions should be renamed and moved to the MapReduce project. Contributed by Ari Rabkin. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1125221 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/java/core-default.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #694 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/694/)
          HADOOP-7302. webinterface.private.actions should be renamed and moved to the MapReduce project. Contributed by Ari Rabkin.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1125221
          Files :

          • /hadoop/common/trunk/CHANGES.txt
          • /hadoop/common/trunk/src/java/core-default.xml
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #694 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/694/ ) HADOOP-7302 . webinterface.private.actions should be renamed and moved to the MapReduce project. Contributed by Ari Rabkin. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1125221 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/java/core-default.xml
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-22-branch #55 (See https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/55/)

          Show
          Hudson added a comment - Integrated in Hadoop-Common-22-branch #55 (See https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/55/ )

            People

            • Assignee:
              Ari Rabkin
              Reporter:
              Ari Rabkin
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development