Hadoop Common
  1. Hadoop Common
  2. HADOOP-7296

The FsPermission(FsPermission) constructor does not use the sticky bit

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.21.0, 0.22.0, 0.23.0
    • Fix Version/s: 0.22.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The FsPermission(FsPermission) constructor copies u, g, o from the supplied FsPermission object but ignores the sticky bit.

      1. HADOOP7296.patch
        1 kB
        Siddharth Seth
      2. HADOOP7296_2.patch
        1 kB
        Siddharth Seth

        Activity

        Hide
        Siddharth Seth added a comment -

        Patch.

        Show
        Siddharth Seth added a comment - Patch.
        Hide
        Aaron T. Myers added a comment -

        Hi Siddarth,

        The patch looks pretty good, though it looks to me like your patch introduces a tab character in src/java/org/apache/hadoop/fs/permission/FsPermission.java. Our convention is to expand these into spaces. Would you mind uploading a new version without the tab?

        Also, what version of Hadoop is this patch for? Please fill in the affects version field as appropriate.

        Show
        Aaron T. Myers added a comment - Hi Siddarth, The patch looks pretty good, though it looks to me like your patch introduces a tab character in src/java/org/apache/hadoop/fs/permission/FsPermission.java . Our convention is to expand these into spaces. Would you mind uploading a new version without the tab? Also, what version of Hadoop is this patch for? Please fill in the affects version field as appropriate.
        Hide
        Siddharth Seth added a comment -

        Thanks for looking at it. Fixed the tab. This exists in 0.21 and subsequent versions. Will mark that.

        Show
        Siddharth Seth added a comment - Thanks for looking at it. Fixed the tab. This exists in 0.21 and subsequent versions. Will mark that.
        Hide
        Aaron T. Myers added a comment -

        +1, the patch looks good to me.

        Show
        Aaron T. Myers added a comment - +1, the patch looks good to me.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12479423/HADOOP7296_2.patch
        against trunk revision 1103971.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/463//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/463//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/463//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479423/HADOOP7296_2.patch against trunk revision 1103971. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/463//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/463//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/463//console This message is automatically generated.
        Hide
        Tom White added a comment -

        I've just committed this. Thanks, Siddharth!

        Show
        Tom White added a comment - I've just committed this. Thanks, Siddharth!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #605 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/605/)
        HADOOP-7296. The FsPermission(FsPermission) constructor does not use the sticky bit. Contributed by Siddharth Seth

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #605 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/605/ ) HADOOP-7296 . The FsPermission(FsPermission) constructor does not use the sticky bit. Contributed by Siddharth Seth
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-22-branch #50 (See https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/50/)
        Merge -r 1104373:1104374 from trunk to branch-0.22. Fixes: HADOOP-7296

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1104377
        Files :

        • /hadoop/common/branches/branch-0.22/src/test/core/org/apache/hadoop/fs/permission/TestFsPermission.java
        • /hadoop/common/branches/branch-0.22/CHANGES.txt
        • /hadoop/common/branches/branch-0.22/src/java/org/apache/hadoop/fs/permission/FsPermission.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-22-branch #50 (See https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/50/ ) Merge -r 1104373:1104374 from trunk to branch-0.22. Fixes: HADOOP-7296 tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1104377 Files : /hadoop/common/branches/branch-0.22/src/test/core/org/apache/hadoop/fs/permission/TestFsPermission.java /hadoop/common/branches/branch-0.22/CHANGES.txt /hadoop/common/branches/branch-0.22/src/java/org/apache/hadoop/fs/permission/FsPermission.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #692 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/692/)
        HADOOP-7296. The FsPermission(FsPermission) constructor does not use the sticky bit. Contributed by Siddharth Seth

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1104374
        Files :

        • /hadoop/common/trunk/CHANGES.txt
        • /hadoop/common/trunk/src/java/org/apache/hadoop/fs/permission/FsPermission.java
        • /hadoop/common/trunk/src/test/core/org/apache/hadoop/fs/permission/TestFsPermission.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #692 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/692/ ) HADOOP-7296 . The FsPermission(FsPermission) constructor does not use the sticky bit. Contributed by Siddharth Seth tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1104374 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/java/org/apache/hadoop/fs/permission/FsPermission.java /hadoop/common/trunk/src/test/core/org/apache/hadoop/fs/permission/TestFsPermission.java

          People

          • Assignee:
            Siddharth Seth
            Reporter:
            Siddharth Seth
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development