Hadoop Common
  1. Hadoop Common
  2. HADOOP-7282

getRemoteIp could return null in cases where the call is ongoing but the ip went away.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      getRemoteIp gets the ip from socket instead of the stored ip in Connection object. Thus calls to this function could return null when a client disconnected, but the rpc call is still ongoing...

      1. HADOOP-7282-1.patch
        0.9 kB
        John George
      2. HADOOP-7282.patch
        0.7 kB
        John George
      3. diffs.txt
        7 kB
        John George

        Issue Links

          Activity

          Hide
          John George added a comment -

          Please ignore the "diffs.txt" file - that was accidentally uploaded. Sorry for the confusion .

          Show
          John George added a comment - Please ignore the "diffs.txt" file - that was accidentally uploaded. Sorry for the confusion .
          Hide
          John George added a comment -

          Ran manual tests to verify that ip address gets printed out correctly even when client exits without completing an rpc.

          Also ran tests to verify that ip gets printed in normal use cases.

          No tests attached since it seemed extremely difficult to add tests for the above use-cases.

          Results of test-patch. findbugs not because of this patch.
          [exec]
          [exec] -1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
          [exec] Please justify why no new tests are needed for this patch.
          [exec] Also please list what manual steps were performed to verify this patch.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
          [exec]
          [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          [exec]
          [exec] +1 system test framework. The patch passed system test framework compile.
          [exec]
          [exec]

          ~

          Show
          John George added a comment - Ran manual tests to verify that ip address gets printed out correctly even when client exits without completing an rpc. Also ran tests to verify that ip gets printed in normal use cases. No tests attached since it seemed extremely difficult to add tests for the above use-cases. Results of test-patch. findbugs not because of this patch. [exec] [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile. [exec] [exec] ~
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12479182/HADOOP-7282-1.patch
          against trunk revision 1103971.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/461//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/461//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/461//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479182/HADOOP-7282-1.patch against trunk revision 1103971. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/461//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/461//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/461//console This message is automatically generated.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good.

          Show
          Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this. Thanks, John!

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, John!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #606 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/606/)
          HADOOP-7282. ipc.Server.getRemoteIp() may return null. Contributed by John George

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #606 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/606/ ) HADOOP-7282 . ipc.Server.getRemoteIp() may return null. Contributed by John George
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #692 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/692/)
          HADOOP-7282. ipc.Server.getRemoteIp() may return null. Contributed by John George

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1104426
          Files :

          • /hadoop/common/trunk/CHANGES.txt
          • /hadoop/common/trunk/src/java/org/apache/hadoop/ipc/Server.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #692 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/692/ ) HADOOP-7282 . ipc.Server.getRemoteIp() may return null. Contributed by John George szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1104426 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/java/org/apache/hadoop/ipc/Server.java

            People

            • Assignee:
              John George
              Reporter:
              John George
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development