Hadoop Common
  1. Hadoop Common
  2. HADOOP-7268

FileContext.getLocalFSFileContext() behavior needs to be fixed w.r.t tokens

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: fs, security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      FileContext.getLocalFSFileContext() instantiates a FileContext object upon the first call to it, and for all subsequent calls returns back that instance (a static localFsSingleton object). With security turned on, this causes some hard-to-debug situations when that fileContext is used for doing HDFS operations. This is because the UserGroupInformation is stored when a FileContext is instantiated. If the process in question wishes to use different UserGroupInformation objects for different file system operations (where the corresponding FileContext objects are obtained via calls to FileContext.getLocalFSFileContext()), it doesn't work.

      1. HADOOP-7268.1.patch
        2 kB
        Jitendra Nath Pandey

        Activity

        Devaraj Das created issue -
        Jitendra Nath Pandey made changes -
        Field Original Value New Value
        Assignee Jitendra Nath Pandey [ jnp ]
        Hide
        Jitendra Nath Pandey added a comment -

        This patch removes the singleton for localfs file context. A new file context object will be created when getLocalFSFileContext() is called.

        Show
        Jitendra Nath Pandey added a comment - This patch removes the singleton for localfs file context. A new file context object will be created when getLocalFSFileContext() is called.
        Jitendra Nath Pandey made changes -
        Attachment HADOOP-7268.1.patch [ 12478634 ]
        Jitendra Nath Pandey made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12478634/HADOOP-7268.1.patch
        against trunk revision 1101199.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/420//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/420//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/420//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478634/HADOOP-7268.1.patch against trunk revision 1101199. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/420//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/420//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/420//console This message is automatically generated.
        Hide
        Sanjay Radia added a comment -

        +1

        Show
        Sanjay Radia added a comment - +1
        Hide
        Jitendra Nath Pandey added a comment -

        I have committed this.

        Show
        Jitendra Nath Pandey added a comment - I have committed this.
        Jitendra Nath Pandey made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #583 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/583/)
        HADOOP-7268. FileContext.getLocalFSFileContext() behavior needs to be fixed w.r.t tokens. Contributed by jitendra.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #583 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/583/ ) HADOOP-7268 . FileContext.getLocalFSFileContext() behavior needs to be fixed w.r.t tokens. Contributed by jitendra.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #685 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/685/)
        HADOOP-7268. FileContext.getLocalFSFileContext() behavior needs to be fixed w.r.t tokens. Contributed by jitendra.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #685 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/685/ ) HADOOP-7268 . FileContext.getLocalFSFileContext() behavior needs to be fixed w.r.t tokens. Contributed by jitendra.
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        15h 50m 1 Jitendra Nath Pandey 09/May/11 21:53
        Patch Available Patch Available Resolved Resolved
        21h 9m 1 Jitendra Nath Pandey 10/May/11 19:02
        Resolved Resolved Closed Closed
        188d 6h 48m 1 Arun C Murthy 15/Nov/11 00:50

          People

          • Assignee:
            Jitendra Nath Pandey
            Reporter:
            Devaraj Das
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development