Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: util
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The synopsis for the count command is wrong.
      1) missing a space in "-count[-q]"
      2) missing ellipsis for multiple path args

        Activity

        Daryn Sharp created issue -
        Daryn Sharp made changes -
        Field Original Value New Value
        Attachment HADOOP-7231.patch [ 12476658 ]
        Daryn Sharp made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Eli Collins added a comment -

        +1

        This might technically be an incompatible change since the output of the shell is considered a public API, but I don't think that's relevant here given it only applies to the help output and that changes as we add flags.

        Show
        Eli Collins added a comment - +1 This might technically be an incompatible change since the output of the shell is considered a public API, but I don't think that's relevant here given it only applies to the help output and that changes as we add flags.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12476658/HADOOP-7231.patch
        against trunk revision 1094750.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/351//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/351//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/351//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12476658/HADOOP-7231.patch against trunk revision 1094750. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/351//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/351//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/351//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        I've committed this. Thanks Daryn!

        Show
        Eli Collins added a comment - I've committed this. Thanks Daryn!
        Eli Collins made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 0.23.0 [ 12315569 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #559 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/559/)
        HADOOP-7231. Fix synopsis for -count. Contributed by Daryn Sharp.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #559 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/559/ ) HADOOP-7231 . Fix synopsis for -count. Contributed by Daryn Sharp.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #666 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/666/)
        HADOOP-7231. Fix synopsis for -count. Contributed by Daryn Sharp.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #666 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/666/ ) HADOOP-7231 . Fix synopsis for -count. Contributed by Daryn Sharp.
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Daryn Sharp
            Reporter:
            Daryn Sharp
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development