Hadoop Common
  1. Hadoop Common
  2. HADOOP-7187

Socket Leak in org.apache.hadoop.metrics.ganglia.GangliaContext

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0, 0.23.0
    • Component/s: metrics
    • Labels:
      None
    • Environment:

      Linux

    • Hadoop Flags:
      Reviewed

      Description

      Init method is creating DatagramSocket. But this is not closed any where.

      1. HADOOP-7187.1.patch
        3 kB
        Uma Maheswara Rao G
      2. HADOOP-7187.patch
        3 kB
        Uma Maheswara Rao G

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        Good catch.

        • Could you add @Override to close()?
        • Please use junit 4 (i.e. org.junit.Test and other classes org.junit.* instead of junit.framework.TestCase)
        Show
        Tsz Wo Nicholas Sze added a comment - Good catch. Could you add @Override to close() ? Please use junit 4 (i.e. org.junit.Test and other classes org.junit.* instead of junit.framework.TestCase )
        Hide
        Uma Maheswara Rao G added a comment -

        Hi Nicholas,
        Thanks for your comments,
        I fixed them and submitted the patch.

        Show
        Uma Maheswara Rao G added a comment - Hi Nicholas, Thanks for your comments, I fixed them and submitted the patch.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12474507/HADOOP-7187.1.patch
        against trunk revision 1085043.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/319//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/319//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/319//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12474507/HADOOP-7187.1.patch against trunk revision 1085043. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/319//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/319//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/319//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks, Uma!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Uma!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #535 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/535/)
        HADOOP-7187. Fix socket leak in GangliaContext. Contributed by Uma Maheswara Rao G

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #535 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/535/ ) HADOOP-7187 . Fix socket leak in GangliaContext. Contributed by Uma Maheswara Rao G
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Reverted it from 0.21 since TestGangliaContext cannot be compiled.

        Show
        Tsz Wo Nicholas Sze added a comment - Reverted it from 0.21 since TestGangliaContext cannot be compiled.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-22-branch #36 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/36/)
        HADOOP-7187. Fix socket leak in GangliaContext. Contributed by Uma Maheswara Rao G

        Show
        Hudson added a comment - Integrated in Hadoop-Common-22-branch #36 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/36/ ) HADOOP-7187 . Fix socket leak in GangliaContext. Contributed by Uma Maheswara Rao G
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #641 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/641/)
        HADOOP-7187. Fix socket leak in GangliaContext. Contributed by Uma Maheswara Rao G

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #641 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/641/ ) HADOOP-7187 . Fix socket leak in GangliaContext. Contributed by Uma Maheswara Rao G

          People

          • Assignee:
            Uma Maheswara Rao G
            Reporter:
            Uma Maheswara Rao G
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development