Hadoop Common
  1. Hadoop Common
  2. HADOOP-7177

CodecPool should report which compressor it is using

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.20.2, 0.21.0, 0.23.0
    • Fix Version/s: 0.21.1, 0.22.0, 0.23.0
    • Component/s: native
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Certain native compression libraries are overly verbose causing confusion while reading the task logs. Let's actually say which compressor we got when we report it in the task logs.

      1. hadoop-7177.txt
        1 kB
        Allen Wittenauer
      2. HADOOP-7177-branch-0.20-security-204.patch
        1 kB
        Allen Wittenauer

        Activity

        Allen Wittenauer created issue -
        Allen Wittenauer made changes -
        Field Original Value New Value
        Attachment hadoop-7177.txt [ 12473224 ]
        Allen Wittenauer made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Assignee Allen Wittenauer [ aw ]
        Allen Wittenauer made changes -
        Fix Version/s 0.21.1 [ 12315270 ]
        Fix Version/s 0.22.0 [ 12314296 ]
        Fix Version/s 0.23.0 [ 12315569 ]
        Affects Version/s 0.21.0 [ 12313563 ]
        Affects Version/s 0.20.2 [ 12314203 ]
        Affects Version/s 0.23.0 [ 12315569 ]
        Allen Wittenauer made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Allen Wittenauer made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Eli Collins added a comment -

        +1

        Confirmed TestCodec still passes, given this just changes a log I don't think we need additional tests.

             [exec] 
             [exec] -1 overall.  
             [exec] 
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec] 
             [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
             [exec]                         Please justify why no new tests are needed for this patch.
             [exec]                         Also please list what manual steps were performed to verify this patch.
             [exec] 
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec] 
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec] 
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.
             [exec] 
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
             [exec] 
             [exec]     +1 system test framework.  The patch passed system test framework compile.
             [exec] 
        
        Show
        Eli Collins added a comment - +1 Confirmed TestCodec still passes, given this just changes a log I don't think we need additional tests. [exec] [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile. [exec]
        Hide
        Eli Collins added a comment -

        I've committed this to trunk and merged to 22 and 21. Thanks Allen!

        Show
        Eli Collins added a comment - I've committed this to trunk and merged to 22 and 21. Thanks Allen!
        Eli Collins made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Eli Collins made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #526 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/526/)
        HADOOP-7177. CodecPool should report which compressor it is using. Contributed by Allen Wittenauer

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #526 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/526/ ) HADOOP-7177 . CodecPool should report which compressor it is using. Contributed by Allen Wittenauer
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-22-branch #33 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/33/)
        HADOOP-7177. svn merge -c 1080797 from trunk

        Show
        Hudson added a comment - Integrated in Hadoop-Common-22-branch #33 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/33/ ) HADOOP-7177 . svn merge -c 1080797 from trunk
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #628 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/628/)
        HADOOP-7177. CodecPool should report which compressor it is using. Contributed by Allen Wittenauer

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #628 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/628/ ) HADOOP-7177 . CodecPool should report which compressor it is using. Contributed by Allen Wittenauer
        Allen Wittenauer made changes -

          People

          • Assignee:
            Allen Wittenauer
            Reporter:
            Allen Wittenauer
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development