Hadoop Common
  1. Hadoop Common
  2. HADOOP-7162

FsShell: call srcFs.listStatus(src) twice

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.1, 0.22.0, 0.23.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      in file ./src/java/org/apache/hadoop/fs/FsShell.java line 555
      call method twice:
      1. for init variable
      2. for getting data

      1. HDFS-7162.path
        0.5 kB
        Alexey Diomin

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12472654/HDFS-7162.path
        against trunk revision 1077811.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/302//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/302//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/302//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12472654/HDFS-7162.path against trunk revision 1077811. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/302//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/302//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/302//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks, Alexey!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Alexey!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #517 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/517/)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #517 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/517/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #621 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/621/)
        HADOOP-7162. Rmove a duplicated call FileSystem.listStatus(..) in FsShell. Contributed by Alexey Diomin

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #621 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/621/ ) HADOOP-7162 . Rmove a duplicated call FileSystem.listStatus(..) in FsShell. Contributed by Alexey Diomin
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-22-branch #32 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/32/)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-22-branch #32 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/32/ )

          People

          • Assignee:
            Alexey Diomin
            Reporter:
            Alexey Diomin
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development