Hadoop Common
  1. Hadoop Common
  2. HADOOP-7134

configure files that are generated as part of the released tarball need to have executable bit set

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      I have just committed this to trunk and branch-0.22. Thanks Roman!

      Description

      Currently the configure files that are packaged in a tarball are rw-rw-r-

      1. HADOOP-7134.patch
        1.0 kB
        Roman Shaposhnik

        Activity

        Hide
        Roman Shaposhnik added a comment -

        Patch attached

        Show
        Roman Shaposhnik added a comment - Patch attached
        Hide
        Konstantin Boudnik added a comment -

        +1 patch looks good.

        Show
        Konstantin Boudnik added a comment - +1 patch looks good.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12470742/HADOOP-7134.patch
        against trunk revision 1068729.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/225//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/225//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/225//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12470742/HADOOP-7134.patch against trunk revision 1068729. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/225//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/225//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/225//console This message is automatically generated.
        Hide
        Roman Shaposhnik added a comment -

        -1 tests included. The patch doesn't appear to include any new or modified tests.

        This is a build change – hence no new tests

        Show
        Roman Shaposhnik added a comment - -1 tests included. The patch doesn't appear to include any new or modified tests. This is a build change – hence no new tests
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #501 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/501/)
        HADOOP-7134. configure files that are generated as part of the released tarball need to have executable bit set. Contributed by Roman Shaposhnik

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #501 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/501/ ) HADOOP-7134 . configure files that are generated as part of the released tarball need to have executable bit set. Contributed by Roman Shaposhnik
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #604 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/604/)
        HADOOP-7134. configure files that are generated as part of the released tarball need to have executable bit set. Contributed by Roman Shaposhnik

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #604 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/604/ ) HADOOP-7134 . configure files that are generated as part of the released tarball need to have executable bit set. Contributed by Roman Shaposhnik
        Hide
        Steve Loughran added a comment -

        Forgive me for not understanding all the corners of unix, but assuming these are text files, do they really need to be marked as executable? Why is this needed?

        Show
        Steve Loughran added a comment - Forgive me for not understanding all the corners of unix, but assuming these are text files, do they really need to be marked as executable? Why is this needed?

          People

          • Assignee:
            Roman Shaposhnik
            Reporter:
            Roman Shaposhnik
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development