Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Environment:

      Windows

    • Hadoop Flags:
      Reviewed

      Description

      TestDFSShell.testFilePermissions() fails on an assert in Windows. This originated from HDFS-1084 but the fix is in Common.

      junit.framework.ComparisonFailure: null expected:<rwxr[w----]> but was:<rwxr[-xr-x]>
      	at junit.framework.Assert.assertEquals(Assert.java:81)
      	at junit.framework.Assert.assertEquals(Assert.java:87)
      	at org.apache.hadoop.hdfs.TestDFSShell.confirmPermissionChange(TestDFSShell.java:836)
      	at org.apache.hadoop.hdfs.TestDFSShell.testChmod(TestDFSShell.java:777)
      	at org.apache.hadoop.hdfs.TestDFSShell.testFilePermissions(TestDFSShell.java:856)
      

        Issue Links

          Activity

          Hide
          Po Cheung added a comment -

          Use FileUtil.makeShellPath to construct correct path on Windows

          Show
          Po Cheung added a comment - Use FileUtil.makeShellPath to construct correct path on Windows
          Hide
          Todd Lipcon added a comment -

          I'm not sure why we did getCanonicalPath in the first place, but if there was a good reason for it, shouldn't we do FileUtil.makeShellPath(f.getCanonicalPath()) or something?

          Show
          Todd Lipcon added a comment - I'm not sure why we did getCanonicalPath in the first place, but if there was a good reason for it, shouldn't we do FileUtil.makeShellPath(f.getCanonicalPath()) or something?
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12469702/common-7126-trunk.patch
          against trunk revision 1064919.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/207//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/207//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/207//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12469702/common-7126-trunk.patch against trunk revision 1064919. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/207//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/207//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/207//console This message is automatically generated.
          Hide
          Konstantin Shvachko added a comment -

          > FileUtil.makeShellPath(f.getCanonicalPath()) or something?

          Yes makeShellPath(f, true) does exactly that.

          +1 Looks good to me.

          Show
          Konstantin Shvachko added a comment - > FileUtil.makeShellPath(f.getCanonicalPath()) or something? Yes makeShellPath(f, true) does exactly that. +1 Looks good to me.
          Hide
          Konstantin Shvachko added a comment -

          I tested it on Windows. TestDFSShell passes with this patch and fails without.

          Show
          Konstantin Shvachko added a comment - I tested it on Windows. TestDFSShell passes with this patch and fails without.
          Hide
          Konstantin Shvachko added a comment -

          I just committed this. Thank you Po.

          Show
          Konstantin Shvachko added a comment - I just committed this. Thank you Po.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-22-branch #22 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/22/)
          HADOOP-7126. Merge -r 1065900:1065901 from trunk to branch 0.22.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-22-branch #22 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/22/ ) HADOOP-7126 . Merge -r 1065900:1065901 from trunk to branch 0.22.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #492 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/492/)

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #492 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/492/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #593 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/593/)
          HADOOP-7126. Fix file permission setting for RawLocalFileSystem on Windows. Contributed by Po Cheung.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #593 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/593/ ) HADOOP-7126 . Fix file permission setting for RawLocalFileSystem on Windows. Contributed by Po Cheung.

            People

            • Assignee:
              Po Cheung
              Reporter:
              Po Cheung
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development