Hadoop Common
  1. Hadoop Common
  2. HADOOP-7117

Move secondary namenode checkpoint configs from core-default.xml to hdfs-default.xml

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.1, 0.22.0, 0.23.0
    • Component/s: conf
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Removed references to the older fs.checkpoint.* properties that resided in core-site.xml
    • Tags:
      secondarynamenode, checkpoint

      Description

      The following configs are in core-default.xml, but are really read by the Secondary Namenode. These should be moved to hdfs-default.xml for consistency.
      <property>
      <name>fs.checkpoint.dir</name>
      <value>$

      {hadoop.tmp.dir}

      /dfs/namesecondary</value>
      <description>Determines where on the local filesystem the DFS secondary
      name node should store the temporary images to merge.
      If this is a comma-delimited list of directories then the image is
      replicated in all of the directories for redundancy.
      </description>
      </property>

      <property>
      <name>fs.checkpoint.edits.dir</name>
      <value>$

      {fs.checkpoint.dir}

      </value>
      <description>Determines where on the local filesystem the DFS secondary
      name node should store the temporary edits to merge.
      If this is a comma-delimited list of directoires then teh edits is
      replicated in all of the directoires for redundancy.
      Default value is same as fs.checkpoint.dir
      </description>
      </property>

      <property>
      <name>fs.checkpoint.period</name>
      <value>3600</value>
      <description>The number of seconds between two periodic checkpoints.
      </description>
      </property>

      <property>
      <name>fs.checkpoint.size</name>
      <value>67108864</value>
      <description>The size of the current edit log (in bytes) that triggers
      a periodic checkpoint even if the fs.checkpoint.period hasn't expired.
      </description>
      </property>

        Issue Links

          Activity

          Patrick Angeles created issue -
          Patrick Angeles made changes -
          Field Original Value New Value
          Link This issue is related to HDFS-1596 [ HDFS-1596 ]
          Hide
          Harsh J added a comment -

          Patch that gets rid of fs.checkpoint.* properties and updates related references to it to the newer dfs.namenode.checkpoint.* keys.

          Show
          Harsh J added a comment - Patch that gets rid of fs.checkpoint.* properties and updates related references to it to the newer dfs.namenode.checkpoint.* keys.
          Harsh J made changes -
          Attachment HADOOP-7117.r1.diff [ 12469585 ]
          Harsh J made changes -
          Assignee Harsh J Chouraria [ qwertymaniac ]
          Hide
          Tanping Wang added a comment -

          +1. (The Chinese wording looks fine.)

          Show
          Tanping Wang added a comment - +1. (The Chinese wording looks fine.)
          Hide
          Harsh J added a comment -

          Marking as Patch-Available.

          Show
          Harsh J added a comment - Marking as Patch-Available.
          Harsh J made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Release Note Removed references to the older fs.checkpoint.* properties that resided in core-site.xml
          Fix Version/s 0.23.0 [ 12315569 ]
          Tags secondarynamenode, checkpoint
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12469585/HADOOP-7117.r1.diff
          against trunk revision 1081598.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/310//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/310//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/310//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12469585/HADOOP-7117.r1.diff against trunk revision 1081598. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/310//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/310//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/310//console This message is automatically generated.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this. Thanks, Harsh!

          Also thanks Tanping for reviewing it.

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Harsh! Also thanks Tanping for reviewing it.
          Tsz Wo Nicholas Sze made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Fix Version/s 0.21.1 [ 12315270 ]
          Fix Version/s 0.22.0 [ 12314296 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #529 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/529/)
          HADOOP-7117. Remove fs.checkpoint.* from core-default.xml and replace fs.checkpoint.* with dfs.namenode.checkpoint.* in documentations. Contributed by Harsh J Chouraria

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #529 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/529/ ) HADOOP-7117 . Remove fs.checkpoint.* from core-default.xml and replace fs.checkpoint.* with dfs.namenode.checkpoint.* in documentations. Contributed by Harsh J Chouraria
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-22-branch #34 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/34/)
          HADOOP-7117. Remove fs.checkpoint.* from core-default.xml and replace fs.checkpoint.* with dfs.namenode.checkpoint.* in documentations. Contributed by Harsh J Chouraria

          Show
          Hudson added a comment - Integrated in Hadoop-Common-22-branch #34 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/34/ ) HADOOP-7117 . Remove fs.checkpoint.* from core-default.xml and replace fs.checkpoint.* with dfs.namenode.checkpoint.* in documentations. Contributed by Harsh J Chouraria
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #633 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/633/)
          HADOOP-7117. Remove fs.checkpoint.* from core-default.xml and replace fs.checkpoint.* with dfs.namenode.checkpoint.* in documentations. Contributed by Harsh J Chouraria

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #633 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/633/ ) HADOOP-7117 . Remove fs.checkpoint.* from core-default.xml and replace fs.checkpoint.* with dfs.namenode.checkpoint.* in documentations. Contributed by Harsh J Chouraria
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          31d 1h 59m 1 Harsh J 25/Feb/11 19:47
          Patch Available Patch Available Resolved Resolved
          19d 2h 56m 1 Tsz Wo Nicholas Sze 16/Mar/11 22:44
          Resolved Resolved Closed Closed
          243d 2h 6m 1 Arun C Murthy 15/Nov/11 00:50

            People

            • Assignee:
              Harsh J
              Reporter:
              Patrick Angeles
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development