Hadoop Common
  1. Hadoop Common
  2. HADOOP-7098

tasktracker property not set in conf/hadoop-env.sh

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.2, 0.21.1, 0.22.0
    • Fix Version/s: 0.23.0
    • Component/s: conf
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      For all cluster components, except TaskTracker the OPTS environment variable is set like this in hadoop-env.sh:
      export HADOOP_<COMPONENT>OPTS="-Dcom.sun.management.jmxremote $HADOOP<COMPONENT>_OPTS"

      The provided patch fixes this.

      1. hadoop-7098.patch
        0.7 kB
        Bernd Fondermann
      2. HADOOP-7098.patch
        0.7 kB
        Tom White

        Activity

        Bernd Fondermann created issue -
        Bernd Fondermann made changes -
        Field Original Value New Value
        Attachment hadoop-7098.patch [ 12468028 ]
        Chris Douglas made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Assignee Bernd Fondermann [ brainlounge ]
        Hide
        Tom White added a comment -

        +1 The lack of a HADOOP_TASKTRACKER_OPTS definition looks like an oversight (these variables were introduced in HADOOP-2551). HADOOP_TASKTRACKER_OPTS is already honoured by bin/mapred, so no changes are needed there.

        Bernd, have you tested this manually? There's currently no easy way to write an automated test for this change.

        Show
        Tom White added a comment - +1 The lack of a HADOOP_TASKTRACKER_OPTS definition looks like an oversight (these variables were introduced in HADOOP-2551 ). HADOOP_TASKTRACKER_OPTS is already honoured by bin/mapred, so no changes are needed there. Bernd, have you tested this manually? There's currently no easy way to write an automated test for this change.
        Hide
        Bernd Fondermann added a comment -

        I did test this manually indeed. The patch is in active use in my env.

        There are things like http://code.google.com/p/jbash/ which might help setting up a test, but just for this small improvement it seem like overkill.

        Show
        Bernd Fondermann added a comment - I did test this manually indeed. The patch is in active use in my env. There are things like http://code.google.com/p/jbash/ which might help setting up a test, but just for this small improvement it seem like overkill.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12468028/hadoop-7098.patch
        against trunk revision 1076314.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/299//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12468028/hadoop-7098.patch against trunk revision 1076314. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/299//console This message is automatically generated.
        Hide
        Tom White added a comment -

        Good to know.

        Regenerating patch from top level so Hudson can check it.

        Show
        Tom White added a comment - Good to know. Regenerating patch from top level so Hudson can check it.
        Tom White made changes -
        Attachment HADOOP-7098.patch [ 12472646 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12472646/HADOOP-7098.patch
        against trunk revision 1076314.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/300//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/300//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/300//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12472646/HADOOP-7098.patch against trunk revision 1076314. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/300//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/300//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/300//console This message is automatically generated.
        Hide
        Tom White added a comment -

        I've just committed this. Thanks Bernd!

        Show
        Tom White added a comment - I've just committed this. Thanks Bernd!
        Tom White made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 0.23.0 [ 12315569 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #620 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/620/)
        HADOOP-7098. Tasktracker property not set in conf/hadoop-env.sh. Contributed by Bernd Fondermann.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #620 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/620/ ) HADOOP-7098 . Tasktracker property not set in conf/hadoop-env.sh. Contributed by Bernd Fondermann.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #517 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/517/)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #517 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/517/ )
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Bernd Fondermann
            Reporter:
            Bernd Fondermann
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development