Hadoop Common
  1. Hadoop Common
  2. HADOOP-7068

Ivy resolve force mode should be turned off by default

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The problem is introduced by HADOOP-6486. Which have caused a lot of mysterious artifact issues (unable to downgrade or do parallel dev, without wiping out both m2 and ivy caches etc.) wasting countless hours of dev (many people's) time to track down the issue.

        Issue Links

          Activity

          Luke Lu created issue -
          Hide
          Luke Lu added a comment -

          The patch introduced a "force-mode" property which is off by default. Can be turned on with -Dforce-mode=true.

          Show
          Luke Lu added a comment - The patch introduced a "force-mode" property which is off by default. Can be turned on with -Dforce-mode=true.
          Luke Lu made changes -
          Field Original Value New Value
          Attachment hadoop-7068-trunk-v1.patch [ 12466506 ]
          Luke Lu made changes -
          Assignee Luke Lu [ vicaya ]
          Hide
          Jakob Homan added a comment -

          force-mode may not be the best name for the option as it doesn't say anything about ivy. How about something like force-ivy-resolution. More descriptive names are better, even if they are longer.

          Show
          Jakob Homan added a comment - force-mode may not be the best name for the option as it doesn't say anything about ivy. How about something like force-ivy-resolution. More descriptive names are better, even if they are longer.
          Luke Lu made changes -
          Link This issue is related to MAPREDUCE-2222 [ MAPREDUCE-2222 ]
          Luke Lu made changes -
          Link This issue is related to HDFS-1544 [ HDFS-1544 ]
          Hide
          Luke Lu added a comment -

          How about force-resolve (ivy is an impl detail.)? it's only useful to use with resolvers=internal anyway.

          Show
          Luke Lu added a comment - How about force-resolve (ivy is an impl detail.)? it's only useful to use with resolvers=internal anyway.
          Luke Lu made changes -
          Attachment hadoop-7068-trunk-v2.patch [ 12466509 ]
          Luke Lu made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Jakob Homan added a comment -

          I'm ok with force-resolve

          Show
          Jakob Homan added a comment - I'm ok with force-resolve
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12466509/hadoop-7068-trunk-v2.patch
          against trunk revision 1050070.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/141//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/141//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/141//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12466509/hadoop-7068-trunk-v2.patch against trunk revision 1050070. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/141//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/141//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/141//console This message is automatically generated.
          Nigel Daley made changes -
          Fix Version/s 0.22.0 [ 12314296 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12466509/hadoop-7068-trunk-v2.patch
          against trunk revision 1071364.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/251//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/251//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/251//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12466509/hadoop-7068-trunk-v2.patch against trunk revision 1071364. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/251//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/251//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/251//console This message is automatically generated.
          Hide
          Tom White added a comment -

          +1. I agree that this is very confusing and makes it almost impossible to do parallel builds on Jenkins boxes. I'm going to go ahead and commit this, HDFS-1544, and MAPREDUCE-2222, unless there are objections.

          Show
          Tom White added a comment - +1. I agree that this is very confusing and makes it almost impossible to do parallel builds on Jenkins boxes. I'm going to go ahead and commit this, HDFS-1544 , and MAPREDUCE-2222 , unless there are objections.
          Hide
          Tom White added a comment -

          I've just committed this. Thanks, Luke!

          Show
          Tom White added a comment - I've just committed this. Thanks, Luke!
          Tom White made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Fix Version/s 0.22.0 [ 12314296 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #588 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/588/)
          HADOOP-7068. Ivy resolve force mode should be turned off by default. Contributed by Luke Lu.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #588 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/588/ ) HADOOP-7068 . Ivy resolve force mode should be turned off by default. Contributed by Luke Lu.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-22-branch #45 (See https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/45/)
          Merge -r 1101734:1101735 from trunk to branch-0.22. Fixes: HADOOP-7068

          Show
          Hudson added a comment - Integrated in Hadoop-Common-22-branch #45 (See https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/45/ ) Merge -r 1101734:1101735 from trunk to branch-0.22. Fixes: HADOOP-7068
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #685 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/685/)
          HADOOP-7068. Ivy resolve force mode should be turned off by default. Contributed by Luke Lu.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #685 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/685/ ) HADOOP-7068 . Ivy resolve force mode should be turned off by default. Contributed by Luke Lu.
          Konstantin Shvachko made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Luke Lu
              Reporter:
              Luke Lu
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development