Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: conf
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TestReconfiguration should be a junit v4 unit test. I'll also add some messages to the assertions.

      1. HADOOP-7049.patch
        7 kB
        Patrick Kling
      2. HADOOP-7049.2.patch
        7 kB
        Patrick Kling

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #529 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/529/)
          HADOOP-7049. TestReconfiguration should be junit v4. Contributed by Patrick Kling

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #529 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/529/ ) HADOOP-7049 . TestReconfiguration should be junit v4. Contributed by Patrick Kling
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #447 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/447/)
          HADOOP-7049. TestReconfiguration should be junit v4. Contributed by Patrick Kling

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #447 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/447/ ) HADOOP-7049 . TestReconfiguration should be junit v4. Contributed by Patrick Kling
          Hide
          Konstantin Boudnik added a comment -

          Perhaps file a separate jira if you think we should switch them all over to be explicit.

          I don't suggest to change them all over the place but I don't see why we need to add insult to injury and keep doing this for the test code while it isn't welcome for the rest of the code. Besides a similar question has been raised before

          Show
          Konstantin Boudnik added a comment - Perhaps file a separate jira if you think we should switch them all over to be explicit. I don't suggest to change them all over the place but I don't see why we need to add insult to injury and keep doing this for the test code while it isn't welcome for the rest of the code. Besides a similar question has been raised before
          Hide
          Eli Collins added a comment -

          I've committed this. Thanks Patrick!

          Show
          Eli Collins added a comment - I've committed this. Thanks Patrick!
          Hide
          Eli Collins added a comment -

          +1

          I think the wildcard in the Assert import is OK, we use it in a lot of the tests. Perhaps file a separate jira if you think we should switch them all over to be explicit.

          Show
          Eli Collins added a comment - +1 I think the wildcard in the Assert import is OK, we use it in a lot of the tests. Perhaps file a separate jira if you think we should switch them all over to be explicit.
          Hide
          Konstantin Boudnik added a comment -

          looking good. I would suggest to replace import static org.junit.Assert.*; with only needed imports. Looks like you're using only two of them assertTrue and assertFalse

          Show
          Konstantin Boudnik added a comment - looking good. I would suggest to replace import static org.junit.Assert.*; with only needed imports. Looks like you're using only two of them assertTrue and assertFalse
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12460392/HADOOP-7049.2.patch
          against trunk revision 1038493.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/120//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/120//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/120//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12460392/HADOOP-7049.2.patch against trunk revision 1038493. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/120//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/120//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/120//console This message is automatically generated.
          Hide
          Patrick Kling added a comment -

          Fixed typo.

          Show
          Patrick Kling added a comment - Fixed typo.

            People

            • Assignee:
              Patrick Kling
              Reporter:
              Patrick Kling
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development