Hadoop Common
  1. Hadoop Common
  2. HADOOP-7046

1 Findbugs warning on trunk and branch-0.22

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.22.0, 0.23.0
    • Fix Version/s: 0.22.0, 0.23.0
    • Component/s: security
    • Labels:
      None

      Description

      There is 1 findbugs warnings on trunk. See attached html file. This must be fixed or filtered out to get back to 0 warnings. The OK_FINDBUGS_WARNINGS property in src/test/test-patch.properties should also be set to 0 in the patch that fixes this issue.

      1. findbugsWarnings.html
        24 kB
        Nigel Daley
      2. hadoop-findbugs-report.html
        4 kB
        Po Cheung
      3. common-7046-trunk.patch
        0.5 kB
        Po Cheung
      4. common-7046-0.22.patch
        1 kB
        Po Cheung
      5. common-7046-trunk.patch
        0.9 kB
        Po Cheung

        Activity

        Hide
        Po Cheung added a comment -

        Attached the correct FindBugs report file for Hadoop Common

        Show
        Po Cheung added a comment - Attached the correct FindBugs report file for Hadoop Common
        Hide
        Po Cheung added a comment -

        There is 1 FindBugs warning for trunk and 2 warnings for 0.22. Attached both patches.

        Show
        Po Cheung added a comment - There is 1 FindBugs warning for trunk and 2 warnings for 0.22. Attached both patches.
        Hide
        Po Cheung added a comment -

        Updated common-7046-trunk.patch to set OK_FINDBUGS_WARNINGS property in src/test/test-patch.properties to 0

        Show
        Po Cheung added a comment - Updated common-7046-trunk.patch to set OK_FINDBUGS_WARNINGS property in src/test/test-patch.properties to 0
        Hide
        Konstantin Shvachko added a comment -

        +1 Looks good to me.

        Show
        Konstantin Shvachko added a comment - +1 Looks good to me.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12468914/common-7046-trunk.patch
        against trunk revision 1060632.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/191//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/191//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/191//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12468914/common-7046-trunk.patch against trunk revision 1060632. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/191//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/191//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/191//console This message is automatically generated.
        Hide
        Konstantin Shvachko added a comment -

        I just committed this. Thank you Po.

        Show
        Konstantin Shvachko added a comment - I just committed this. Thank you Po.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-22-branch #18 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/18/)
        HADOOP-7046. Merge -r 1063005:1063006 from trunk to branch 0.22.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-22-branch #18 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/18/ ) HADOOP-7046 . Merge -r 1063005:1063006 from trunk to branch 0.22.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #586 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/586/)
        HADOOP-7046. Fix Findbugs warning in Configuration. Contributed by Po Cheung.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #586 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/586/ ) HADOOP-7046 . Fix Findbugs warning in Configuration. Contributed by Po Cheung.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #492 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/492/)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #492 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/492/ )

          People

          • Assignee:
            Po Cheung
            Reporter:
            Nigel Daley
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development