Hadoop Common
  1. Hadoop Common
  2. HADOOP-7014

Generalize CLITest structure and interfaces to facilitate upstream adoption (e.g. for web testing)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There's at least one use case where TestCLI infrastructure is helpful for testing projects outside of core Hadoop (e.g. Owl web testing). In order to make this acceptance easier for upstream project TestCLI needs to be refactored.

      1. HADOOP-7014.patch
        22 kB
        Konstantin Boudnik
      2. HADOOP-7014.patch
        22 kB
        Konstantin Boudnik
      3. HADOOP-7014.patch
        14 kB
        Konstantin Boudnik
      4. HADOOP-7014.patch
        14 kB
        Konstantin Boudnik
      5. HADOOP-7014.patch
        14 kB
        Konstantin Boudnik
      6. HADOOP-7014.patch
        11 kB
        Konstantin Boudnik
      7. HADOOP-7014.patch
        13 kB
        Konstantin Boudnik

        Issue Links

          Activity

          Hide
          Konstantin Boudnik added a comment -

          Fix.

          Show
          Konstantin Boudnik added a comment - Fix.
          Hide
          Konstantin Boudnik added a comment -

          Let's check it.

          Show
          Konstantin Boudnik added a comment - Let's check it.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12458470/HADOOP-7014.patch
          against trunk revision 1032730.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 16 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/85//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/85//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/85//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12458470/HADOOP-7014.patch against trunk revision 1032730. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 16 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/85//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/85//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/85//console This message is automatically generated.
          Hide
          Konstantin Boudnik added a comment -

          Once committed this patch will be causing compile errors in HDFS tests. Nothing to worry as the upstream patch will be there shortly.

          Show
          Konstantin Boudnik added a comment - Once committed this patch will be causing compile errors in HDFS tests. Nothing to worry as the upstream patch will be there shortly.
          Hide
          Todd Lipcon added a comment -

          Quick couple notes:

          • adds an import org.apache.hadoop.cli.util.* - are we allowed to use wildcard imports? I thought they were discouraged, maybe it's OK in test code
          • It seems confusing that in some places it's TestCmd and some places it's CmdTest - eg CLITestCmd implements CmdTest. Why not name the interface TestCmd too?
          Show
          Todd Lipcon added a comment - Quick couple notes: adds an import org.apache.hadoop.cli.util.* - are we allowed to use wildcard imports? I thought they were discouraged, maybe it's OK in test code It seems confusing that in some places it's TestCmd and some places it's CmdTest - eg CLITestCmd implements CmdTest. Why not name the interface TestCmd too?
          Hide
          Konstantin Boudnik added a comment -

          util.* test replaces a bunch of otherwise explicit imports. I don't like too many explicit imports (after some point they start being messy) but I want to make an issue over it. Technically you are correct: patches shouldn't have unnecessary import mods.

          The reason the interface is called CmdTest is that otherwise JUnit (in our configuration) will consider it to be a test class and will try to run it. However, I agree that the name is awkward. I have change it to iCmdTest so now it seems to be more clear. Thanks for catching it up.

          Attached patch is full equivalent of the previous one modulo interface name change, I have re-ran TestCLI and it passes Ok.

          Show
          Konstantin Boudnik added a comment - util.* test replaces a bunch of otherwise explicit imports. I don't like too many explicit imports (after some point they start being messy) but I want to make an issue over it. Technically you are correct: patches shouldn't have unnecessary import mods. The reason the interface is called CmdTest is that otherwise JUnit (in our configuration) will consider it to be a test class and will try to run it. However, I agree that the name is awkward. I have change it to iCmdTest so now it seems to be more clear. Thanks for catching it up. Attached patch is full equivalent of the previous one modulo interface name change, I have re-ran TestCLI and it passes Ok.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12459419/HADOOP-6977.patch
          against trunk revision 1034184.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/93//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12459419/HADOOP-6977.patch against trunk revision 1034184. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/93//console This message is automatically generated.
          Hide
          Konstantin Boudnik added a comment -

          Oops, has attached wrong file

          Show
          Konstantin Boudnik added a comment - Oops, has attached wrong file
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12459423/HADOOP-7014.patch
          against trunk revision 1034184.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          -1 system test framework. The patch failed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/94//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/94//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/94//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12459423/HADOOP-7014.patch against trunk revision 1034184. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/94//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/94//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/94//console This message is automatically generated.
          Hide
          Konstantin Boudnik added a comment -

          Renamed files were missed from the previous patch. Fixed.

          Show
          Konstantin Boudnik added a comment - Renamed files were missed from the previous patch. Fixed.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12459426/HADOOP-7014.patch
          against trunk revision 1034184.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 16 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/97//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/97//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/97//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12459426/HADOOP-7014.patch against trunk revision 1034184. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 16 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/97//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/97//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/97//console This message is automatically generated.
          Hide
          Jakob Homan added a comment -

          I have change it to iCmdTest so now it seems to be more clear. Thanks for catching it up.

          This would be the first time we would be using such a convention and it would be in opposition to the Sun^^^Oracle conventions the project uses: http://www.oracle.com/technetwork/java/codeconventions-135099.html#367
          Instead of abbreviating Command Line Interface everywhere, perhaps, Shell would be a better descriptor?

          Show
          Jakob Homan added a comment - I have change it to iCmdTest so now it seems to be more clear. Thanks for catching it up. This would be the first time we would be using such a convention and it would be in opposition to the Sun^^^Oracle conventions the project uses: http://www.oracle.com/technetwork/java/codeconventions-135099.html#367 Instead of abbreviating Command Line Interface everywhere, perhaps, Shell would be a better descriptor?
          Hide
          Konstantin Boudnik added a comment -

          Perhaps I have misunderstood your suggestion, but there's already Shell class in common.
          I agree though that prefix "i" isn't something inherently Java... sounds more like C# word ;(

          Show
          Konstantin Boudnik added a comment - Perhaps I have misunderstood your suggestion, but there's already Shell class in common. I agree though that prefix "i" isn't something inherently Java... sounds more like C# word ;(
          Hide
          Konstantin Boudnik added a comment -

          Renaming interfaces once more. TestCLI is passing.

          Show
          Konstantin Boudnik added a comment - Renaming interfaces once more. TestCLI is passing.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12459493/HADOOP-7014.patch
          against trunk revision 1034480.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 16 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/98//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/98//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/98//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12459493/HADOOP-7014.patch against trunk revision 1034480. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 16 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/98//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/98//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/98//console This message is automatically generated.
          Hide
          Konstantin Boudnik added a comment -

          Hopefully the last iteration of renaming

          Show
          Konstantin Boudnik added a comment - Hopefully the last iteration of renaming
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12459501/HADOOP-7014.patch
          against trunk revision 1034480.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 16 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/99//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/99//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/99//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12459501/HADOOP-7014.patch against trunk revision 1034480. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 16 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/99//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/99//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/99//console This message is automatically generated.
          Hide
          Todd Lipcon added a comment -

          Looks good to me. I like the new name better than the one with the 'i' for sure. +1

          Show
          Todd Lipcon added a comment - Looks good to me. I like the new name better than the one with the 'i' for sure. +1
          Hide
          Konstantin Boudnik added a comment -

          I will commit it shortly. However, it is going to break upstream (HDFS) project until HDFS-1486 is committed.

          Show
          Konstantin Boudnik added a comment - I will commit it shortly. However, it is going to break upstream (HDFS) project until HDFS-1486 is committed.
          Hide
          Konstantin Boudnik added a comment -

          New version of the patch: removed factories and switches.

          Show
          Konstantin Boudnik added a comment - New version of the patch: removed factories and switches.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12460419/HADOOP-7014.patch
          against trunk revision 1038493.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 23 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/123//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/123//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/123//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12460419/HADOOP-7014.patch against trunk revision 1038493. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 23 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/123//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/123//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/123//console This message is automatically generated.
          Hide
          Konstantin Boudnik added a comment -

          Generics need to use interface instead of a concrete implementation

          Show
          Konstantin Boudnik added a comment - Generics need to use interface instead of a concrete implementation
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12464935/HADOOP-7014.patch
          against trunk revision 1071364.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 23 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/255//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/255//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/255//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12464935/HADOOP-7014.patch against trunk revision 1071364. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 23 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/255//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/255//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/255//console This message is automatically generated.
          Hide
          Tom White added a comment -

          +1 If this is going to break HDFS and MapReduce builds, I would run their tests with the patch applied (and post the results to those JIRAs) so they can be committed at the same time.

          Show
          Tom White added a comment - +1 If this is going to break HDFS and MapReduce builds, I would run their tests with the patch applied (and post the results to those JIRAs) so they can be committed at the same time.
          Hide
          Konstantin Boudnik added a comment -

          Tom, I will post the test results logs there. Running test-patch however seems impossible at the moment because I can't force it to use internal resolvers without changing the script in many places.

          Show
          Konstantin Boudnik added a comment - Tom, I will post the test results logs there. Running test-patch however seems impossible at the moment because I can't force it to use internal resolvers without changing the script in many places.
          Hide
          Konstantin Boudnik added a comment -

          HDFS/MR full test cycles are successful so I am committing this shortly (which will temporarily break upstream builds).

          Show
          Konstantin Boudnik added a comment - HDFS/MR full test cycles are successful so I am committing this shortly (which will temporarily break upstream builds).
          Hide
          Konstantin Boudnik added a comment -

          I have just committed this.

          Show
          Konstantin Boudnik added a comment - I have just committed this.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #557 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/557/)
          HADOOP-7014. Adding missed files

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #557 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/557/ ) HADOOP-7014 . Adding missed files
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Hi Cos, HDFD does not compile

          compile-hdfs-test:
              [javac] Compiling 194 source files to /export/crawlspace/tsz/hdfs/h2/build/test/hdfs/classes
              [javac] /export/crawlspace/tsz/hdfs/h2/src/test/hdfs/org/apache/hadoop/cli/CmdFactoryDFS.java:20: cannot find symbol
              [javac] symbol  : class CLICommands
              [javac] location: package org.apache.hadoop.cli.util
              [javac] import org.apache.hadoop.cli.util.CLICommands;
              [javac]                                  ^
              [javac] /export/crawlspace/tsz/hdfs/h2/src/test/hdfs/org/apache/hadoop/cli/CmdFactoryDFS.java:22: cannot find symbol
              [javac] symbol  : class CmdFactory
              [javac] location: package org.apache.hadoop.cli.util
              [javac] import org.apache.hadoop.cli.util.CmdFactory;
              [javac]                                  ^
          
          ...
          
              [javac] 11 errors
          
          BUILD FAILED
          
          Show
          Tsz Wo Nicholas Sze added a comment - Hi Cos, HDFD does not compile compile-hdfs-test: [javac] Compiling 194 source files to /export/crawlspace/tsz/hdfs/h2/build/test/hdfs/classes [javac] /export/crawlspace/tsz/hdfs/h2/src/test/hdfs/org/apache/hadoop/cli/CmdFactoryDFS.java:20: cannot find symbol [javac] symbol : class CLICommands [javac] location: package org.apache.hadoop.cli.util [javac] import org.apache.hadoop.cli.util.CLICommands; [javac] ^ [javac] /export/crawlspace/tsz/hdfs/h2/src/test/hdfs/org/apache/hadoop/cli/CmdFactoryDFS.java:22: cannot find symbol [javac] symbol : class CmdFactory [javac] location: package org.apache.hadoop.cli.util [javac] import org.apache.hadoop.cli.util.CmdFactory; [javac] ^ ... [javac] 11 errors BUILD FAILED
          Hide
          Konstantin Boudnik added a comment -

          Nicholas, this is an expected side-effect (patch is here HDFS-1486). Sorry about this. I am running test-patch on HDFS to be technically clear about validity of upstream patch. It will be fixed in no time.

          Show
          Konstantin Boudnik added a comment - Nicholas, this is an expected side-effect (patch is here HDFS-1486 ). Sorry about this. I am running test-patch on HDFS to be technically clear about validity of upstream patch. It will be fixed in no time.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #663 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/663/)
          HADOOP-7014. Adding missed files
          HADOOP-7014. Generalize CLITest structure and interfaces to facilitate
          upstream adoption (e.g. for web testing). Contributed by Konstantin Boudnik

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #663 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/663/ ) HADOOP-7014 . Adding missed files HADOOP-7014 . Generalize CLITest structure and interfaces to facilitate upstream adoption (e.g. for web testing). Contributed by Konstantin Boudnik
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Hi Cos, hope the HDFS compilation problem could be fixed soon. Otherwise, we cannot continue development in HDFS. If you need more time, how about revert the committed patch?

          Show
          Tsz Wo Nicholas Sze added a comment - Hi Cos, hope the HDFS compilation problem could be fixed soon. Otherwise, we cannot continue development in HDFS. If you need more time, how about revert the committed patch?
          Hide
          Aaron T. Myers added a comment -

          Hey Nicholas, Cos committed both the corresponding HDFS and MAPREDUCE patches yesterday. Both of those projects should be back to compiling now.

          Show
          Aaron T. Myers added a comment - Hey Nicholas, Cos committed both the corresponding HDFS and MAPREDUCE patches yesterday. Both of those projects should be back to compiling now.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          @Cos, I just have tried. Everything is back to normal. Thanks.

          @Aaron, thanks for the info.

          Show
          Tsz Wo Nicholas Sze added a comment - @Cos, I just have tried. Everything is back to normal. Thanks. @Aaron, thanks for the info.

            People

            • Assignee:
              Konstantin Boudnik
              Reporter:
              Konstantin Boudnik
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development