Hadoop Common
  1. Hadoop Common
  2. HADOOP-7009

MD5Hash provides a public factory method that creates an instance of MessageDigest

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: io
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      MD5Hash has a private way of creating a MessageDigest object that's thread local. I'd like to have such a method which is public so that checksuming fsimage (HDFS-903) could use it.

      1. md5hash1.patch
        1 kB
        Hairong Kuang
      2. md5hash.patch
        1 kB
        Hairong Kuang

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #496 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/496/)
          HADOOP-7009. MD5Hash provides a public factory method that creates an instance of MessageDigest. Contributed by Hairong Kuang.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #496 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/496/ ) HADOOP-7009 . MD5Hash provides a public factory method that creates an instance of MessageDigest. Contributed by Hairong Kuang.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #405 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/405/)
          HADOOP-7009. MD5Hash provides a public factory method that creates an instance of MessageDigest. Contributed by Hairong Kuang.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #405 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/405/ ) HADOOP-7009 . MD5Hash provides a public factory method that creates an instance of MessageDigest. Contributed by Hairong Kuang.
          Hide
          Hairong Kuang added a comment -

          I've committed this!

          Show
          Hairong Kuang added a comment - I've committed this!
          Hide
          Hairong Kuang added a comment -

          All unit tests were passed. All 6 javadoc warnings are security-related and are unrelated to this patch. The patch is too trivial to have a unit test. I will commit it.

          Show
          Hairong Kuang added a comment - All unit tests were passed. All 6 javadoc warnings are security-related and are unrelated to this patch. The patch is too trivial to have a unit test. I will commit it.
          Hide
          Hairong Kuang added a comment -

          [exec] -1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] -1 tests included. The patch doesn't appe
          [exec] ar to include any new or modified tests.
          [exec] Please justify why no new tests are needed for this patch.
          [exec] Also please list what manual steps were performed to verify this patch.
          [exec]
          [exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
          [exec]
          [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          [exec]
          [exec] +1 system tests framework. The patch passed system tests framework compile.
          [exec]

          Show
          Hairong Kuang added a comment - [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appe [exec] ar to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system tests framework. The patch passed system tests framework compile. [exec]
          Hide
          Hairong Kuang added a comment -

          Eli, thanks for your review! This patch adds javadoc to the method.

          Show
          Hairong Kuang added a comment - Eli, thanks for your review! This patch adds javadoc to the method.
          Hide
          Eli Collins added a comment -

          +1

          Nit: getDigester needs a javadoc, and perhaps a name that suggests it returns a thread local?

          Show
          Eli Collins added a comment - +1 Nit: getDigester needs a javadoc, and perhaps a name that suggests it returns a thread local?
          Hide
          Hairong Kuang added a comment -

          Here is a simple patch that does this.

          Show
          Hairong Kuang added a comment - Here is a simple patch that does this.

            People

            • Assignee:
              Hairong Kuang
              Reporter:
              Hairong Kuang
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development