Hadoop Common
  1. Hadoop Common
  2. HADOOP-6985

Suggest that HADOOP_OPTS be preserved in hadoop-env.sh.template

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      For an administrator who wants to customize HADOOP_OPTS, it would be better to have

      1. if [ "$HADOOP_OPTS" == "" ]; then export HADOOP_OPTS=-server; else FOO+=" -server"; fi

      instead of

      1. Extra Java runtime options. Empty by default.
      2. export HADOOP_OPTS=-server
      1. HADOOP_6985.2.patch
        0.5 kB
        Ramkumar Vadali

        Activity

        Hide
        Doug Cutting added a comment -

        This looks reasonable to me. It's arguably not back-compatible, since settings of HADOOP_OPTS would previously be ignored. Does that concern anyone? If not, I'll commit this.

        Show
        Doug Cutting added a comment - This looks reasonable to me. It's arguably not back-compatible, since settings of HADOOP_OPTS would previously be ignored. Does that concern anyone? If not, I'll commit this.
        Hide
        dhruba borthakur added a comment -

        +1, the setting of HADOOP_OPTS would have been ignored prior to this patch.

        Show
        dhruba borthakur added a comment - +1, the setting of HADOOP_OPTS would have been ignored prior to this patch.
        Hide
        Doug Cutting added a comment -

        I committed this. Thanks, Ramkumar.

        Show
        Doug Cutting added a comment - I committed this. Thanks, Ramkumar.
        Hide
        Koji Noguchi added a comment -

        Curious.

        else FOO+=" -server"; fi

        Where is FOO being used?

        Show
        Koji Noguchi added a comment - Curious. else FOO+=" -server"; fi Where is FOO being used?
        Hide
        Ramkumar Vadali added a comment -

        Ugh! FOO -> HADOOP_OPTS
        Thats embarassing!

        Show
        Ramkumar Vadali added a comment - Ugh! FOO -> HADOOP_OPTS Thats embarassing!
        Hide
        Ramkumar Vadali added a comment -

        FOO->HADOOP_OPTS

        Show
        Ramkumar Vadali added a comment - FOO->HADOOP_OPTS
        Hide
        Ramkumar Vadali added a comment -

        FOO -> HADOOP_OPTS

        Show
        Ramkumar Vadali added a comment - FOO -> HADOOP_OPTS
        Hide
        Milind Bhandarkar added a comment -

        so, which version was committed ?

        Show
        Milind Bhandarkar added a comment - so, which version was committed ?
        Hide
        Milind Bhandarkar added a comment -

        sorry, checked commits. looks like the correct version was committed, but comment was not updated.

        Show
        Milind Bhandarkar added a comment - sorry, checked commits. looks like the correct version was committed, but comment was not updated.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #399 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/399/)
        HADOOP-6985. Fix example to make more sense.
        HADOOP-6985. Suggest that HADOOP-OPTS be preserved in hadoop-env.sh.template. Contributed by Ramkumar Vadali.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #399 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/399/ ) HADOOP-6985 . Fix example to make more sense. HADOOP-6985 . Suggest that HADOOP-OPTS be preserved in hadoop-env.sh.template. Contributed by Ramkumar Vadali.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #493 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/493/)
        HADOOP-6985. Fix example to make more sense.
        HADOOP-6985. Suggest that HADOOP-OPTS be preserved in hadoop-env.sh.template. Contributed by Ramkumar Vadali.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #493 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/493/ ) HADOOP-6985 . Fix example to make more sense. HADOOP-6985 . Suggest that HADOOP-OPTS be preserved in hadoop-env.sh.template. Contributed by Ramkumar Vadali.

          People

          • Assignee:
            Ramkumar Vadali
            Reporter:
            Ramkumar Vadali
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development