Hadoop Common
  1. Hadoop Common
  2. HADOOP-6975

integer overflow in S3InputStream for blocks > 2GB

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      S3InputStream has the same integer overflow issue as DFSInputStream (fixed in HDFS-96).

      1. HADOOP-6975.patch
        0.6 kB
        Patrick Kling

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #500 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/500/)
        HADOOP-6975. Integer overflow in S3InputStream for blocks > 2GB. Contributed by Patrick Kling.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #500 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/500/ ) HADOOP-6975 . Integer overflow in S3InputStream for blocks > 2GB. Contributed by Patrick Kling.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #409 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/409/)
        HADOOP-6975. Integer overflow in S3InputStream for blocks > 2GB. Contributed by Patrick Kling.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #409 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/409/ ) HADOOP-6975 . Integer overflow in S3InputStream for blocks > 2GB. Contributed by Patrick Kling.
        Hide
        Tom White added a comment -

        I've just committed this. Thanks Patrick!

        Show
        Tom White added a comment - I've just committed this. Thanks Patrick!
        Hide
        Tom White added a comment -

        I ran the unit tests and test-patch.

             [exec] -1 overall. 
             [exec]
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec]
             [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
             [exec]                         Please justify why no new tests are needed for this patch.
             [exec]                         Also please list what manual steps were performed to verify this patch.
             [exec]
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec]
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec]
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
             [exec]
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
             [exec]
             [exec]     +1 system tests framework.  The patch passed system tests framework compile.
             [exec]
             [exec] 
        
        Show
        Tom White added a comment - I ran the unit tests and test-patch. [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system tests framework. The patch passed system tests framework compile. [exec] [exec]
        Hide
        Patrick Kling added a comment -

        This patch is analogous to the patch for HDFS-96.

        Show
        Patrick Kling added a comment - This patch is analogous to the patch for HDFS-96 .

          People

          • Assignee:
            Patrick Kling
            Reporter:
            Patrick Kling
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development