Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None

      Description

      The getTGT method in AutoRenewal thread is moved to the outer UGI class. It is still a private method but can be used by reloginFromKeyTab to check for TGT expiry. This jira covers common changes for HDFS-1364

      1. HADOOP-6965.4.patch
        5 kB
        Jitendra Nath Pandey
      2. HADOOP-6965.3.patch
        6 kB
        Jitendra Nath Pandey
      3. HADOOP-6965.1.patch
        3 kB
        Jitendra Nath Pandey

        Issue Links

          Activity

          Jitendra Nath Pandey created issue -
          Jitendra Nath Pandey made changes -
          Field Original Value New Value
          Link This issue blocks HDFS-1364 [ HDFS-1364 ]
          Hide
          Jitendra Nath Pandey added a comment -

          This jira also introduces a checkTGTAndReloginFromKeytab method, which performs relogin only if TGT is closed to expiry.

          Show
          Jitendra Nath Pandey added a comment - This jira also introduces a checkTGTAndReloginFromKeytab method, which performs relogin only if TGT is closed to expiry.
          Jitendra Nath Pandey made changes -
          Attachment HADOOP-6965.1.patch [ 12455079 ]
          Jitendra Nath Pandey made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Jitendra Nath Pandey made changes -
          Attachment HADOOP-6965.3.patch [ 12455539 ]
          Hide
          Jitendra Nath Pandey added a comment -

          ant test and test-patch were run manually.
          All tests pass.

          test-patch results:

          [exec] +1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] +1 tests included. The patch appears to include 3 new or modified tests.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
          [exec]
          [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          [exec]
          [exec] +1 system tests framework. The patch passed system tests framework compile.

          Show
          Jitendra Nath Pandey added a comment - ant test and test-patch were run manually. All tests pass. test-patch results: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system tests framework. The patch passed system tests framework compile.
          Hide
          Devaraj Das added a comment -

          Some comments:
          1) Seems like you copy-pasted the 0.20 version of getTGT (from your patch on HDFS-1364). The trunk version in the ticket renewal thread is slightly different.
          2) Let's bite the bullet and remove the check for hasSufficientTimeElapsed in the reloginFromKeytab method. We may do the same for reloginFromTicketCache in a follow-up jira.
          3) The testcase can be removed. I don't think it is adding value. If it can be improved, fine (i understand its hard to write a unit test for this without a Kerberos test infrastructure).. otherwise a note on manual testing should be sufficient.

          Show
          Devaraj Das added a comment - Some comments: 1) Seems like you copy-pasted the 0.20 version of getTGT (from your patch on HDFS-1364 ). The trunk version in the ticket renewal thread is slightly different. 2) Let's bite the bullet and remove the check for hasSufficientTimeElapsed in the reloginFromKeytab method. We may do the same for reloginFromTicketCache in a follow-up jira. 3) The testcase can be removed. I don't think it is adding value. If it can be improved, fine (i understand its hard to write a unit test for this without a Kerberos test infrastructure).. otherwise a note on manual testing should be sufficient.
          Hide
          Jitendra Nath Pandey added a comment -

          New patch addressing the comments.

          The testcase has been removed. The patch been tested manually for 20 branch as pointed by Devraj.

          Show
          Jitendra Nath Pandey added a comment - New patch addressing the comments. The testcase has been removed. The patch been tested manually for 20 branch as pointed by Devraj.
          Jitendra Nath Pandey made changes -
          Attachment HADOOP-6965.4.patch [ 12455857 ]
          Hide
          Devaraj Das added a comment -

          I just committed this. Thanks, Jitendra!
          (I'll raise a jira for the follow up work on cleaning up reloginFromTicketCache, removing User.lastLogin, etc.)

          Show
          Devaraj Das added a comment - I just committed this. Thanks, Jitendra! (I'll raise a jira for the follow up work on cleaning up reloginFromTicketCache, removing User.lastLogin, etc.)
          Devaraj Das made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.22.0 [ 12314296 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #380 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/380/)
          HADOOP-6965. Introduces checks for whether the original tgt is valid in the reloginFromKeytab method. Contributed by Jitendra Pandey.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #380 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/380/ ) HADOOP-6965 . Introduces checks for whether the original tgt is valid in the reloginFromKeytab method. Contributed by Jitendra Pandey.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #465 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/465/)
          HADOOP-6965. Introduces checks for whether the original tgt is valid in the reloginFromKeytab method. Contributed by Jitendra Pandey.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #465 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/465/ ) HADOOP-6965 . Introduces checks for whether the original tgt is valid in the reloginFromKeytab method. Contributed by Jitendra Pandey.
          Konstantin Shvachko made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          7m 55s 1 Jitendra Nath Pandey 20/Sep/10 22:56
          Patch Available Patch Available Resolved Resolved
          7d 22h 28m 1 Devaraj Das 28/Sep/10 21:25
          Resolved Resolved Closed Closed
          439d 9h 53m 1 Konstantin Shvachko 12/Dec/11 06:19

            People

            • Assignee:
              Jitendra Nath Pandey
              Reporter:
              Jitendra Nath Pandey
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development