Hadoop Common
  1. Hadoop Common
  2. HADOOP-6963

Fix FileUtil.getDU. It should not include the size of the directory or follow symbolic links

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.20.205.0, 0.23.1
    • Fix Version/s: 0.23.3, 2.0.2-alpha
    • Component/s: fs
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      The getDU method should not include the size of the directory. The Java interface says that the value is undefined and in Linux/Sun it gets the 4096 for the inode. Clearly this isn't useful.
      It also recursively calls itself. In case the directory has a symbolic link forming a cycle, getDU keeps spinning in the cycle. In our case, we saw this in the org.apache.hadoop.mapred.JobLocalizer.downloadPrivateCacheObjects call. This prevented other tasks on the same node from committing, causing the TT to become effectively useless (because the JT thinks it already has enough tasks running)

      1. HADOOP-6963.branch-23.patch
        3 kB
        Ravi Prakash
      2. HADOOP-6963.branch-1.0.2.patch
        3 kB
        Ravi Prakash
      3. HADOOP-6963.branch-23.patch
        3 kB
        Robert Joseph Evans
      4. HADOOP-6963.branch-23.patch
        3 kB
        Ravi Prakash
      5. HADOOP-6963.branch-1.0.2.patch
        3 kB
        Ravi Prakash
      6. HADOOP-6963.branch-1.patch
        3 kB
        Ravi Prakash

        Activity

        Owen O'Malley created issue -
        Ravi Prakash made changes -
        Field Original Value New Value
        Summary FileUtil.getDU should not include the size of the directory Fix FileUtil.getDU. It should not include the size of the directory or follow symbolic links
        Affects Version/s 0.20.205.0 [ 12316390 ]
        Target Version/s 1.0.2 [ 12320152 ]
        Priority Major [ 3 ] Critical [ 2 ]
        Description The getDU method should not include the size of the directory. The Java interface says that the value is undefined and in Linux/Sun it gets the 4096 for the inode. Clearly this isn't useful. The getDU method should not include the size of the directory. The Java interface says that the value is undefined and in Linux/Sun it gets the 4096 for the inode. Clearly this isn't useful.
        It also recursively calls itself. In case the directory has a symbolic link forming a cycle, getDU keeps spinning in the cycle. In our case, we saw this in the org.apache.hadoop.mapred.JobLocalizer.downloadPrivateCacheObjects call. This prevented other tasks on the same node from committing, causing the TT to become effectively useless (because the JT thinks it already has enough tasks running)
        Ravi Prakash made changes -
        Affects Version/s 0.23.1 [ 12318884 ]
        Ravi Prakash made changes -
        Assignee Owen O'Malley [ owen.omalley ] Ravi Prakash [ raviprak ]
        Ravi Prakash made changes -
        Attachment HADOOP-6963.branch-23.patch [ 12520666 ]
        Ravi Prakash made changes -
        Target Version/s 1.0.2 [ 12320152 ] 1.0.3, 0.23.3 [ 12320248, 12320059 ]
        Ravi Prakash made changes -
        Attachment HADOOP-6963.branch-1.0.2.patch [ 12520989 ]
        Ravi Prakash made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Target Version/s 0.23.3, 1.0.3 [ 12320059, 12320248 ] 1.0.3, 0.23.3 [ 12320248, 12320059 ]
        Robert Joseph Evans made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Target Version/s 0.23.3, 1.0.3 [ 12320059, 12320248 ] 1.0.3, 0.23.3 [ 12320248, 12320059 ]
        Robert Joseph Evans made changes -
        Attachment HADOOP-6963.branch-23.patch [ 12521370 ]
        Robert Joseph Evans made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Target Version/s 0.23.3, 1.0.3 [ 12320059, 12320248 ] 1.0.3, 0.23.3 [ 12320248, 12320059 ]
        Ravi Prakash made changes -
        Attachment HADOOP-6963.branch-23.patch [ 12521513 ]
        Ravi Prakash made changes -
        Attachment HADOOP-6963.branch-1.0.2.patch [ 12521518 ]
        Tsz Wo Nicholas Sze made changes -
        Hadoop Flags Reviewed [ 10343 ]
        Target Version/s 0.23.3, 1.0.3 [ 12320059, 12320248 ] 1.0.3, 0.23.3 [ 12320248, 12320059 ]
        Tsz Wo Nicholas Sze made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Target Version/s 0.23.3, 1.0.3 [ 12320059, 12320248 ] 1.0.3, 0.23.3 [ 12320248, 12320059 ]
        Fix Version/s 2.0.0 [ 12320352 ]
        Fix Version/s 3.0.0 [ 12320357 ]
        Resolution Fixed [ 1 ]
        Robert Joseph Evans made changes -
        Fix Version/s 0.23.3 [ 12320059 ]
        Target Version/s 0.23.3, 1.0.3 [ 12320059, 12320248 ] 1.0.3, 0.23.3 [ 12320248, 12320059 ]
        Ravi Prakash made changes -
        Attachment HADOOP-6963.branch-1.patch [ 12521559 ]
        Ravi Prakash made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Tsz Wo Nicholas Sze made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Target Version/s 0.23.3, 1.0.3 [ 12320059, 12320248 ] 1.0.3, 0.23.3 [ 12320248, 12320059 ]
        Fix Version/s 1.0.3 [ 12320248 ]
        Fix Version/s 2.0.0 [ 12320352 ]
        Fix Version/s 3.0.0 [ 12320357 ]
        Resolution Fixed [ 1 ]
        Matt Foley made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Arun C Murthy made changes -
        Fix Version/s 2.0.2-alpha [ 12322473 ]
        Fix Version/s 1.0.3 [ 12320248 ]

          People

          • Assignee:
            Ravi Prakash
            Reporter:
            Owen O'Malley
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development