Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-6963

Fix FileUtil.getDU. It should not include the size of the directory or follow symbolic links

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 0.20.205.0, 0.23.1
    • 0.23.3, 2.0.2-alpha
    • fs
    • None
    • Reviewed

    Description

      The getDU method should not include the size of the directory. The Java interface says that the value is undefined and in Linux/Sun it gets the 4096 for the inode. Clearly this isn't useful.
      It also recursively calls itself. In case the directory has a symbolic link forming a cycle, getDU keeps spinning in the cycle. In our case, we saw this in the org.apache.hadoop.mapred.JobLocalizer.downloadPrivateCacheObjects call. This prevented other tasks on the same node from committing, causing the TT to become effectively useless (because the JT thinks it already has enough tasks running)

      Attachments

        1. HADOOP-6963.branch-23.patch
          3 kB
          Ravi Prakash
        2. HADOOP-6963.branch-23.patch
          3 kB
          Robert Joseph Evans
        3. HADOOP-6963.branch-23.patch
          3 kB
          Ravi Prakash
        4. HADOOP-6963.branch-1.patch
          3 kB
          Ravi Prakash
        5. HADOOP-6963.branch-1.0.2.patch
          3 kB
          Ravi Prakash
        6. HADOOP-6963.branch-1.0.2.patch
          3 kB
          Ravi Prakash

        Activity

          People

            raviprak Ravi Prakash
            omalley Owen O'Malley
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: