Hadoop Common
  1. Hadoop Common
  2. HADOOP-6950

Suggest that HADOOP_CLASSPATH should be preserved in hadoop-env.sh.template

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: scripts
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HADOOP_CLASSPATH tends to be used to add to bin/hadoop's classpath. Because of the way the comment is written, administrator's who customize hadoop-env.sh often inadvertently disable user's abilities to use it, by not including the present value of the variable.

      I propose we change the commented out suggestion code to include the present value.

       # Extra Java CLASSPATH elements.  Optional.
      -# export HADOOP_CLASSPATH=
      +# export HADOOP_CLASSPATH="<extra_entries>:$HADOOP_CLASSPATH"
      
      1. HADOOP-6950.patch.txt
        0.4 kB
        Philip Zeyliger

        Activity

        Hide
        Philip Zeyliger added a comment -

        Patch attached. This is a comment/doc change.

        Show
        Philip Zeyliger added a comment - Patch attached. This is a comment/doc change.
        Hide
        Eli Collins added a comment -

        +1 Seems reasonable. Thanks Philip.

        Show
        Eli Collins added a comment - +1 Seems reasonable. Thanks Philip.
        Hide
        Eli Collins added a comment -

        I've committed this. Thanks Philip.

        Show
        Eli Collins added a comment - I've committed this. Thanks Philip.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #376 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/376/)
        HADOOP-6950. Suggest that HADOOP_CLASSPATH should be preserved in hadoop-env.sh.template. Contributed by Philip Zeyliger.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #376 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/376/ ) HADOOP-6950 . Suggest that HADOOP_CLASSPATH should be preserved in hadoop-env.sh.template. Contributed by Philip Zeyliger.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #452 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/452/)
        HADOOP-6950. Suggest that HADOOP_CLASSPATH should be preserved in hadoop-env.sh.template. Contributed by Philip Zeyliger.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #452 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/452/ ) HADOOP-6950 . Suggest that HADOOP_CLASSPATH should be preserved in hadoop-env.sh.template. Contributed by Philip Zeyliger.

          People

          • Assignee:
            Philip Zeyliger
            Reporter:
            Philip Zeyliger
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development