Hadoop Common
  1. Hadoop Common
  2. HADOOP-6943

The GroupMappingServiceProvider interface should be public

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The GroupMappingServiceProvider interface is presently package-protected. It seems likely that many organizations will be implementing their own versions of this to suit their particular setup. It would be nice if this interface were made public, and annotated with "@InterfaceAudience.Private" and "@InterfaceStability.Evolving".

      1. hadoop-6943.txt.1
        0.8 kB
        Aaron T. Myers
      2. hadoop-6943.txt
        0.6 kB
        Aaron T. Myers

        Activity

        Hide
        Aaron T. Myers added a comment -

        Trivial patch to make the GroupMappingServiceProvider interface public. Left the annotations in place which were introduced in HADOOP-6668.

        Show
        Aaron T. Myers added a comment - Trivial patch to make the GroupMappingServiceProvider interface public. Left the annotations in place which were introduced in HADOOP-6668 .
        Hide
        Tom White added a comment -

        For developers to use this it should be marked as @Public. @Private means it can only be used within Hadoop. @Evolving sounds right for this interface.

        Show
        Tom White added a comment - For developers to use this it should be marked as @Public. @Private means it can only be used within Hadoop. @Evolving sounds right for this interface.
        Hide
        Aaron T. Myers added a comment -

        Thanks for the comments, Tom. I've updated the patch to address them.

        Show
        Aaron T. Myers added a comment - Thanks for the comments, Tom. I've updated the patch to address them.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12454556/hadoop-6943.txt.1
        against trunk revision 1031422.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/16//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/16//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/16//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12454556/hadoop-6943.txt.1 against trunk revision 1031422. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/16//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/16//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/16//console This message is automatically generated.
        Hide
        Tom White added a comment -

        I've just committed this. Thanks Aaron!

        (No new tests needed since this was a Java visibility change.)

        Show
        Tom White added a comment - I've just committed this. Thanks Aaron! (No new tests needed since this was a Java visibility change.)
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #415 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/415/)
        HADOOP-6943. The GroupMappingServiceProvider interface should be public. Contributed by Aaron T. Myers.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #415 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/415/ ) HADOOP-6943 . The GroupMappingServiceProvider interface should be public. Contributed by Aaron T. Myers.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #504 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/504/)
        HADOOP-6943. The GroupMappingServiceProvider interface should be public. Contributed by Aaron T. Myers.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #504 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/504/ ) HADOOP-6943 . The GroupMappingServiceProvider interface should be public. Contributed by Aaron T. Myers.

          People

          • Assignee:
            Aaron T. Myers
            Reporter:
            Aaron T. Myers
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development