Hadoop Common
  1. Hadoop Common
  2. HADOOP-6940

RawLocalFileSystem's markSupported method misnamed markSupport

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      It should be named markSupported to override the method defined in InputStream. Since it doesn't change the default no harm is done.

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #374 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/374/)
        HADOOP-6940. RawLocalFileSystem's markSupported method misnamed markSupport. Contributed by Tom White.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #374 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/374/ ) HADOOP-6940 . RawLocalFileSystem's markSupported method misnamed markSupport. Contributed by Tom White.
        Hide
        Eli Collins added a comment -

        I've committed this. Thanks Tom.

        Show
        Eli Collins added a comment - I've committed this. Thanks Tom.
        Hide
        Eli Collins added a comment -

        No tests are needed since the behavior stays unchanged. The javadoc warning seems bogus ant javadoc and javadoc-dev are clean.

             [exec] -1 overall.  
             [exec] 
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec] 
             [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
             [exec]                         Please justify why no new tests are needed for this patch.
             [exec]                         Also please list what manual steps were performed to verify this patch.
             [exec] 
             [exec]     -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.
             [exec] 
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec] 
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
             [exec] 
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
             [exec] 
             [exec]     +1 system tests framework.  The patch passed system tests framework compile.
             [exec] 
        
        Show
        Eli Collins added a comment - No tests are needed since the behavior stays unchanged. The javadoc warning seems bogus ant javadoc and javadoc-dev are clean. [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system tests framework. The patch passed system tests framework compile. [exec]
        Hide
        Eli Collins added a comment -

        +1 nice find.

        Show
        Eli Collins added a comment - +1 nice find.
        Hide
        Tom White added a comment -

        Patch which uses @Override to avoid this bug. It would be a good exercise to go through the code and use this annotation more widely.

        Show
        Tom White added a comment - Patch which uses @Override to avoid this bug. It would be a good exercise to go through the code and use this annotation more widely.

          People

          • Assignee:
            Tom White
            Reporter:
            Tom White
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development