Hadoop Common
  1. Hadoop Common
  2. HADOOP-6938

ConnectionId.getRemotePrincipal() should check if security is enabled

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: ipc, security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When security is not enabled, getRemotePrincipal() should return null, which means the Kerberos principal of the remote server is ignored. This bug was caught by TestCLI on Yahoo 20S branch.

      1. c6938-04.patch
        4 kB
        Kan Zhang
      2. c6938-03.patch
        2 kB
        Kan Zhang
      3. c6938-01.patch
        0.6 kB
        Kan Zhang

        Issue Links

          Activity

          Hide
          Kan Zhang added a comment -

          A one line patch.

          Show
          Kan Zhang added a comment - A one line patch.
          Hide
          Kan Zhang added a comment -

          adding a unit test for it.

          Show
          Kan Zhang added a comment - adding a unit test for it.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12453742/c6938-03.patch
          against trunk revision 991821.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system tests framework. The patch passed system tests framework compile.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/666/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/666/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/666/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/666/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12453742/c6938-03.patch against trunk revision 991821. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system tests framework. The patch passed system tests framework compile. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/666/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/666/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/666/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/666/console This message is automatically generated.
          Hide
          Kan Zhang added a comment -

          Similarly, I think pingInterval field should be ignored when doPing is set to false. I'll upload a new patch shortly.

          Show
          Kan Zhang added a comment - Similarly, I think pingInterval field should be ignored when doPing is set to false. I'll upload a new patch shortly.
          Hide
          Kan Zhang added a comment -

          uploading a new patch that ignores pingInterval when doPing is set to false.

          Show
          Kan Zhang added a comment - uploading a new patch that ignores pingInterval when doPing is set to false.
          Hide
          Hairong Kuang added a comment -

          +1 good catch!

          Show
          Hairong Kuang added a comment - +1 good catch!
          Hide
          Kan Zhang added a comment -

          ran ant test and test-patch locally. All passed. Javadoc warnings are unrelated. Also ran previously-failed TestMRCLI tests with the patch, they passed as well.

          [exec] -1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] +1 tests included. The patch appears to include 3 new or modified tests.
          [exec]
          [exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
          [exec]
          [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          [exec]
          [exec] +1 system tests framework. The patch passed system tests framework compile.

          Show
          Kan Zhang added a comment - ran ant test and test-patch locally. All passed. Javadoc warnings are unrelated. Also ran previously-failed TestMRCLI tests with the patch, they passed as well. [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system tests framework. The patch passed system tests framework compile.
          Hide
          Hairong Kuang added a comment -

          I've just committed this!

          Show
          Hairong Kuang added a comment - I've just committed this!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #373 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/373/)
          HADOOP-6938. ConnectionId.getRemotePrincipal() should check if security is enabled. Contributed by Kan Zhang.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #373 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/373/ ) HADOOP-6938 . ConnectionId.getRemotePrincipal() should check if security is enabled. Contributed by Kan Zhang.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #443 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/443/)
          HADOOP-6938. ConnectionId.getRemotePrincipal() should check if security is enabled. Contributed by Kan Zhang.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #443 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/443/ ) HADOOP-6938 . ConnectionId.getRemotePrincipal() should check if security is enabled. Contributed by Kan Zhang.

            People

            • Assignee:
              Kan Zhang
              Reporter:
              Kan Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development