Hadoop Common
  1. Hadoop Common
  2. HADOOP-6938

ConnectionId.getRemotePrincipal() should check if security is enabled

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: ipc, security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When security is not enabled, getRemotePrincipal() should return null, which means the Kerberos principal of the remote server is ignored. This bug was caught by TestCLI on Yahoo 20S branch.

      1. c6938-01.patch
        0.6 kB
        Kan Zhang
      2. c6938-03.patch
        2 kB
        Kan Zhang
      3. c6938-04.patch
        4 kB
        Kan Zhang

        Issue Links

          Activity

          Kan Zhang created issue -
          Kan Zhang made changes -
          Field Original Value New Value
          Component/s ipc [ 12310688 ]
          Component/s security [ 12312526 ]
          Kan Zhang made changes -
          Link This issue is related to HADOOP-6907 [ HADOOP-6907 ]
          Hide
          Kan Zhang added a comment -

          A one line patch.

          Show
          Kan Zhang added a comment - A one line patch.
          Kan Zhang made changes -
          Attachment c6938-01.patch [ 12453731 ]
          Hide
          Kan Zhang added a comment -

          adding a unit test for it.

          Show
          Kan Zhang added a comment - adding a unit test for it.
          Kan Zhang made changes -
          Attachment c6938-03.patch [ 12453742 ]
          Kan Zhang made changes -
          Summary ConnectiionId.getConnectionId() should check if security is enabled ConnectionId.getRemotePrincipal() should check if security is enabled
          Kan Zhang made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12453742/c6938-03.patch
          against trunk revision 991821.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system tests framework. The patch passed system tests framework compile.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/666/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/666/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/666/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/666/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12453742/c6938-03.patch against trunk revision 991821. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system tests framework. The patch passed system tests framework compile. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/666/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/666/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/666/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/666/console This message is automatically generated.
          Hide
          Kan Zhang added a comment -

          Similarly, I think pingInterval field should be ignored when doPing is set to false. I'll upload a new patch shortly.

          Show
          Kan Zhang added a comment - Similarly, I think pingInterval field should be ignored when doPing is set to false. I'll upload a new patch shortly.
          Hide
          Kan Zhang added a comment -

          uploading a new patch that ignores pingInterval when doPing is set to false.

          Show
          Kan Zhang added a comment - uploading a new patch that ignores pingInterval when doPing is set to false.
          Kan Zhang made changes -
          Attachment c6938-04.patch [ 12453791 ]
          Hide
          Hairong Kuang added a comment -

          +1 good catch!

          Show
          Hairong Kuang added a comment - +1 good catch!
          Boris Shkolnik made changes -
          Link This issue blocks MAPREDUCE-2050 [ MAPREDUCE-2050 ]
          Hide
          Kan Zhang added a comment -

          ran ant test and test-patch locally. All passed. Javadoc warnings are unrelated. Also ran previously-failed TestMRCLI tests with the patch, they passed as well.

          [exec] -1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] +1 tests included. The patch appears to include 3 new or modified tests.
          [exec]
          [exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
          [exec]
          [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          [exec]
          [exec] +1 system tests framework. The patch passed system tests framework compile.

          Show
          Kan Zhang added a comment - ran ant test and test-patch locally. All passed. Javadoc warnings are unrelated. Also ran previously-failed TestMRCLI tests with the patch, they passed as well. [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system tests framework. The patch passed system tests framework compile.
          Hide
          Hairong Kuang added a comment -

          I've just committed this!

          Show
          Hairong Kuang added a comment - I've just committed this!
          Hairong Kuang made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Fix Version/s 0.22.0 [ 12314296 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #373 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/373/)
          HADOOP-6938. ConnectionId.getRemotePrincipal() should check if security is enabled. Contributed by Kan Zhang.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #373 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/373/ ) HADOOP-6938 . ConnectionId.getRemotePrincipal() should check if security is enabled. Contributed by Kan Zhang.
          Eli Collins made changes -
          Link This issue blocks HDFS-1372 [ HDFS-1372 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #443 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/443/)
          HADOOP-6938. ConnectionId.getRemotePrincipal() should check if security is enabled. Contributed by Kan Zhang.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #443 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/443/ ) HADOOP-6938 . ConnectionId.getRemotePrincipal() should check if security is enabled. Contributed by Kan Zhang.
          Konstantin Shvachko made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Link This issue blocks MAPREDUCE-2050 [ MAPREDUCE-2050 ]
          Gavin made changes -
          Link This issue is depended upon by MAPREDUCE-2050 [ MAPREDUCE-2050 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          1h 41m 1 Kan Zhang 03/Sep/10 00:47
          Patch Available Patch Available Resolved Resolved
          20h 37m 1 Hairong Kuang 03/Sep/10 21:25
          Resolved Resolved Closed Closed
          464d 8h 54m 1 Konstantin Shvachko 12/Dec/11 06:19

            People

            • Assignee:
              Kan Zhang
              Reporter:
              Kan Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development