Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Hide
      Metrics names are standardized to use CapitalizedCamelCase. Some examples of this is:
      # Metrics names using "_" is changed to new naming scheme. Eg: bytes_written changes to BytesWritten.
      # All metrics names start with capitals. Example: threadsBlocked changes to ThreadsBlocked.
      Show
      Metrics names are standardized to use CapitalizedCamelCase. Some examples of this is: # Metrics names using "_" is changed to new naming scheme. Eg: bytes_written changes to BytesWritten. # All metrics names start with capitals. Example: threadsBlocked changes to ThreadsBlocked.
    • Tags:
      metrics2

      Description

      The jira tracks the metrics instrumentation for the new framework, i.e., porting jvm and rpc metrics to the new framework.

      This issue (esp. the "incompatible change flag") depends on the outcome of the discussion (proposed in HADOOP-6728) on whether we should support backward compatibility (at some cost.)

      1. hadoop-6920-metrics2-inst-v4.patch
        66 kB
        Luke Lu
      2. hadoop-6920.v6.patch
        67 kB
        Suresh Srinivas

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #685 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/685/)
          HADOOP-6920. Metrics instrumentation to move new metrics2 framework. Contributed by Luke Lu.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #685 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/685/ ) HADOOP-6920 . Metrics instrumentation to move new metrics2 framework. Contributed by Luke Lu.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #586 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/586/)
          HADOOP-6920. Metrics instrumentation to move new metrics2 framework. Contributed by Luke Lu.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #586 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/586/ ) HADOOP-6920 . Metrics instrumentation to move new metrics2 framework. Contributed by Luke Lu.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12478742/hadoop-6920.v6.patch
          against trunk revision 1101653.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/425//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/425//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/425//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478742/hadoop-6920.v6.patch against trunk revision 1101653. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/425//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/425//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/425//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12478742/hadoop-6920.v6.patch
          against trunk revision 1101668.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/426//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478742/hadoop-6920.v6.patch against trunk revision 1101668. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/426//console This message is automatically generated.
          Hide
          Suresh Srinivas added a comment -

          Updates to the patch:
          A minor bug fix in DefaultMetricsSystem.java and additional information in the hadoop-metrics2.properties to show how to configure the new metrics2 properties.

          Show
          Suresh Srinivas added a comment - Updates to the patch: A minor bug fix in DefaultMetricsSystem.java and additional information in the hadoop-metrics2.properties to show how to configure the new metrics2 properties.
          Hide
          Suresh Srinivas added a comment -

          +1 for the change. This patch is also forward port from 203, the metrics related infrastructure change.

          Show
          Suresh Srinivas added a comment - +1 for the change. This patch is also forward port from 203, the metrics related infrastructure change.
          Hide
          Luke Lu added a comment -

          The RAT warning is from an empty src/java/org/apache/hadoop/fs/shell/Display.java from Nicholas' commit for HADOOP-7251.

          Show
          Luke Lu added a comment - The RAT warning is from an empty src/java/org/apache/hadoop/fs/shell/Display.java from Nicholas' commit for HADOOP-7251 .
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12478470/hadoop-6920-metrics2-inst-v4.patch
          against trunk revision 1100369.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 11 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          -1 release audit. The applied patch generated 2 release audit warnings (more than the trunk's current 1 warnings).

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/417//testReport/
          Release audit warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/417//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/417//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/417//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478470/hadoop-6920-metrics2-inst-v4.patch against trunk revision 1100369. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit. The applied patch generated 2 release audit warnings (more than the trunk's current 1 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/417//testReport/ Release audit warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/417//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/417//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/417//console This message is automatically generated.
          Hide
          Luke Lu added a comment -

          This patch also moves the canonical package of EventCounter to org.apache.log.metrics

          Show
          Luke Lu added a comment - This patch also moves the canonical package of EventCounter to org.apache.log.metrics

            People

            • Assignee:
              Luke Lu
              Reporter:
              Luke Lu
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development