Hadoop Common
  1. Hadoop Common
  2. HADOOP-6903

Make AbstractFileSystem's methods public to allow filter-Fs like implementions in a differnt package than fs

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None

      Description

      Make AbstractFileSystem's methods public to allow filter-Fs like implementions in a differnt package than fs

      1. Hadoop-6903-7.patch
        44 kB
        Sanjay Radia
      2. Hadoop-6903-5.patch
        43 kB
        Sanjay Radia
      3. Hadoop-6903-4.patch
        42 kB
        Sanjay Radia
      4. Hadoop-6903-3.patch
        42 kB
        Sanjay Radia
      5. Hadoop-6903-2.patch
        42 kB
        Sanjay Radia
      6. Hadoop-6903.patch
        42 kB
        Sanjay Radia

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #511 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/511/)
          HADOOP-6903 Make AbstractFSileSystem methods and some FileContext methods to be public

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #511 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/511/ ) HADOOP-6903 Make AbstractFSileSystem methods and some FileContext methods to be public
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #422 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/422/)
          HADOOP-6903 Make AbstractFSileSystem methods and some FileContext methods to be public

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #422 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/422/ ) HADOOP-6903 Make AbstractFSileSystem methods and some FileContext methods to be public
          Hide
          Sanjay Radia added a comment -

          Committed.

          Show
          Sanjay Radia added a comment - Committed.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12459202/Hadoop-6903-7.patch
          against trunk revision 1032730.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 15 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/84//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/84//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/84//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12459202/Hadoop-6903-7.patch against trunk revision 1032730. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 15 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/84//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/84//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/84//console This message is automatically generated.
          Hide
          Sanjay Radia added a comment -

          Thanks, update patch addresses the feedback.

          Show
          Sanjay Radia added a comment - Thanks, update patch addresses the feedback.
          Hide
          Suresh Srinivas added a comment -

          Comments:

          1. Discarded the change in UnsupportedFileSystemException.java is not needed. The change in the patch already exists on trunk.
          2. AFS.java - what is the need to make AFS#statistics public? Should it remain protected?
          3. AFS#setWorkingDirectory() method javadoc - use javadoc list for adding bullets in javadoc.
          4. Some of the lines in FileContextTestHelper.java are more than 80 columns (though introduced by another patch).
          Show
          Suresh Srinivas added a comment - Comments: Discarded the change in UnsupportedFileSystemException.java is not needed. The change in the patch already exists on trunk. AFS.java - what is the need to make AFS#statistics public? Should it remain protected? AFS#setWorkingDirectory() method javadoc - use javadoc list for adding bullets in javadoc. Some of the lines in FileContextTestHelper.java are more than 80 columns (though introduced by another patch).
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12459075/Hadoop-6903-5.patch
          against trunk revision 1031948.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 14 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/80//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/80//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/80//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12459075/Hadoop-6903-5.patch against trunk revision 1031948. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 14 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/80//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/80//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/80//console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          Never mind, just looks like a formatting issue in the patch, eg one of the brackets is indented to the wrong level.

          Show
          Eli Collins added a comment - Never mind, just looks like a formatting issue in the patch, eg one of the brackets is indented to the wrong level.
          Hide
          Eli Collins added a comment -

          Is Hadoop-6903-4.patch the right patch? It looks like eg containsPath is missing a curly brace.

          Show
          Eli Collins added a comment - Is Hadoop-6903-4.patch the right patch? It looks like eg containsPath is missing a curly brace.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12458919/Hadoop-6903-4.patch
          against trunk revision 1031422.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 11 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/59//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/59//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/59//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12458919/Hadoop-6903-4.patch against trunk revision 1031422. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/59//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/59//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/59//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12458915/Hadoop-6903-3.patch
          against trunk revision 1031422.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 11 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/58//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/58//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/58//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12458915/Hadoop-6903-3.patch against trunk revision 1031422. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/58//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/58//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/58//console This message is automatically generated.
          Hide
          Sanjay Radia added a comment -

          Fixed the javadoc warning.

          Show
          Sanjay Radia added a comment - Fixed the javadoc warning.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12458855/Hadoop-6903-2.patch
          against trunk revision 1031422.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 11 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/24//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/24//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/24//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12458855/Hadoop-6903-2.patch against trunk revision 1031422. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/24//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/24//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/24//console This message is automatically generated.
          Hide
          Sanjay Radia added a comment -

          Patch attached:

          • Makes the methods of AbstractFileSystem public
          • Also makes a couple of protected methods in FileContext public that were a problem when implementing in different
            package.
          • added several additional tests.
          • Filxed a problem in the FileContext:setWorkingDir() that i uncovered in the tests.
          Show
          Sanjay Radia added a comment - Patch attached: Makes the methods of AbstractFileSystem public Also makes a couple of protected methods in FileContext public that were a problem when implementing in different package. added several additional tests. Filxed a problem in the FileContext:setWorkingDir() that i uncovered in the tests.
          Hide
          Sanjay Radia added a comment -

          The methods are visible to subclasses but one cannot call another instance of the AbstractFileSystem. One often needs to do that in a when using a filter file system like approach.

          Show
          Sanjay Radia added a comment - The methods are visible to subclasses but one cannot call another instance of the AbstractFileSystem. One often needs to do that in a when using a filter file system like approach.
          Hide
          Vivek Mishra added a comment -

          Hi Sanjay,
          i am a beginner for Hadoop code base. I might be wrong but i have 1 question.
          All methods are protected but was wondering that implementation of mount table file system should be extending AbstractFileSystem so methods should be visible.
          +1 for protected static methods.

          Show
          Vivek Mishra added a comment - Hi Sanjay, i am a beginner for Hadoop code base. I might be wrong but i have 1 question. All methods are protected but was wondering that implementation of mount table file system should be extending AbstractFileSystem so methods should be visible. +1 for protected static methods.
          Hide
          Sanjay Radia added a comment -

          I was implementing a mount table file system in a package called viewFs. As part of this I had to call an instance of AbstractFilesSystem. Unfortunately the methods are protected.
          I am proposing that we make the methods public to allow the convenience of using other packages besides o.a.h.fs.

          Show
          Sanjay Radia added a comment - I was implementing a mount table file system in a package called viewFs. As part of this I had to call an instance of AbstractFilesSystem. Unfortunately the methods are protected. I am proposing that we make the methods public to allow the convenience of using other packages besides o.a.h.fs.

            People

            • Assignee:
              Sanjay Radia
              Reporter:
              Sanjay Radia
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development