[HADOOP-6897] FileSystem#mkdirs(FileSystem, Path, FsPermission) should not call setPermission if mkdirs failled

• Type: Bug
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 0.22.0
• Assignee: Hairong Kuang
• Reporter: Hairong Kuang
• Created: 03/Aug/10 22:37
• Updated: 22/Mar/18 15:10

Description

Here is the piece of code that has the bug. fs.setPermission should not be called if result is false.

  public static boolean mkdirs(FileSystem fs, Path dir, FsPermission permission)
  throws IOException {
    // create the directory using the default permission
    boolean result = fs.mkdirs(dir);
    // set its permission to be the supplied one
    fs.setPermission(dir, permission);
    return result;
  }

Issue Links

• is related to: HDFS-1322 Document umask in DistributedFileSystem#mkdirs javadocs
• relates to: HADOOP-6962 FileSystem.mkdirs(Path, FSPermission) should use the permission for all of the created directories