[HADOOP-6890] Improve listFiles API introduced by HADOOP-6870

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.22.0
• Fix Version/s: 0.22.0
• Component/s: fs
• Hadoop Flags: Reviewed
• Assignee: Hairong Kuang
• Reporter: Hairong Kuang
• Created: 29/Jul/10 22:24
• Updated: 12/Dec/11 06:19
• Resolved: 02/Aug/10 20:30

Description

This jira is mainly for addressing Suresh's review comments for HADOOP-6870:

1. General comment: I have concerns about recursive listing. This could be abused by the applications, creating a lot of requests into HDFS.
2. Any deletion of files/directories while reursing through directories results in RuntimeException and application has a partial result. Should we ignore if a directory was in stack and was not found later when iterating through it?
3. FileSystem.java

• listFile() - method javadoc could be better organized - first write about if path is directory and two cases recursive=true and false. Then if path is file and two cases recursive=true or false.
• listFile() - document throwing RuntimeException, UnsupportedOperationException and the possible cause. IOException is no longer thrown.
  4. TestListFiles.java
• testDirectory() - comments test empty directory and test directory with 1 file should be moved up to relevant sections of the test.

Issue Links

• is related to: HADOOP-6870 Add FileSystem#listLocatedStatus to list a directory's content together with each file's block locations